You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/01/06 01:15:12 UTC
Review Request 55240: Stop using os::system to copy local files.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55240/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Jiang Yan Xu.
Bugs: MESOS-6862
https://issues.apache.org/jira/browse/MESOS-6862
Repository: mesos
Description
-------
Stop using os::system to copy local files.
Diffs
-----
src/launcher/fetcher.cpp 4456c28139966e42859cc6d2c79a1d90e83fb22f
Diff: https://reviews.apache.org/r/55240/diff/
Testing
-------
`sudo make check` (Fedora 25)
Thanks,
James Peach
Re: Review Request 55240: Stop using os::system to copy local files.
Posted by James Peach <jp...@apache.org>.
> On Jan. 11, 2017, 9:57 a.m., Jiang Yan Xu wrote:
> > I commented on /r/55239/ about the `_spawn()` helper. We could just use `os::spawn()` directly here.
The `_spawn` helper is still an improvement here since it gets the error message right. If we remove the helper in the previous review, I guess we can still use `spawn` here and format the error correctly.
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55240/#review161198
-----------------------------------------------------------
On Jan. 6, 2017, 1:15 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55240/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2017, 1:15 a.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Bugs: MESOS-6862
> https://issues.apache.org/jira/browse/MESOS-6862
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stop using os::system to copy local files.
>
>
> Diffs
> -----
>
> src/launcher/fetcher.cpp 4456c28139966e42859cc6d2c79a1d90e83fb22f
>
> Diff: https://reviews.apache.org/r/55240/diff/
>
>
> Testing
> -------
>
> `sudo make check` (Fedora 25)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 55240: Stop using os::system to copy local files.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55240/#review161198
-----------------------------------------------------------
I commented on /r/55239/ about the `_spawn()` helper. We could just use `os::spawn()` directly here.
- Jiang Yan Xu
On Jan. 5, 2017, 5:15 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55240/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2017, 5:15 p.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Bugs: MESOS-6862
> https://issues.apache.org/jira/browse/MESOS-6862
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stop using os::system to copy local files.
>
>
> Diffs
> -----
>
> src/launcher/fetcher.cpp 4456c28139966e42859cc6d2c79a1d90e83fb22f
>
> Diff: https://reviews.apache.org/r/55240/diff/
>
>
> Testing
> -------
>
> `sudo make check` (Fedora 25)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 55240: Stop using os::system to copy local files.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55240/#review161412
-----------------------------------------------------------
Ship it!
- Jiang Yan Xu
On Jan. 11, 2017, 4:27 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55240/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 4:27 p.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Bugs: MESOS-6862
> https://issues.apache.org/jira/browse/MESOS-6862
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stop using os::system to copy local files.
>
>
> Diffs
> -----
>
> src/launcher/fetcher.cpp 4456c28139966e42859cc6d2c79a1d90e83fb22f
>
> Diff: https://reviews.apache.org/r/55240/diff/
>
>
> Testing
> -------
>
> `sudo make check` (Fedora 25)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 55240: Stop using os::system to copy local files.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55240/
-----------------------------------------------------------
(Updated Jan. 17, 2017, 10:05 p.m.)
Review request for mesos, Jie Yu and Jiang Yan Xu.
Changes
-------
Rebase.
Bugs: MESOS-6862
https://issues.apache.org/jira/browse/MESOS-6862
Repository: mesos
Description
-------
Stop using os::system to copy local files.
Diffs (updated)
-----
src/launcher/fetcher.cpp 4456c28139966e42859cc6d2c79a1d90e83fb22f
Diff: https://reviews.apache.org/r/55240/diff/
Testing
-------
`sudo make check` (Fedora 25)
Thanks,
James Peach
Re: Review Request 55240: Stop using os::system to copy local files.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55240/
-----------------------------------------------------------
(Updated Jan. 13, 2017, 11:11 p.m.)
Review request for mesos, Jie Yu and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-6862
https://issues.apache.org/jira/browse/MESOS-6862
Repository: mesos
Description
-------
Stop using os::system to copy local files.
Diffs (updated)
-----
src/launcher/fetcher.cpp 4456c28139966e42859cc6d2c79a1d90e83fb22f
Diff: https://reviews.apache.org/r/55240/diff/
Testing
-------
`sudo make check` (Fedora 25)
Thanks,
James Peach
Re: Review Request 55240: Stop using os::system to copy local files.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55240/
-----------------------------------------------------------
(Updated Jan. 12, 2017, 12:27 a.m.)
Review request for mesos, Jie Yu and Jiang Yan Xu.
Changes
-------
Rebase and address review feedback.
Bugs: MESOS-6862
https://issues.apache.org/jira/browse/MESOS-6862
Repository: mesos
Description
-------
Stop using os::system to copy local files.
Diffs (updated)
-----
src/launcher/fetcher.cpp 4456c28139966e42859cc6d2c79a1d90e83fb22f
Diff: https://reviews.apache.org/r/55240/diff/
Testing
-------
`sudo make check` (Fedora 25)
Thanks,
James Peach