You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "wuwenchi (via GitHub)" <gi...@apache.org> on 2024/07/14 02:44:40 UTC
[PR] [bugfix](external)Modify the default value of `pushdowncount` [doris]
wuwenchi opened a new pull request, #37754:
URL: https://github.com/apache/doris/pull/37754
## Proposed changes
1. Do not use `0`: If the number of entries in the table is 0, it is unclear whether optimization has been performed.
2. Do not use `null` or `-`: This makes it easier for the program to parse the `explain` data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](external)Modify the default value of `pushdowncount` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37754:
URL: https://github.com/apache/doris/pull/37754#issuecomment-2227182240
<details>
<summary>TPC-H: <b>Total hot run time: 39893 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e81f7fcce78dac7b4a92a03f8d59339fe33911a3, data reload: false
------ Round 1 ----------------------------------
q1 17657 4371 4298 4298
q2 2023 190 194 190
q3 10441 1204 1133 1133
q4 10194 843 795 795
q5 7531 2684 2655 2655
q6 219 141 143 141
q7 960 603 603 603
q8 9222 2061 2057 2057
q9 8880 6582 6580 6580
q10 8753 3807 3759 3759
q11 466 233 238 233
q12 443 225 221 221
q13 18487 3010 2983 2983
q14 277 233 241 233
q15 526 483 496 483
q16 502 373 374 373
q17 955 589 688 589
q18 8098 7448 7436 7436
q19 6586 1415 1399 1399
q20 652 324 313 313
q21 4820 3136 3256 3136
q22 343 285 283 283
Total cold run time: 118035 ms
Total hot run time: 39893 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4461 4233 4302 4233
q2 361 275 261 261
q3 3028 2915 2951 2915
q4 1979 1637 1761 1637
q5 5578 5553 5474 5474
q6 223 137 135 135
q7 2264 1852 1834 1834
q8 3253 3450 3444 3444
q9 8723 8814 8776 8776
q10 4141 3818 3825 3818
q11 587 499 514 499
q12 835 620 623 620
q13 15988 3168 3168 3168
q14 321 283 277 277
q15 533 483 491 483
q16 475 426 454 426
q17 1888 1542 1483 1483
q18 8120 7959 7945 7945
q19 1791 1434 1514 1434
q20 2895 1859 1845 1845
q21 5098 4882 4681 4681
q22 719 518 518 518
Total cold run time: 73261 ms
Total hot run time: 55906 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](external)Modify the default value of `pushdowncount` [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37754:
URL: https://github.com/apache/doris/pull/37754#issuecomment-2227270331
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](external)Modify the default value of `pushdowncount` [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37754:
URL: https://github.com/apache/doris/pull/37754#issuecomment-2227270339
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](external)Modify the default value of `pushdowncount` [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #37754:
URL: https://github.com/apache/doris/pull/37754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](external)Modify the default value of `pushdowncount` [doris]
Posted by "wuwenchi (via GitHub)" <gi...@apache.org>.
wuwenchi commented on PR #37754:
URL: https://github.com/apache/doris/pull/37754#issuecomment-2227174810
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](external)Modify the default value of `pushdowncount` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37754:
URL: https://github.com/apache/doris/pull/37754#issuecomment-2227224364
<details>
<summary>TPC-H: <b>Total hot run time: 39949 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ec4377a0e782edac724bf6ca79ebaf73fce74985, data reload: false
------ Round 1 ----------------------------------
q1 17621 4332 4273 4273
q2 2026 193 194 193
q3 10425 1223 1113 1113
q4 10186 737 801 737
q5 7541 2704 2755 2704
q6 220 140 142 140
q7 949 603 603 603
q8 9219 2046 2070 2046
q9 8621 6542 6545 6542
q10 8680 3762 3792 3762
q11 465 231 237 231
q12 406 230 235 230
q13 18382 2977 2991 2977
q14 272 241 236 236
q15 532 508 492 492
q16 512 384 381 381
q17 967 651 690 651
q18 7962 7438 7385 7385
q19 7818 1418 1448 1418
q20 645 321 322 321
q21 4978 3228 4066 3228
q22 341 286 291 286
Total cold run time: 118768 ms
Total hot run time: 39949 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4391 4338 4246 4246
q2 374 253 263 253
q3 3053 2912 2943 2912
q4 1989 1795 1722 1722
q5 5567 5524 5430 5430
q6 228 135 143 135
q7 2228 1852 1841 1841
q8 3288 3428 3387 3387
q9 8693 8855 8820 8820
q10 4112 3825 3805 3805
q11 590 499 510 499
q12 799 645 618 618
q13 16434 3200 3167 3167
q14 316 297 284 284
q15 552 494 490 490
q16 498 459 428 428
q17 1839 1529 1467 1467
q18 8080 7871 7717 7717
q19 1784 1578 1681 1578
q20 2133 1858 1846 1846
q21 7416 4944 4694 4694
q22 603 527 505 505
Total cold run time: 74967 ms
Total hot run time: 55844 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](external)Modify the default value of `pushdowncount` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37754:
URL: https://github.com/apache/doris/pull/37754#issuecomment-2227184672
<details>
<summary>ClickBench: <b>Total hot run time: 30.39 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e81f7fcce78dac7b4a92a03f8d59339fe33911a3, data reload: false
query1 0.04 0.04 0.02
query2 0.08 0.03 0.04
query3 0.22 0.06 0.05
query4 1.65 0.08 0.11
query5 0.49 0.48 0.49
query6 1.15 0.74 0.73
query7 0.02 0.02 0.01
query8 0.06 0.04 0.05
query9 0.55 0.50 0.49
query10 0.55 0.53 0.54
query11 0.16 0.11 0.11
query12 0.15 0.12 0.12
query13 0.59 0.59 0.59
query14 0.76 0.79 0.81
query15 0.85 0.83 0.80
query16 0.38 0.37 0.37
query17 0.97 1.06 1.02
query18 0.23 0.21 0.22
query19 1.82 1.68 1.70
query20 0.01 0.01 0.02
query21 15.39 0.76 0.66
query22 4.64 7.08 1.73
query23 18.28 1.39 1.34
query24 2.16 0.23 0.21
query25 0.15 0.09 0.08
query26 0.28 0.20 0.21
query27 0.45 0.23 0.22
query28 13.23 1.02 0.99
query29 12.66 3.26 3.25
query30 0.25 0.06 0.06
query31 2.87 0.39 0.38
query32 3.29 0.48 0.48
query33 2.89 2.91 2.92
query34 17.02 4.33 4.35
query35 4.38 4.36 4.38
query36 0.65 0.46 0.46
query37 0.19 0.15 0.16
query38 0.15 0.14 0.16
query39 0.04 0.03 0.04
query40 0.17 0.13 0.12
query41 0.10 0.05 0.05
query42 0.06 0.04 0.05
query43 0.04 0.04 0.04
Total cold run time: 110.07 s
Total hot run time: 30.39 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](external)Modify the default value of `pushdowncount` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37754:
URL: https://github.com/apache/doris/pull/37754#issuecomment-2227175134
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](external)Modify the default value of `pushdowncount` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37754:
URL: https://github.com/apache/doris/pull/37754#issuecomment-2227183975
<details>
<summary>TPC-DS: <b>Total hot run time: 173630 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e81f7fcce78dac7b4a92a03f8d59339fe33911a3, data reload: false
query1 925 382 371 371
query2 6601 1947 1812 1812
query3 6637 207 218 207
query4 28188 17524 17363 17363
query5 3607 468 501 468
query6 292 168 172 168
query7 4604 287 285 285
query8 240 194 200 194
query9 8565 2366 2342 2342
query10 427 281 271 271
query11 11403 10124 10131 10124
query12 113 84 82 82
query13 1623 354 356 354
query14 10262 7599 7662 7599
query15 217 166 166 166
query16 7757 310 303 303
query17 1808 556 522 522
query18 1906 269 276 269
query19 194 143 146 143
query20 85 81 77 77
query21 206 133 126 126
query22 4404 4233 4138 4138
query23 34279 33702 33797 33702
query24 9934 2891 2968 2891
query25 596 393 405 393
query26 703 149 157 149
query27 2200 281 275 275
query28 5798 2036 2077 2036
query29 883 655 623 623
query30 262 157 152 152
query31 1031 787 759 759
query32 93 58 56 56
query33 662 296 298 296
query34 902 505 513 505
query35 674 600 625 600
query36 1139 1017 1014 1014
query37 145 86 89 86
query38 2961 2886 2955 2886
query39 930 825 837 825
query40 207 128 128 128
query41 49 46 44 44
query42 114 97 105 97
query43 502 470 479 470
query44 1103 730 753 730
query45 194 164 164 164
query46 1080 713 721 713
query47 1835 1786 1822 1786
query48 376 292 292 292
query49 838 433 428 428
query50 786 406 399 399
query51 6841 6811 6758 6758
query52 110 94 92 92
query53 359 290 295 290
query54 850 470 459 459
query55 76 79 73 73
query56 308 283 278 278
query57 1110 1073 1057 1057
query58 263 262 262 262
query59 2895 2669 2557 2557
query60 312 296 294 294
query61 118 112 115 112
query62 794 658 627 627
query63 328 295 291 291
query64 9316 2200 1643 1643
query65 3183 3104 3093 3093
query66 750 322 327 322
query67 15774 14870 14824 14824
query68 4588 516 529 516
query69 579 414 343 343
query70 1098 1095 1095 1095
query71 430 279 290 279
query72 9146 5282 5718 5282
query73 779 335 333 333
query74 6069 5607 5639 5607
query75 3597 2722 2658 2658
query76 2758 1008 921 921
query77 642 300 308 300
query78 11725 9333 9175 9175
query79 3711 516 508 508
query80 1400 476 464 464
query81 581 220 220 220
query82 627 132 132 132
query83 346 174 169 169
query84 277 90 86 86
query85 915 320 325 320
query86 459 337 316 316
query87 3370 3136 3073 3073
query88 4544 2518 2459 2459
query89 491 378 396 378
query90 1940 195 195 195
query91 129 100 100 100
query92 62 51 49 49
query93 4090 488 505 488
query94 1274 220 217 217
query95 415 322 322 322
query96 607 271 279 271
query97 3205 3014 3008 3008
query98 224 201 194 194
query99 1544 1237 1278 1237
Total cold run time: 285349 ms
Total hot run time: 173630 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](external)Modify the default value of `pushdowncount` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37754:
URL: https://github.com/apache/doris/pull/37754#issuecomment-2227227054
<details>
<summary>TPC-DS: <b>Total hot run time: 172355 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ec4377a0e782edac724bf6ca79ebaf73fce74985, data reload: false
query1 915 369 352 352
query2 6434 1823 1861 1823
query3 6630 208 216 208
query4 28047 17352 17416 17352
query5 3594 463 466 463
query6 262 179 166 166
query7 4581 287 282 282
query8 238 205 207 205
query9 8611 2351 2336 2336
query10 430 285 273 273
query11 11771 9924 10131 9924
query12 113 82 88 82
query13 1645 370 363 363
query14 10199 7065 7661 7065
query15 244 167 166 166
query16 7664 304 315 304
query17 1807 535 514 514
query18 1786 273 271 271
query19 192 143 147 143
query20 90 81 79 79
query21 216 128 121 121
query22 4264 4170 3994 3994
query23 34026 33640 33541 33541
query24 11159 2804 2877 2804
query25 616 387 371 371
query26 969 147 145 145
query27 2323 271 277 271
query28 6696 2047 2010 2010
query29 879 664 622 622
query30 248 156 154 154
query31 1004 774 770 770
query32 99 57 55 55
query33 767 299 296 296
query34 1054 485 493 485
query35 683 639 584 584
query36 1108 985 974 974
query37 153 85 87 85
query38 2975 2800 2939 2800
query39 895 837 834 834
query40 212 121 125 121
query41 48 44 49 44
query42 111 101 102 101
query43 523 497 470 470
query44 1245 731 722 722
query45 190 161 164 161
query46 1083 771 722 722
query47 1857 1761 1755 1755
query48 371 288 292 288
query49 844 396 401 396
query50 782 383 390 383
query51 6936 6791 6807 6791
query52 114 89 89 89
query53 354 284 279 279
query54 864 452 440 440
query55 76 73 72 72
query56 289 302 275 275
query57 1150 1059 1079 1059
query58 238 249 245 245
query59 2846 2813 2553 2553
query60 292 281 275 275
query61 96 96 93 93
query62 777 633 648 633
query63 318 285 285 285
query64 9340 2214 1721 1721
query65 3160 3098 3101 3098
query66 740 342 328 328
query67 15615 14880 14957 14880
query68 4600 526 529 526
query69 646 415 358 358
query70 1164 1100 1149 1100
query71 432 296 277 277
query72 7562 5882 5564 5564
query73 760 320 319 319
query74 5924 5645 5547 5547
query75 3559 2697 2702 2697
query76 3357 969 943 943
query77 655 299 287 287
query78 9590 9559 8995 8995
query79 3376 513 511 511
query80 2051 467 470 467
query81 594 221 220 220
query82 1255 136 126 126
query83 326 168 169 168
query84 275 90 89 89
query85 1533 317 358 317
query86 354 322 311 311
query87 3303 3102 3114 3102
query88 4309 2463 2434 2434
query89 484 378 397 378
query90 1757 196 187 187
query91 127 102 96 96
query92 62 50 47 47
query93 4794 485 480 480
query94 858 215 205 205
query95 397 314 315 314
query96 616 274 271 271
query97 3203 3018 3007 3007
query98 222 199 197 197
query99 1583 1249 1263 1249
Total cold run time: 285586 ms
Total hot run time: 172355 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](external)Modify the default value of `pushdowncount` [doris]
Posted by "wuwenchi (via GitHub)" <gi...@apache.org>.
wuwenchi commented on PR #37754:
URL: https://github.com/apache/doris/pull/37754#issuecomment-2227215671
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](external)Modify the default value of `pushdowncount` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37754:
URL: https://github.com/apache/doris/pull/37754#issuecomment-2227228326
<details>
<summary>ClickBench: <b>Total hot run time: 30.78 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ec4377a0e782edac724bf6ca79ebaf73fce74985, data reload: false
query1 0.03 0.03 0.03
query2 0.09 0.04 0.04
query3 0.22 0.05 0.05
query4 1.68 0.06 0.07
query5 0.53 0.50 0.48
query6 1.14 0.72 0.72
query7 0.02 0.02 0.01
query8 0.05 0.04 0.05
query9 0.57 0.50 0.49
query10 0.55 0.55 0.54
query11 0.15 0.11 0.12
query12 0.14 0.11 0.12
query13 0.59 0.58 0.58
query14 0.77 0.77 0.79
query15 0.86 0.81 0.81
query16 0.36 0.37 0.37
query17 0.98 1.00 0.98
query18 0.22 0.22 0.22
query19 1.78 1.80 1.67
query20 0.02 0.01 0.01
query21 15.40 0.77 0.65
query22 4.11 7.35 2.09
query23 18.25 1.41 1.25
query24 2.11 0.22 0.22
query25 0.16 0.09 0.08
query26 0.29 0.21 0.21
query27 0.45 0.23 0.22
query28 13.27 1.00 1.01
query29 12.64 3.40 3.35
query30 0.25 0.06 0.05
query31 2.87 0.39 0.38
query32 3.29 0.49 0.48
query33 2.92 2.87 2.97
query34 17.00 4.40 4.36
query35 4.41 4.40 4.40
query36 0.66 0.49 0.49
query37 0.19 0.16 0.16
query38 0.15 0.15 0.15
query39 0.05 0.04 0.03
query40 0.16 0.13 0.13
query41 0.10 0.05 0.05
query42 0.06 0.04 0.04
query43 0.04 0.03 0.04
Total cold run time: 109.58 s
Total hot run time: 30.78 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org