[jira] [Work logged] (HIVE-25520) Enable concatenate for external table.

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-25520?focusedWorklogId=659131&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-659131 ]

ASF GitHub Bot logged work on HIVE-25520:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Oct/21 20:09
            Start Date: 01/Oct/21 20:09
    Worklog Time Spent: 10m 
      Work Description: harishjp commented on a change in pull request #2640:
URL: https://github.com/apache/hive/pull/2640#discussion_r720512889



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/concatenate/AlterTableConcatenateAnalyzer.java
##########
@@ -73,13 +73,19 @@ protected void analyzeCommand(TableName tableName, Map<String, String> partition
     if (AcidUtils.isTransactionalTable(table)) {
       compactAcidTable(tableName, partitionSpec);
     } else {
+
       // non-native and non-managed tables are not supported as MoveTask requires filenames to be in specific format,
       // violating which can cause data loss
       if (table.isNonNative()) {
         throw new SemanticException(ErrorMsg.CONCATENATE_UNSUPPORTED_TABLE_NON_NATIVE.getMsg());
       }
+
       if (table.getTableType() != TableType.MANAGED_TABLE) {
-        throw new SemanticException(ErrorMsg.CONCATENATE_UNSUPPORTED_TABLE_NOT_MANAGED.getMsg());
+        // Enable concatenate for external tables if config is set.
+        if (!conf.getBoolVar(ConfVars.ENABLE_CONCATENATE_FOR_EXTERNAL_TABLES)

Review comment:
       Adding both a negative and positive test case for this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 659131)
    Time Spent: 0.5h  (was: 20m)

> Enable concatenate for external table.
> --------------------------------------
>
>                 Key: HIVE-25520
>                 URL: https://issues.apache.org/jira/browse/HIVE-25520
>             Project: Hive
>          Issue Type: Improvement
>          Components: HiveServer2
>            Reporter: Harish JP
>            Assignee: Harish JP
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Concatenate for external tables are disabled, enable this under a flag.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)