You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/02/05 17:12:40 UTC
[GitHub] [cordova-android] BBosman opened a new pull request #915: Bump
minSdkVersion to 22 and drop pre-Lollipop specific code
BBosman opened a new pull request #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915
### Platforms affected
Android
### Motivation and Context
As was discussed on the mailing list, the plan is to raise the minimum supported API level to 22, dropping support for Android 4.4 and 5.0 for the next major `cordova-android` release.
### Description
This PR updates the `defaultMinSdkVersion` to 22. There are also a couple of places in the codebase where we have specific logic for older (i.e. KitKat) API-levels which are now no longer needed and can therefore be removed.
### Testing
I ran `npm run test` without issues and tested the changes in one of my own apps.
### Checklist
- [X] I've run the tests to see all new and existing tests pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] timbru31 merged pull request #915: Bump
minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
timbru31 merged pull request #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #915: Bump
minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#issuecomment-582530768
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=h1) Report
> Merging [#915](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/c93f93f63730e7b838aae274fcbe757bfe69f1cd&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #915 +/- ##
==========================================
- Coverage 65.53% 65.48% -0.06%
==========================================
Files 21 21
Lines 1828 1828
==========================================
- Hits 1198 1197 -1
- Misses 630 631 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/915/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `51.69% <0.00%> (-0.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=footer). Last update [c93f93f...b85e28f](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on issue #915: Bump
minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#issuecomment-582530768
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=h1) Report
> Merging [#915](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/8e98de6e7c6869d11a97a68ff0deedf7e5b1aa9a?src=pr&el=desc) will **decrease** coverage by `0.65%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #915 +/- ##
==========================================
- Coverage 65.94% 65.28% -0.66%
==========================================
Files 21 21
Lines 1850 1815 -35
==========================================
- Hits 1220 1185 -35
Misses 630 630
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/AndroidProject.js](https://codecov.io/gh/apache/cordova-android/pull/915/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkUHJvamVjdC5qcw==) | `28.88% <0%> (-10.16%)` | :arrow_down: |
| [bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/915/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==) | `46.75% <0%> (-6.13%)` | :arrow_down: |
| [bin/templates/cordova/lib/retry.js](https://codecov.io/gh/apache/cordova-android/pull/915/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9yZXRyeS5qcw==) | `100% <0%> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/915/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `51.2% <0%> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/915/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `89.83% <0%> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/android\_sdk.js](https://codecov.io/gh/apache/cordova-android/pull/915/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9hbmRyb2lkX3Nkay5qcw==) | `100% <0%> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/AndroidManifest.js](https://codecov.io/gh/apache/cordova-android/pull/915/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkTWFuaWZlc3QuanM=) | `100% <0%> (ø)` | :arrow_up: |
| [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/915/diff?src=pr&el=tree#diff-YmluL2xpYi9jcmVhdGUuanM=) | `93.87% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=footer). Last update [8e98de6...6f9037e](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] timbru31 commented on issue #915: Bump
minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#issuecomment-607118435
@BBosman could you rebase your PR? The CI should run again after that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] BBosman commented on a change in pull request
#915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
BBosman commented on a change in pull request #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#discussion_r392076901
##########
File path: framework/src/org/apache/cordova/engine/SystemWebChromeClient.java
##########
@@ -155,7 +155,7 @@ public boolean onConsoleMessage(ConsoleMessage consoleMessage)
{
if (consoleMessage.message() != null)
LOG.d(LOG_TAG, "%s: Line %d : %s" , consoleMessage.sourceId() , consoleMessage.lineNumber(), consoleMessage.message());
- return super.onConsoleMessage(consoleMessage);
+ return super.onConsoleMessage(consoleMessage);
Review comment:
Extracted the whitespace changes to a separate commit and updated the PR description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] brodybits commented on a change in pull request
#915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
brodybits commented on a change in pull request #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#discussion_r391960088
##########
File path: framework/src/org/apache/cordova/engine/SystemWebChromeClient.java
##########
@@ -199,7 +198,6 @@ public void onHideCustomView() {
* @return View The progress view.
*/
public View getVideoLoadingProgressView() {
-
Review comment:
ditto on cleanup (...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] brodybits commented on a change in pull request
#915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
brodybits commented on a change in pull request #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#discussion_r391959848
##########
File path: framework/src/org/apache/cordova/engine/SystemWebChromeClient.java
##########
@@ -155,7 +155,7 @@ public boolean onConsoleMessage(ConsoleMessage consoleMessage)
{
if (consoleMessage.message() != null)
LOG.d(LOG_TAG, "%s: Line %d : %s" , consoleMessage.sourceId() , consoleMessage.lineNumber(), consoleMessage.message());
- return super.onConsoleMessage(consoleMessage);
+ return super.onConsoleMessage(consoleMessage);
Review comment:
This looks like a form of cleanup that I wish would be more clear in the description and in the commit message(s). Just a message like "other minor cleanup" would be awesome. +1 (+100) for making this kind of cleanup!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on a change in pull request #915:
Bump minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#discussion_r375615955
##########
File path: bin/templates/project/legacy/build.gradle
##########
@@ -223,22 +223,6 @@ android {
}
}
}
- /*
-
- ELSE NOTHING! DON'T MESS WITH THE VERSION CODE IF YOU DON'T HAVE TO!
-
- else if (!cdvVersionCode) {
- def minSdkVersion = cdvMinSdkVersion ?: privateHelpers.extractIntFromManifest("minSdkVersion")
- // Vary versionCode by the two most common API levels:
- // 14 is ICS, which is the lowest API level for many apps.
- // 20 is Lollipop, which is the lowest API level for the updatable system webview.
- if (minSdkVersion >= 20) {
- defaultConfig.versionCode += 9
Review comment:
@dpogue Can you confirm if this is safe to remove?
I feel like this may affect the multiple apk build. That part of the code also reads from the `defaultConfig.versionCode`
I am thinking this should be at least
```
else if (!cdvVersionCode) {
defaultConfig.versionCode += 9
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #915: Bump
minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#issuecomment-582530768
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=h1) Report
> Merging [#915](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/c93f93f63730e7b838aae274fcbe757bfe69f1cd&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #915 +/- ##
==========================================
- Coverage 65.53% 65.48% -0.06%
==========================================
Files 21 21
Lines 1828 1828
==========================================
- Hits 1198 1197 -1
- Misses 630 631 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/915/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `51.69% <0.00%> (-0.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=footer). Last update [c93f93f...b85e28f](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] BBosman commented on issue #915: Bump
minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
BBosman commented on issue #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#issuecomment-607147844
@timbru31 Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #915: Bump
minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#issuecomment-582530768
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=h1) Report
> Merging [#915](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/c93f93f63730e7b838aae274fcbe757bfe69f1cd&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #915 +/- ##
=======================================
Coverage 65.53% 65.53%
=======================================
Files 21 21
Lines 1828 1828
=======================================
Hits 1198 1198
Misses 630 630
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=footer). Last update [c93f93f...b85e28f](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] brodybits commented on a change in pull request
#915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
brodybits commented on a change in pull request #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#discussion_r391960036
##########
File path: framework/src/org/apache/cordova/engine/SystemWebChromeClient.java
##########
@@ -176,7 +176,6 @@ public void onGeolocationPermissionsShowPrompt(String origin, Callback callback)
{
geolocation.requestPermissions(0);
}
-
Review comment:
ditto on cleanup, message like "other minor cleanup" in description and commit messages would be nice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] BBosman commented on a change in pull request
#915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
BBosman commented on a change in pull request #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#discussion_r375655184
##########
File path: bin/templates/project/legacy/build.gradle
##########
@@ -223,22 +223,6 @@ android {
}
}
}
- /*
-
- ELSE NOTHING! DON'T MESS WITH THE VERSION CODE IF YOU DON'T HAVE TO!
-
- else if (!cdvVersionCode) {
- def minSdkVersion = cdvMinSdkVersion ?: privateHelpers.extractIntFromManifest("minSdkVersion")
- // Vary versionCode by the two most common API levels:
- // 14 is ICS, which is the lowest API level for many apps.
- // 20 is Lollipop, which is the lowest API level for the updatable system webview.
- if (minSdkVersion >= 20) {
- defaultConfig.versionCode += 9
Review comment:
It's commented out code, so it's not doing anything at the moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] BBosman commented on a change in pull request
#915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
BBosman commented on a change in pull request #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#discussion_r392077160
##########
File path: framework/src/org/apache/cordova/engine/SystemWebChromeClient.java
##########
@@ -176,7 +176,6 @@ public void onGeolocationPermissionsShowPrompt(String origin, Callback callback)
{
geolocation.requestPermissions(0);
}
-
Review comment:
Extracted the whitespace changes to a separate commit and updated the PR description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] BBosman commented on a change in pull request
#915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
BBosman commented on a change in pull request #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#discussion_r392076966
##########
File path: framework/src/org/apache/cordova/engine/SystemWebChromeClient.java
##########
@@ -199,7 +198,6 @@ public void onHideCustomView() {
* @return View The progress view.
*/
public View getVideoLoadingProgressView() {
-
Review comment:
Extracted the whitespace changes to a separate commit and updated the PR description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #915: Bump
minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#issuecomment-582530768
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=h1) Report
> Merging [#915](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/c93f93f63730e7b838aae274fcbe757bfe69f1cd&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #915 +/- ##
=======================================
Coverage 65.53% 65.53%
=======================================
Files 21 21
Lines 1828 1828
=======================================
Hits 1198 1198
Misses 630 630
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=footer). Last update [c93f93f...b85e28f](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] BBosman commented on issue #915: Bump
minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
BBosman commented on issue #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#issuecomment-598597772
@brodybits Like this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] timbru31 commented on issue #915: Bump
minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#issuecomment-582881731
Great, thanks for the PR 👍. I've took a quick look, so far it seems fine. I'll give the PR a more detailed review later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] BBosman commented on a change in pull request
#915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
BBosman commented on a change in pull request #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#discussion_r392077088
##########
File path: framework/src/org/apache/cordova/engine/SystemWebViewClient.java
##########
@@ -349,7 +348,7 @@ public WebResourceResponse shouldInterceptRequest(WebView view, String url) {
}
}
- private static boolean needsKitKatContentUrlFix(Uri uri) {
+ private static boolean needsContentUrlFix(Uri uri) {
Review comment:
Extracted the function rename to a separate commit and updated the PR description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on a change in pull request #915:
Bump minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#discussion_r375720841
##########
File path: bin/templates/project/legacy/build.gradle
##########
@@ -223,22 +223,6 @@ android {
}
}
}
- /*
-
- ELSE NOTHING! DON'T MESS WITH THE VERSION CODE IF YOU DON'T HAVE TO!
-
- else if (!cdvVersionCode) {
- def minSdkVersion = cdvMinSdkVersion ?: privateHelpers.extractIntFromManifest("minSdkVersion")
- // Vary versionCode by the two most common API levels:
- // 14 is ICS, which is the lowest API level for many apps.
- // 20 is Lollipop, which is the lowest API level for the updatable system webview.
- if (minSdkVersion >= 20) {
- defaultConfig.versionCode += 9
Review comment:
Haha, I wonder how that slipped past me, why I didn't notice it was commented out. 🤣
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #915: Bump
minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#issuecomment-582530768
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=h1) Report
> Merging [#915](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/c93f93f63730e7b838aae274fcbe757bfe69f1cd&el=desc) will **decrease** coverage by `0.10%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #915 +/- ##
==========================================
- Coverage 65.53% 65.42% -0.11%
==========================================
Files 21 21
Lines 1828 1828
==========================================
- Hits 1198 1196 -2
- Misses 630 632 +2
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/915/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `51.20% <0.00%> (-0.97%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=footer). Last update [c93f93f...b85e28f](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #915: Bump
minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#issuecomment-582530768
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=h1) Report
> Merging [#915](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/c93f93f63730e7b838aae274fcbe757bfe69f1cd&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #915 +/- ##
==========================================
- Coverage 65.53% 65.48% -0.06%
==========================================
Files 21 21
Lines 1828 1828
==========================================
- Hits 1198 1197 -1
- Misses 630 631 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/915/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `51.69% <0.00%> (-0.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=footer). Last update [c93f93f...b85e28f](https://codecov.io/gh/apache/cordova-android/pull/915?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] brodybits commented on a change in pull request
#915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
Posted by GitBox <gi...@apache.org>.
brodybits commented on a change in pull request #915: Bump minSdkVersion to 22 and drop pre-Lollipop specific code
URL: https://github.com/apache/cordova-android/pull/915#discussion_r391960423
##########
File path: framework/src/org/apache/cordova/engine/SystemWebViewClient.java
##########
@@ -349,7 +348,7 @@ public WebResourceResponse shouldInterceptRequest(WebView view, String url) {
}
}
- private static boolean needsKitKatContentUrlFix(Uri uri) {
+ private static boolean needsContentUrlFix(Uri uri) {
Review comment:
Renaming of this function is a form of cleanup that I think is not super clear from the description or commit messages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org