You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by "Christof Schmalenbach (JIRA)" <ji...@apache.org> on 2011/01/14 23:34:45 UTC

[jira] Created: (AXIS2C-1529) wsdl2c generates skeleton code with memoryleak inside

wsdl2c generates skeleton code with memoryleak inside
-----------------------------------------------------

                 Key: AXIS2C-1529
                 URL: https://issues.apache.org/jira/browse/AXIS2C-1529
             Project: Axis2-C
          Issue Type: Bug
          Components: wsdl2c tool
    Affects Versions: 1.6.0
         Environment: This bug can be reproduced on linux as well as on Win32.
On Win32 the following environment is used
- axis2c version 1.6.0
- axis2 java version axis2-1.5.2 (axis2-1.5.3 on linux)
- java full version "JRE 1.6.0 IBM Windows 32 build pwi3260sr8fp1-20100903_02 (SR8 FP1)"
            Reporter: Christof Schmalenbach


One can reproduce the problem with the following steps:
1. Compile the following java class (only to generate a appropriate wsdl used in step 2)
package memleak;

public class MemLeak
{
	public byte[] getServiceData(byte[] input)
	{
		byte[] output = new byte[10];
		return(output);
	}
}

2. generate wsdl with the following command from the MemLeak class
java2wsdl -o . -of axis2cwsdl2cmembug.wsdl -sn axis2cmemleak -cn memleak.MemLeak 

3. generate serverside code (skeletons) from the axis2cwsdl2cmembug.wsdl with the following command:
wsdl2c -o .\c_axis2cwsdl2membug_skeleton -ss -uri axis2cwsdl2cmembug.wsdl

Step 3. generates the following artefacts:
./axis2_skel_axis2cmemleak.c
./axis2_skel_axis2cmemleak.h
./axis2_svc_skel_axis2cmemleak.c
./src
./src./adb_getServiceData.c
./src./adb_getServiceData.h
./src./adb_getServiceDataResponse.c
./src./adb_getServiceDataResponse.h

Especially .the generated code /src./adb_getServiceDataResponse.c contains a memory leak in the function
adb_getServiceDataResponse_serialize
within every webservice request cycle.
Following code is generated in this function:

                          text_value_1 =axutil_base64_binary_get_encoded_binary(_getServiceDataResponse->property_return, env);
                           
                           axutil_stream_write(stream, env, start_input_str, start_input_str_len);
                           
                           axutil_stream_write(stream, env, text_value_1, axutil_strlen(text_value_1));
                           
                           axutil_stream_write(stream, env, end_input_str, end_input_str_len);
                           
                     
                     AXIS2_FREE(env->allocator,start_input_str);
                     AXIS2_FREE(env->allocator,end_input_str);

memory for start_input_str and for end_input_str are released , BUT not the memory allocated in axutil_base64_binary_get_encoded_binary for the pointer text_value_1.
An AXIS2_FREE(env->allocator,text_value_1.); is missed.
This AXIS2_FREE can be included in the generated code, solving the memory leak without destabilizing the service.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: c-dev-help@axis.apache.org


[jira] Updated: (AXIS2C-1529) wsdl2c generates skeleton code with memoryleak inside

Posted by "Christof Schmalenbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2C-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christof Schmalenbach updated AXIS2C-1529:
------------------------------------------

    Attachment: adb_getServiceDataResponse.c
                axis2cwsdl2cmembug.wsdl
                MemLeak.java

Step 1 file MemLeak.java (PoJo for java2wsdl )
Step 2 file axis2cwsdl2cmembug.wsdl (generated wsdl)
Step 3 adb_getServiceDataResponse.c with memory bug in line 411.

> wsdl2c generates skeleton code with memoryleak inside
> -----------------------------------------------------
>
>                 Key: AXIS2C-1529
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-1529
>             Project: Axis2-C
>          Issue Type: Bug
>          Components: wsdl2c tool
>    Affects Versions: 1.6.0
>         Environment: This bug can be reproduced on linux as well as on Win32.
> On Win32 the following environment is used
> - axis2c version 1.6.0
> - axis2 java version axis2-1.5.2 (axis2-1.5.3 on linux)
> - java full version "JRE 1.6.0 IBM Windows 32 build pwi3260sr8fp1-20100903_02 (SR8 FP1)"
>            Reporter: Christof Schmalenbach
>         Attachments: adb_getServiceDataResponse.c, axis2cwsdl2cmembug.wsdl, MemLeak.java
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> One can reproduce the problem with the following steps:
> 1. Compile the following java class (only to generate a appropriate wsdl used in step 2)
> package memleak;
> public class MemLeak
> {
> 	public byte[] getServiceData(byte[] input)
> 	{
> 		byte[] output = new byte[10];
> 		return(output);
> 	}
> }
> 2. generate wsdl with the following command from the MemLeak class
> java2wsdl -o . -of axis2cwsdl2cmembug.wsdl -sn axis2cmemleak -cn memleak.MemLeak 
> 3. generate serverside code (skeletons) from the axis2cwsdl2cmembug.wsdl with the following command:
> wsdl2c -o .\c_axis2cwsdl2membug_skeleton -ss -uri axis2cwsdl2cmembug.wsdl
> Step 3. generates the following artefacts:
> ./axis2_skel_axis2cmemleak.c
> ./axis2_skel_axis2cmemleak.h
> ./axis2_svc_skel_axis2cmemleak.c
> ./src
> ./src./adb_getServiceData.c
> ./src./adb_getServiceData.h
> ./src./adb_getServiceDataResponse.c
> ./src./adb_getServiceDataResponse.h
> Especially .the generated code /src./adb_getServiceDataResponse.c contains a memory leak in the function
> adb_getServiceDataResponse_serialize
> within every webservice request cycle.
> Following code is generated in this function:
>                           text_value_1 =axutil_base64_binary_get_encoded_binary(_getServiceDataResponse->property_return, env);
>                            
>                            axutil_stream_write(stream, env, start_input_str, start_input_str_len);
>                            
>                            axutil_stream_write(stream, env, text_value_1, axutil_strlen(text_value_1));
>                            
>                            axutil_stream_write(stream, env, end_input_str, end_input_str_len);
>                            
>                      
>                      AXIS2_FREE(env->allocator,start_input_str);
>                      AXIS2_FREE(env->allocator,end_input_str);
> memory for start_input_str and for end_input_str are released , BUT not the memory allocated in axutil_base64_binary_get_encoded_binary for the pointer text_value_1.
> An AXIS2_FREE(env->allocator,text_value_1.); is missed.
> This AXIS2_FREE can be included in the generated code, solving the memory leak without destabilizing the service.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: c-dev-help@axis.apache.org