You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/03/31 21:56:07 UTC

[GitHub] [pinot] PrachiKhobragade commented on a change in pull request #8443: Fix ChildTraceId in multithreaded environment

PrachiKhobragade commented on a change in pull request #8443:
URL: https://github.com/apache/pinot/pull/8443#discussion_r840046378



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/util/trace/TraceContext.java
##########
@@ -67,7 +68,7 @@ JsonNode toJson() {
 
     final String _traceId;
     final List<LogEntry> _logs = new ArrayList<>();
-    int _numChildren = 0;
+    AtomicInteger _numChildren = new AtomicInteger(0);

Review comment:
       Reproduced in tests and updated them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org