[GitHub] aaronucsd commented on a change in pull request #3787: [TE] frontend - harleyjj/yaml-editor - implements simple graph for pr…

[GitBox <gi...@apache.org>]

aaronucsd commented on a change in pull request #3787: [TE] frontend - harleyjj/yaml-editor - implements simple graph for pr…
URL: https://github.com/apache/incubator-pinot/pull/3787#discussion_r253602817
 
 

 ##########
 File path: thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/component.js
 ##########
 @@ -137,6 +281,116 @@ export default Component.extend({
     }
   }).drop(),
 
+  didRender(){
+    this._super(...arguments);
+
+    later(() => {
+      this._buildSliderButton();
+    });
+  },
+
+  // Helper function that builds the subchart region buttons
+  _buildSliderButton() {
+    const componentId = this.get('componentId');
 
 Review comment:
    feel like this could be in a util. It might also exists already. We can take off line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org