[GitHub] [submarine] KUAN-HSUN-LI commented on a change in pull request #820: SUBMARINE-1109. Java k8s client version from 6 upgrade to 11

[GitBox <gi...@apache.org>]

KUAN-HSUN-LI commented on a change in pull request #820:
URL: https://github.com/apache/submarine/pull/820#discussion_r771826426



##########
File path: submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java
##########
@@ -570,16 +568,8 @@ public void deleteServe(ServeSpec spec)
               seldonDeployment.getVersion(),
               "default",
               seldonDeployment.getPlural(),
-              seldonDeployment.getMetadata().getName(),
-              new V1DeleteOptionsBuilder().withApiVersion(seldonDeployment.getApiVersion()).build(),
-              null, null, null);
-      api.deleteNamespacedCustomObject(istioVirtualService.getGroup(),
-              istioVirtualService.getVersion(),
-              "default",
-              istioVirtualService.getPlural(),
-              istioVirtualService.getMetadata().getName(),
-              new V1DeleteOptionsBuilder().withApiVersion(istioVirtualService.getApiVersion()).build(),
-              null, null, null);

Review comment:
       Don't remove the istioVirtualService

##########
File path: submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java
##########
@@ -539,9 +537,9 @@ public void createServe(ServeSpec spec)
       api.createNamespacedCustomObject(istioVirtualService.getGroup(),
               istioVirtualService.getVersion(),
               "default",
-              istioVirtualService.getPlural(),
-              istioVirtualService,
-              "true");

Review comment:
       This is a mistake of replace istioVirtualService with seldonDeployment




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org