You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/03 07:02:23 UTC

[GitHub] [skywalking] Ax1an commented on a change in pull request #5021: Fix bug caused by setting SW_OAL_ENGINE_DEBUG=Y.

Ax1an commented on a change in pull request #5021:
URL: https://github.com/apache/skywalking/pull/5021#discussion_r449411124



##########
File path: oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/OALRuntime.java
##########
@@ -135,7 +136,10 @@ public void setDispatcherListener(DispatcherDetectorListener listener) throws Mo
 
     @Override
     public void start(ClassLoader currentClassLoader) throws ModuleStartException, OALCompileException {
-        prepareRTTempFolder();
+        if (!IS_RT_TEMP_FOLDER_INIT_COMPLETED) {

Review comment:
       Create a oal-rt folder only when the first oal script is loaded.
   
   Before fix:
   ![image](https://user-images.githubusercontent.com/28091237/86441016-1a97cf00-bd3e-11ea-9c86-9befe23d024b.png)
   
   After fix:
   ![image](https://user-images.githubusercontent.com/28091237/86441038-25eafa80-bd3e-11ea-8dc2-27cfa0b9bd60.png)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org