You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/03/30 16:49:18 UTC
Review Request 58084: Adjust `using` style in a few places.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58084/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
When an identifier is used many times in an implementation file, we
typically add a `using` statement for that identifier.
Diffs
-----
src/common/build.cpp a87d2cf5463b13d59cf548e7e0edfca600e256b1
src/slave/container_loggers/lib_logrotate.cpp ae5d0acdaf64304675ee0f144c8d0c0988ba9112
src/tests/cluster.cpp 7f09a0c8b93e8fa945e7b2c809624b12e61b4198
src/tests/containerizer/composing_containerizer_tests.cpp 934824c61a857bdc4d2d8ef790b64a33d14eab9f
Diff: https://reviews.apache.org/r/58084/diff/1/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 58084: Adjust `using` style in a few places.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58084/#review170831
-----------------------------------------------------------
See my comment at https://reviews.apache.org/r/58043/.
- Benjamin Bannier
On March 30, 2017, 6:49 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58084/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 6:49 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an identifier is used many times in an implementation file, we
> typically add a `using` statement for that identifier.
>
>
> Diffs
> -----
>
> src/common/build.cpp a87d2cf5463b13d59cf548e7e0edfca600e256b1
> src/slave/container_loggers/lib_logrotate.cpp ae5d0acdaf64304675ee0f144c8d0c0988ba9112
> src/tests/cluster.cpp 7f09a0c8b93e8fa945e7b2c809624b12e61b4198
> src/tests/containerizer/composing_containerizer_tests.cpp 934824c61a857bdc4d2d8ef790b64a33d14eab9f
>
>
> Diff: https://reviews.apache.org/r/58084/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 58084: Adjust `using` style in a few places.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58084/#review170910
-----------------------------------------------------------
Ship it!
Let's get these in as they are strictly improvements.
To make such changes cheaper in the future I am strongly in favor of making a sweep across the code base, and adding new style checkers. I believe if we'd relax the rule you applied here of identifier used multiple times to also include cases where it is only used once one would be able to automate this.
- Benjamin Bannier
On March 30, 2017, 6:49 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58084/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 6:49 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an identifier is used many times in an implementation file, we
> typically add a `using` statement for that identifier.
>
>
> Diffs
> -----
>
> src/common/build.cpp a87d2cf5463b13d59cf548e7e0edfca600e256b1
> src/slave/container_loggers/lib_logrotate.cpp ae5d0acdaf64304675ee0f144c8d0c0988ba9112
> src/tests/cluster.cpp 7f09a0c8b93e8fa945e7b2c809624b12e61b4198
> src/tests/containerizer/composing_containerizer_tests.cpp 934824c61a857bdc4d2d8ef790b64a33d14eab9f
>
>
> Diff: https://reviews.apache.org/r/58084/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 58084: Adjust `using` style in a few places.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58084/#review170608
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58037, 58038, 58039, 58040, 58041, 58042, 58043, 58044, 58084]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 30, 2017, 9:49 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58084/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 9:49 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an identifier is used many times in an implementation file, we
> typically add a `using` statement for that identifier.
>
>
> Diffs
> -----
>
> src/common/build.cpp a87d2cf5463b13d59cf548e7e0edfca600e256b1
> src/slave/container_loggers/lib_logrotate.cpp ae5d0acdaf64304675ee0f144c8d0c0988ba9112
> src/tests/cluster.cpp 7f09a0c8b93e8fa945e7b2c809624b12e61b4198
> src/tests/containerizer/composing_containerizer_tests.cpp 934824c61a857bdc4d2d8ef790b64a33d14eab9f
>
>
> Diff: https://reviews.apache.org/r/58084/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>