Re: [PR] fix(dashboard): refresh chart with latest configuration from database [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #36708:
URL: https://github.com/apache/superset/pull/36708#issuecomment-6328578152

   Thanks for the thorough pass. The `{ ...fallback, ...JSON.parse(params) }` spread wiping `extra_form_data` on a Force refresh is a regression, and I agree the fetched params should only touch the chart's own definition and leave the dashboard to re-apply filters. The reducer sync of `latestQueryFormData` into `form_data` is the part I'm least sure we need.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org