[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10356: Fixes filter aggs perf

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #10356:
URL: https://github.com/apache/pinot/pull/10356#discussion_r1122250629


##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionUtils.java:
##########
@@ -223,10 +223,11 @@ public static List<Pair<AggregationFunction[], TransformOperator>> buildFiltered
     // If it is, populate the corresponding filter operator and corresponding transform operator
     assert aggregationFunctions != null;
     for (Pair<AggregationFunction, FilterContext> inputPair : aggregationFunctions) {
-      if (inputPair.getLeft() != null) {
-        FilterContext currentFilterExpression = inputPair.getRight();
+      FilterContext currentFilterExpression = inputPair.getRight();
+      AggregationFunction aggFunc = inputPair.getLeft();

Review Comment:
   (nit) Put `getLeft()` above `getRight()` for readability



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org