[GitHub] [ozone] fapifta commented on a change in pull request #2990: HDDS-6184: EC: put command should create EC key if bucket is EC

[GitBox <gi...@apache.org>]

fapifta commented on a change in pull request #2990:
URL: https://github.com/apache/ozone/pull/2990#discussion_r791187701



##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/keys/PutKeyHandler.java
##########
@@ -83,8 +87,20 @@ protected void execute(OzoneClient client, OzoneAddress address)
       }
     }
 
-    ReplicationConfig replicationConfig =
-        ReplicationConfig.parse(replicationType, replication, getConf());
+    String clientConfiguredDefaultType = getConf().get(OZONE_REPLICATION_TYPE);
+    if (replicationType == null && clientConfiguredDefaultType != null) {

Review comment:
       Isn't this two condition remained here accidentally? Maybe I miss something, but if I am correct, we do the same in this two ifs as inside the method OzoneClientUtils#validateAndGetClientReplicationConfig(), which we call from here.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org