You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "I3eka (via GitHub)" <gi...@apache.org> on 2026/10/26 03:50:52 UTC

[PR] fix(ai): preserve chart preview results and partial errors [superset]

I3eka opened a new pull request, #45726:
URL: https://github.com/apache/superset/pull/45726

### Summary

**ON HOLD — pending SIP-224** (#42806) and the parent Native AI proposal #42805. Draft follow-up to opt-in authoring #43133.

MCP chart generation can succeed while a requested preview fails. The Native AI adapter currently returns only a small set of identifiers and warnings, discarding `previews`, `preview_errors`, form data, semantics, and capabilities. The agent cannot inspect the partial failure and may describe a preview that was not produced.

Preserve the structured MCP response while retaining the existing chart ID and inline-embed fields. Existing tool output bounds remain in force; chart-generation failures still raise the existing sanitized tool error.

### Validation

- 14 authoring adapter tests pass, including a successful chart with one rendered preview and one failed preview.
- Pre-commit passes for all branch-changed files.
- Includes current master and prerequisite authoring compatibility merges; no deployment performed.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(ai): preserve chart preview results and partial errors [superset]

Posted by "I3eka (via GitHub)" <gi...@apache.org>.

I3eka commented on PR #45726:
URL: https://github.com/apache/superset/pull/45726#issuecomment-6435329438

Reviewed the current discussion and the focused implementation, and merged Apache master `037abb7d0b433c1274ab55f95e5613310f132462` without rewriting the branch. Published head: `e3f108602124472c62ec74d5602c0859f21c7982`. There are no inline review threads or outstanding substantive reviewer findings on this PR in this audit.

- 715 tests passed: the full AI unit suite and the single-migration-head check.
- 105 AI frontend tests passed on the identical full frontend Git tree `91c05bee9972b32d81248e1a3575e8f4e31edd75` in #44497; reused that result. Frontend type/lint hooks were rerun on this branch.
- All applicable pre-commit hooks passed for the 122 files in this PR delta.

Includes prerequisite authoring #43133. Adapter tests use controlled MCP responses; no live renderer, warehouse or deployment validation.

Updated the description to match this head and its validation. This stays **Draft / ON HOLD** behind #42805 and SIP #42806. No deployment, live database migration or external provider call was performed; GitHub CI is separate from these local checks.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(ai): preserve chart preview results and partial errors [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.

netlify[bot] commented on PR #45726:
URL: https://github.com/apache/superset/pull/45726#issuecomment-6407832506

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 79eea53e65410a6687de4764eb944f268db42cf9 |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6adece1eb2c42d4ddef086fb |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-45726--superset-docs-preview.netlify.app](https://deploy-preview-45726--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQ1NzI2LS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.gDfWIyi6mpCLXmo1e26Axde47MWW1hRjkG8jHQ269pU)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#q1YqKMrPLShRslJS0lFKKkrMS84AstMyK_QTM3ULilLLMlPLdYtSi0tzSoAKUlILcvIrPVOASswSU1KTUw1Tk4ySTYxSTFJSUtMMLMzSkpRqAQ) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-45726--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(ai): preserve chart preview results and partial errors [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #45726:
URL: https://github.com/apache/superset/pull/45726#issuecomment-6455907693

### ⚠️ Possible DB migration conflict

@I3eka the base branch `master` picked up a new database migration under `superset/migrations/` after this PR was opened, and this PR adds or modifies migration files too. Alembic migrations form a single linear chain, so if both branch off the same parent revision, merging this PR as-is could leave the migration history with two heads instead of one, which makes `superset db upgrade` fail with `Multiple head revisions are present`.

To check and, if needed, fix this:

1. Rebase this branch onto the latest `master`.
2. Run `superset db heads`. If it lists more than one revision, you have a conflict.
3. In your new migration's script, update `down_revision` (and the `Revises` comment) to point at the other head instead, so the chain has a single head again.

See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(ai): preserve chart preview results and partial errors [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.

codecov[bot] commented on PR #45726:
URL: https://github.com/apache/superset/pull/45726#issuecomment-6407893866

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/45726?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 55.76%. Comparing base ([`fc01645`](https://app.codecov.io/gh/apache/superset/commit/fc016454fb0874b3a242253d9f6d9c04355c7a43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`79eea53`](https://app.codecov.io/gh/apache/superset/commit/79eea53e65410a6687de4764eb944f268db42cf9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 931 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #45726       +/-   ##
   ===========================================
   - Coverage   80.65%   55.76%   -24.89%     
   ===========================================
     Files        2942     3107      +165     
     Lines      175691   206872    +31181     
     Branches    40788    47811     +7023     
   ===========================================
   - Hits       141704   115365    -26339     
   - Misses      31325    90420    +59095     
   + Partials     2662     1087     -1575     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/45726/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [mysql](https://app.codecov.io/gh/apache/superset/pull/45726/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [postgres](https://app.codecov.io/gh/apache/superset/pull/45726/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [sqlite](https://app.codecov.io/gh/apache/superset/pull/45726/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [superset-extensions-cli](https://app.codecov.io/gh/apache/superset/pull/45726/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.24% <ø> (?)` | |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/45726/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/45726?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(ai): preserve chart preview results and partial errors [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #45726:
URL: https://github.com/apache/superset/pull/45726#issuecomment-6461099345

### ⚠️ Possible DB migration conflict

To check and, if needed, fix this:

See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org