You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/08/26 09:28:07 UTC
[GitHub] [dubbo] codecov-commenter commented on pull request #10508: Optimization for reusing existing logic
codecov-commenter commented on PR #10508:
URL: https://github.com/apache/dubbo/pull/10508#issuecomment-1228273583
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/10508?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10508](https://codecov.io/gh/apache/dubbo/pull/10508?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (13628a6) into [3.1](https://codecov.io/gh/apache/dubbo/commit/4da708f3dfdedcc90a4fab94ac5dfafc7b013918?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4da708f) will **decrease** coverage by `0.41%`.
> The diff coverage is `61.53%`.
```diff
@@ Coverage Diff @@
## 3.1 #10508 +/- ##
============================================
- Coverage 65.76% 65.35% -0.42%
+ Complexity 319 295 -24
============================================
Files 1240 1275 +35
Lines 54042 54955 +913
Branches 8170 8256 +86
============================================
+ Hits 35540 35914 +374
- Misses 14642 15112 +470
- Partials 3860 3929 +69
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/10508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nsion/support/MultiInstanceActivateComparator.java](https://codecov.io/gh/apache/dubbo/pull/10508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvTXVsdGlJbnN0YW5jZUFjdGl2YXRlQ29tcGFyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...dubbo/registry/client/ServiceDiscoveryFactory.java](https://codecov.io/gh/apache/dubbo/pull/10508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvU2VydmljZURpc2NvdmVyeUZhY3RvcnkuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...e/dubbo/registry/integration/RegistryProtocol.java](https://codecov.io/gh/apache/dubbo/pull/10508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeVByb3RvY29sLmphdmE=) | `59.94% <ø> (-0.55%)` | :arrow_down: |
| [...registry/zookeeper/util/CuratorFrameworkUtils.java](https://codecov.io/gh/apache/dubbo/pull/10508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS96b29rZWVwZXIvdXRpbC9DdXJhdG9yRnJhbWV3b3JrVXRpbHMuamF2YQ==) | `70.00% <0.00%> (-4.45%)` | :arrow_down: |
| [...he/dubbo/rpc/listener/ListenerExporterWrapper.java](https://codecov.io/gh/apache/dubbo/pull/10508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9saXN0ZW5lci9MaXN0ZW5lckV4cG9ydGVyV3JhcHBlci5qYXZh) | `68.00% <57.14%> (+9.17%)` | :arrow_up: |
| [...o/common/extension/support/ActivateComparator.java](https://codecov.io/gh/apache/dubbo/pull/10508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL3N1cHBvcnQvQWN0aXZhdGVDb21wYXJhdG9yLmphdmE=) | `70.00% <57.89%> (-6.93%)` | :arrow_down: |
| [...che/dubbo/rpc/listener/ListenerInvokerWrapper.java](https://codecov.io/gh/apache/dubbo/pull/10508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9saXN0ZW5lci9MaXN0ZW5lckludm9rZXJXcmFwcGVyLmphdmE=) | `70.96% <60.00%> (+14.71%)` | :arrow_up: |
| [...apache/dubbo/registry/ListenerRegistryWrapper.java](https://codecov.io/gh/apache/dubbo/pull/10508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9MaXN0ZW5lclJlZ2lzdHJ5V3JhcHBlci5qYXZh) | `76.19% <68.42%> (+18.44%)` | :arrow_up: |
| [...ubbo/registry/client/AbstractServiceDiscovery.java](https://codecov.io/gh/apache/dubbo/pull/10508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvQWJzdHJhY3RTZXJ2aWNlRGlzY292ZXJ5LmphdmE=) | `81.53% <71.42%> (-8.39%)` | :arrow_down: |
| [...rg/apache/dubbo/metadata/AbstractCacheManager.java](https://codecov.io/gh/apache/dubbo/pull/10508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9BYnN0cmFjdENhY2hlTWFuYWdlci5qYXZh) | `80.32% <100.00%> (ø)` | |
| ... and [155 more](https://codecov.io/gh/apache/dubbo/pull/10508/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org