You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "kulagaIA (via GitHub)" <gi...@apache.org> on 2023/12/27 20:55:42 UTC
[PR] CAMEL-20113: camel/tests consolidating [camel]
kulagaIA opened a new pull request, #12612:
URL: https://github.com/apache/camel/pull/12612
# Description
org.apache.camel.itest.jms:
-AdviceWithTransactionIssueTest - moved to camel-jms; -DynamicRouteTest - moved to camel-jms;
-FileToJmsTest - moved to camel-jms;
-JmsConsumerShutdownTest - moved to camel-jms;
-JmsIntegrationTest - jms sending to queue and processing with custom bean is checked in others tests, so it is deleted;
-JmsMediumQueuePerformanceTest - tests to play with the performance tuning are org.apache.camel.component.jms.tuning.PerformanceRouteTest and PerformanceRoutePojoTest, so this test is deleted;
-JmsPerformanceTest - tests to play with the performance tuning are org.apache.camel.component.jms.tuning.PerformanceRouteTest and PerformanceRoutePojoTest, so this test is deleted;
-JmsPollingConsumerTest - moved to camel-jms;
-JmsPollEnrichTest - moved to camel-jms;
-JMSNestedTransactionRollbackTest - moved to camel-jms; -JmsResequencerTest - resequence is checked in other camel-jms tests, so this test is deleted; -JmsValidatorTest - moved to camel-jms;
-SpringJmsValidatorTest - moved to camel-jms;
# Tracking
https://issues.apache.org/jira/browse/CAMEL-20113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20113: camel/tests consolidating [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #12612:
URL: https://github.com/apache/camel/pull/12612#issuecomment-1875647125
> Do I understand correctly that it is failing due to assertion error?
I think so. It seems to be flaky, but unfortunately GH doesn't keep logs from multiple runs so I cannot double check (and add it here to make it easier for you to debug).
> Also, should I work on it into a separate pr? It seems nothing to do with the tests moved in this pr.
Oh, my bad. I am sorry. I thought this test was one of the tests modified as part of the PR ... but after a second review, that's not the case.
In this case, it's something to be fixed later (feel free to contribute it if you want, otherwise we will fix it eventually).
Based on that, I think this one is ready to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20113: camel/tests consolidating [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12612:
URL: https://github.com/apache/camel/pull/12612#issuecomment-1870936913
:robot: The Apache Camel test robot will run the tests for you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20113: camel/tests consolidating [camel]
Posted by "kulagaIA (via GitHub)" <gi...@apache.org>.
kulagaIA commented on PR #12612:
URL: https://github.com/apache/camel/pull/12612#issuecomment-1871010582
/component-test camel-jms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20113: camel/tests consolidating [camel]
Posted by "kulagaIA (via GitHub)" <gi...@apache.org>.
kulagaIA commented on PR #12612:
URL: https://github.com/apache/camel/pull/12612#issuecomment-1870621794
/component-test camel-jms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20113: camel/tests consolidating [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #12612:
URL: https://github.com/apache/camel/pull/12612#issuecomment-1870936556
/component-test camel-jms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20113: camel/tests consolidating [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #12612:
URL: https://github.com/apache/camel/pull/12612#issuecomment-1875023426
> > I wonder if this test fails for you also
> > org.apache.camel.component.jms.JmsDeliveryDelayTest.testInOnlyWithDelay 10.21s FAILURE
>
> Yes, it have failed in the build job, but it passes in /component-test camel-jms and local runs EDIT: it seems that sometimes it fails in /component-test camel-jms also. Should I look into why it fails?
Hi, yes. Ideally we want to reduce the flakiness of our tests, so we can trust the results from our CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20113: camel/tests consolidating [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12612:
URL: https://github.com/apache/camel/pull/12612#issuecomment-1870621280
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20113: camel/tests consolidating [camel]
Posted by "kulagaIA (via GitHub)" <gi...@apache.org>.
kulagaIA commented on PR #12612:
URL: https://github.com/apache/camel/pull/12612#issuecomment-1875042187
> > > I wonder if this test fails for you also
> > > org.apache.camel.component.jms.JmsDeliveryDelayTest.testInOnlyWithDelay 10.21s FAILURE
> >
> >
> > Yes, it have failed in the build job, but it passes in /component-test camel-jms and local runs EDIT: it seems that sometimes it fails in /component-test camel-jms also. Should I look into why it fails?
>
> Hi, yes. Ideally we want to reduce the flakiness of our tests, so we can trust the results from our CI.
Hello, thanks for the reply! Ok, I'll look into it.
Do I understand correctly that it is failing due to assertion error?
Also, should I work on it into a separate pr? It seems nothing to do with the tests moved in this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20113: camel/tests consolidating [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #12612:
URL: https://github.com/apache/camel/pull/12612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20113: camel/tests consolidating [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12612:
URL: https://github.com/apache/camel/pull/12612#issuecomment-1870622050
:robot: The Apache Camel test robot will run the tests for you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20113: camel/tests consolidating [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #12612:
URL: https://github.com/apache/camel/pull/12612#issuecomment-1870956054
I wonder if this test fails for you also
org.apache.camel.component.jms.JmsDeliveryDelayTest.testInOnlyWithDelay | 10.21s | FAILURE
-- | -- | --
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20113: camel/tests consolidating [camel]
Posted by "kulagaIA (via GitHub)" <gi...@apache.org>.
kulagaIA commented on PR #12612:
URL: https://github.com/apache/camel/pull/12612#issuecomment-1871010462
> I wonder if this test fails for you also
>
> org.apache.camel.component.jms.JmsDeliveryDelayTest.testInOnlyWithDelay 10.21s FAILURE
Yes, it have failed in the build job, but it passes in /component-test camel-jms and local runs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20113: camel/tests consolidating [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12612:
URL: https://github.com/apache/camel/pull/12612#issuecomment-1871010896
:robot: The Apache Camel test robot will run the tests for you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org