You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/21 14:48:47 UTC

[GitHub] [pulsar] codelipenghui commented on pull request #11003: Fix potential data lost on the system topic when topic compaction have not triggered yet

codelipenghui commented on pull request #11003:
URL: https://github.com/apache/pulsar/pull/11003#issuecomment-865093565


   @315157973 TTL and inactive topic deletion are not worked on SystemTopic, you see here https://github.com/apache/pulsar/blob/d1a439b3c18f72736c6331d58d151bc23c0628ca/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/SystemTopic.java#L49-L55
   
   It doesn't matter if `brokerServiceCompactionThresholdInBytes` is reached or not, we just ensure the __compaction subscription has created when creating the __change_events topic, if the next compaction task triggered but not reaches the `brokerServiceCompactionThresholdInBytes`, will skip the compaction and waiting for the next compaction task to compact the data. So it's ok for this case, if the data not get compacted, we will read from the original topic directly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org