[GitHub] [pulsar] HQebupt commented on a diff in pull request #16951: [improve][broker]reduce unnecessary connection closes when bundle is being unloaded

[GitBox <gi...@apache.org>]

HQebupt commented on code in PR #16951:
URL: https://github.com/apache/pulsar/pull/16951#discussion_r939635572


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -411,8 +412,8 @@ private CompletableFuture<Optional<LookupResult>> findBrokerServiceUrl(
                         });
                     }
                 } else if (nsData.get().isDisabled()) {
-                    future.completeExceptionally(
-                            new IllegalStateException(String.format("Namespace bundle %s is being unloaded", bundle)));
+                    future.completeExceptionally(new BrokerServiceException.ServerMetadataException(

Review Comment:
   I think so. A bundle is supposed to belong to a broker.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org