You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/02/22 02:11:07 UTC
[GitHub] [skywalking] lujiajing1126 opened a new issue #8567: [Feature] [CLI] Make skywalking-infra-e2e work with docker-compose V2
lujiajing1126 opened a new issue #8567:
URL: https://github.com/apache/skywalking/issues/8567
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
In the current `skywalking-e2e-infra` implementation, the logic of building container name is hard-coded with `_` as the separator. While using with `docker-compose` v2, it is incompatible,
<img width="1435" alt="image" src="https://user-images.githubusercontent.com/2568208/155049517-17cbd981-4054-48d6-a255-ddf32b1506e7.png">
https://github.com/docker/compose/blob/5becea4ca9f68875334c92f191a13482bcd6e5cf/compose/service.py#L1492-L1498
In the latest version (written in `go`), [`-` is used](https://github.com/docker/compose/blob/981aea674d052ee1ab252f71c3ca1f9f8a7e32de/pkg/compose/convergence.go#L252-L257). So the container created cannot be found, and thus the program exits unexpectedly.
<img width="994" alt="image" src="https://user-images.githubusercontent.com/2568208/155049970-584c28f0-32d8-4f88-a767-6f5d36dee719.png">
A possible approach to solve this is to check `docker-compose` version in the `infra-e2e` and use different strategies for v1 and v2.
Another possible solution is to compare the container name by ignoring the difference between `_` and `-` .
### Use case
Currently, docker-compose v1 is not under active maintenance.
We may support v2.
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8567: [Feature] [CLI] Make skywalking-infra-e2e work with docker-compose V2
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8567:
URL: https://github.com/apache/skywalking/issues/8567#issuecomment-1047361631
@kezhenxu94 Please take a look and confirm the way it will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8567: [Feature] [CLI] Make skywalking-infra-e2e work with docker-compose V2
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8567:
URL: https://github.com/apache/skywalking/issues/8567#issuecomment-1047556363
@lujiajing1126 Notice, you are using a wrong prefix of issue name, this should be `[E2E-INFRA]`, not `CLI`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lujiajing1126 commented on issue #8567: [Feature] [E2E-INFRA] Make skywalking-infra-e2e work with docker-compose V2
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on issue #8567:
URL: https://github.com/apache/skywalking/issues/8567#issuecomment-1047560767
> @lujiajing1126 Notice, you are using a wrong prefix of issue name, this should be `[E2E-INFRA]`, not `CLI`.
Thanks for pointing out. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #8567: [Feature] [CLI] Make skywalking-infra-e2e work with docker-compose V2
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #8567:
URL: https://github.com/apache/skywalking/issues/8567#issuecomment-1047364077
> compare the container name by ignoring the difference between _ and - .
this sounds good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #8567: [Feature] [E2E-INFRA] Make skywalking-infra-e2e work with docker-compose V2
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #8567:
URL: https://github.com/apache/skywalking/issues/8567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org