You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "TangSiyang2001 (via GitHub)" <gi...@apache.org> on 2023/12/12 10:07:06 UTC

[PR] [enhancement](err-msg) expose real error msg for invalid delete conf [doris]

TangSiyang2001 opened a new pull request, #28287:
URL: https://github.com/apache/doris/pull/28287

   ## Proposed changes
   
   As title.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](err-msg) expose real error msg for invalid delete condition [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28287:
URL: https://github.com/apache/doris/pull/28287#issuecomment-1851978183

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](err-msg) expose real error msg for invalid delete conf [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28287:
URL: https://github.com/apache/doris/pull/28287#issuecomment-1851737681

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](err-msg) expose real error msg for invalid delete condition [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #28287:
URL: https://github.com/apache/doris/pull/28287


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](err-msg) expose real error msg for invalid delete condition [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28287:
URL: https://github.com/apache/doris/pull/28287#issuecomment-1851894667

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit 82e12836b8251dfa14d86f42a2258b95880dc720, data reload: true
   
   run tpch-sf100 query with default conf and session variables
   q1	4640	4422	4429	4422
   q2	368	118	116	116
   q3	1454	1215	1217	1215
   q4	1131	921	896	896
   q5	3137	3188	3206	3188
   q6	235	122	122	122
   q7	983	495	499	495
   q8	2172	2210	2190	2190
   q9	6738	6711	6685	6685
   q10	3213	3295	3288	3288
   q11	332	197	194	194
   q12	354	203	209	203
   q13	4558	3780	3812	3780
   q14	239	202	216	202
   q15	566	521	508	508
   q16	437	384	384	384
   q17	1011	666	619	619
   q18	7563	6984	6984	6984
   q19	1602	1504	1365	1365
   q20	565	350	316	316
   q21	3119	2648	2720	2648
   q22	340	282	274	274
   Total cold run time: 44757 ms
   Total hot run time: 40094 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4423	4424	4390	4390
   q2	266	163	169	163
   q3	3540	3536	3525	3525
   q4	2407	2372	2376	2372
   q5	5748	5745	5747	5745
   q6	236	118	118	118
   q7	2389	1859	1850	1850
   q8	3552	3536	3553	3536
   q9	9025	9029	9021	9021
   q10	3922	4000	4024	4000
   q11	501	390	390	390
   q12	770	621	642	621
   q13	13349	3546	3537	3537
   q14	287	256	273	256
   q15	564	521	520	520
   q16	507	463	441	441
   q17	1890	1856	1873	1856
   q18	8689	8195	8523	8195
   q19	1763	1757	1739	1739
   q20	2279	1948	1941	1941
   q21	6672	6207	6174	6174
   q22	518	431	422	422
   Total cold run time: 73297 ms
   Total hot run time: 60812 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](err-msg) expose real error msg for invalid delete conf [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28287:
URL: https://github.com/apache/doris/pull/28287#issuecomment-1851810133

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 45.05 seconds
    stream load tsv:          580 seconds loaded 74807831229 Bytes, about 123 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          29.0 seconds inserted 10000000 Rows, about 344K ops/s
    storage size: 17219815880 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](err-msg) expose real error msg for invalid delete condition [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28287:
URL: https://github.com/apache/doris/pull/28287#issuecomment-1851978245

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](err-msg) expose real error msg for invalid delete conf [doris]

Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #28287:
URL: https://github.com/apache/doris/pull/28287#issuecomment-1851724622

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org