You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Doug Leeper (JIRA)" <ji...@apache.org> on 2007/09/14 17:41:32 UTC
[jira] Created: (WICKET-975) Update ImageButton to handle
ResourceReferenc
Update ImageButton to handle ResourceReferenc
---------------------------------------------
Key: WICKET-975
URL: https://issues.apache.org/jira/browse/WICKET-975
Project: Wicket
Issue Type: New Feature
Components: site
Affects Versions: 1.3.0-beta3, 1.3.0-beta2, 1.3.0-beta1
Reporter: Doug Leeper
Fix For: 1.3.0-beta4
To be consistent with Image and its support for ResourceReferences, ImageButton was modified to exhibit the same behaviors.
New constructors and methods have been added.
Existing methods have been modified to behave similiar as Image but maintaining the Button constructs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Assigned: (WICKET-975) Update ImageButton to handle ResourceReferenc
Posted by Gerolf Seitz <ge...@gmail.com>.
unfortunately i won't have time either. i got a rather difficult exam lined
up for the coming wednesday.
maybe someone else can deal with this for rc1?
Gerolf
On Nov 3, 2007 7:49 AM, Igor Vaynberg (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/WICKET-975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Igor Vaynberg reassigned WICKET-975:
> ------------------------------------
>
> Assignee: Gerolf Seitz (was: Igor Vaynberg)
>
> i will be busy this weekend, see if we can squeeze it into rc1
>
> > Update ImageButton to handle ResourceReferenc
> > ---------------------------------------------
> >
> > Key: WICKET-975
> > URL: https://issues.apache.org/jira/browse/WICKET-975
> > Project: Wicket
> > Issue Type: New Feature
> > Components: site
> > Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> > Reporter: Doug Leeper
> > Assignee: Gerolf Seitz
> > Fix For: 1.3.0-beta5
> >
> > Attachments: diff.out, ImageButton.java
> >
> >
> > To be consistent with Image and its support for ResourceReferences,
> ImageButton was modified to exhibit the same behaviors.
> > New constructors and methods have been added.
> > Existing methods have been modified to behave similiar as Image but
> maintaining the Button constructs.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Assigned: (WICKET-975) Update ImageButton to handle
ResourceReferenc
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-975:
------------------------------------
Assignee: Gerolf Seitz (was: Igor Vaynberg)
i will be busy this weekend, see if we can squeeze it into rc1
> Update ImageButton to handle ResourceReferenc
> ---------------------------------------------
>
> Key: WICKET-975
> URL: https://issues.apache.org/jira/browse/WICKET-975
> Project: Wicket
> Issue Type: New Feature
> Components: site
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Reporter: Doug Leeper
> Assignee: Gerolf Seitz
> Fix For: 1.3.0-beta5
>
> Attachments: diff.out, ImageButton.java
>
>
> To be consistent with Image and its support for ResourceReferences, ImageButton was modified to exhibit the same behaviors.
> New constructors and methods have been added.
> Existing methods have been modified to behave similiar as Image but maintaining the Button constructs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-975) Update ImageButton to handle
ResourceReferenc
Posted by "Doug Leeper (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539806 ]
Doug Leeper commented on WICKET-975:
------------------------------------
As this is my first RFE w/ path...how does one create a diff/patch without manually going through each line code? Is there a tool that provides this?
Assignee: Igor Vaynberg
please create a diff/patch
> Update ImageButton to handle ResourceReferenc
> ---------------------------------------------
>
> Key: WICKET-975
> URL: https://issues.apache.org/jira/browse/WICKET-975
> Project: Wicket
> Issue Type: New Feature
> Components: site
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Reporter: Doug Leeper
> Assignee: Igor Vaynberg
> Fix For: 1.3.0-beta5
>
> Attachments: diff.out, ImageButton.java
>
>
> To be consistent with Image and its support for ResourceReferences, ImageButton was modified to exhibit the same behaviors.
> New constructors and methods have been added.
> Existing methods have been modified to behave similiar as Image but maintaining the Button constructs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-975) Update ImageButton to handle
ResourceReferenc
Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerolf Seitz resolved WICKET-975.
---------------------------------
Resolution: Fixed
> Update ImageButton to handle ResourceReferenc
> ---------------------------------------------
>
> Key: WICKET-975
> URL: https://issues.apache.org/jira/browse/WICKET-975
> Project: Wicket
> Issue Type: New Feature
> Components: site
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Reporter: Doug Leeper
> Assignee: Gerolf Seitz
> Fix For: 1.3.0-rc1
>
> Attachments: diff.out, ImageButton.java
>
>
> To be consistent with Image and its support for ResourceReferences, ImageButton was modified to exhibit the same behaviors.
> New constructors and methods have been added.
> Existing methods have been modified to behave similiar as Image but maintaining the Button constructs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-975) Update ImageButton to handle
ResourceReferenc
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-975:
---------------------------------
Assignee: Igor Vaynberg
please create a diff/patch
> Update ImageButton to handle ResourceReferenc
> ---------------------------------------------
>
> Key: WICKET-975
> URL: https://issues.apache.org/jira/browse/WICKET-975
> Project: Wicket
> Issue Type: New Feature
> Components: site
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Reporter: Doug Leeper
> Assignee: Igor Vaynberg
> Fix For: 1.3.0-beta4
>
> Attachments: ImageButton.java
>
>
> To be consistent with Image and its support for ResourceReferences, ImageButton was modified to exhibit the same behaviors.
> New constructors and methods have been added.
> Existing methods have been modified to behave similiar as Image but maintaining the Button constructs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-975) Update ImageButton to handle
ResourceReferenc
Posted by "Doug Leeper (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Leeper updated WICKET-975:
-------------------------------
Attachment: diff.out
I hope this is what you need. All I did was use diff between the OLD and NEW versions. If this is not what you need, please let me know how to create a diff in the format you need.
> Update ImageButton to handle ResourceReferenc
> ---------------------------------------------
>
> Key: WICKET-975
> URL: https://issues.apache.org/jira/browse/WICKET-975
> Project: Wicket
> Issue Type: New Feature
> Components: site
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Reporter: Doug Leeper
> Assignee: Igor Vaynberg
> Fix For: 1.3.0-beta4
>
> Attachments: diff.out, ImageButton.java
>
>
> To be consistent with Image and its support for ResourceReferences, ImageButton was modified to exhibit the same behaviors.
> New constructors and methods have been added.
> Existing methods have been modified to behave similiar as Image but maintaining the Button constructs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-975) Update ImageButton to handle
ResourceReferenc
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-975:
--------------------------------------
Fix Version/s: (was: 1.3.0-beta4)
1.3.0-beta5
> Update ImageButton to handle ResourceReferenc
> ---------------------------------------------
>
> Key: WICKET-975
> URL: https://issues.apache.org/jira/browse/WICKET-975
> Project: Wicket
> Issue Type: New Feature
> Components: site
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Reporter: Doug Leeper
> Assignee: Igor Vaynberg
> Fix For: 1.3.0-beta5
>
> Attachments: diff.out, ImageButton.java
>
>
> To be consistent with Image and its support for ResourceReferences, ImageButton was modified to exhibit the same behaviors.
> New constructors and methods have been added.
> Existing methods have been modified to behave similiar as Image but maintaining the Button constructs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-975) Update ImageButton to handle
ResourceReferenc
Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerolf Seitz reassigned WICKET-975:
-----------------------------------
Assignee: Gerolf Seitz (was: Johan Compagner)
i actually had some time left to incorporate the patch (who wants to study the entire day anyways)
> Update ImageButton to handle ResourceReferenc
> ---------------------------------------------
>
> Key: WICKET-975
> URL: https://issues.apache.org/jira/browse/WICKET-975
> Project: Wicket
> Issue Type: New Feature
> Components: site
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Reporter: Doug Leeper
> Assignee: Gerolf Seitz
> Fix For: 1.3.0-rc1
>
> Attachments: diff.out, ImageButton.java
>
>
> To be consistent with Image and its support for ResourceReferences, ImageButton was modified to exhibit the same behaviors.
> New constructors and methods have been added.
> Existing methods have been modified to behave similiar as Image but maintaining the Button constructs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-975) Update ImageButton to handle
ResourceReferenc
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner reassigned WICKET-975:
--------------------------------------
Assignee: Johan Compagner (was: Gerolf Seitz)
i can do this, but the problem is that the patch is not a valid patch that eclipse accepts
and the Imagebutton is already from sep. And i dont want to override anything
So can this patch be updated just make the patch with eclipse and it should work fine.
> Update ImageButton to handle ResourceReferenc
> ---------------------------------------------
>
> Key: WICKET-975
> URL: https://issues.apache.org/jira/browse/WICKET-975
> Project: Wicket
> Issue Type: New Feature
> Components: site
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Reporter: Doug Leeper
> Assignee: Johan Compagner
> Fix For: 1.3.0-beta5
>
> Attachments: diff.out, ImageButton.java
>
>
> To be consistent with Image and its support for ResourceReferences, ImageButton was modified to exhibit the same behaviors.
> New constructors and methods have been added.
> Existing methods have been modified to behave similiar as Image but maintaining the Button constructs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-975) Update ImageButton to handle
ResourceReferenc
Posted by "Doug Leeper (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Leeper updated WICKET-975:
-------------------------------
Attachment: ImageButton.java
Updated and working patch for ImageButton
> Update ImageButton to handle ResourceReferenc
> ---------------------------------------------
>
> Key: WICKET-975
> URL: https://issues.apache.org/jira/browse/WICKET-975
> Project: Wicket
> Issue Type: New Feature
> Components: site
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Reporter: Doug Leeper
> Fix For: 1.3.0-beta4
>
> Attachments: ImageButton.java
>
>
> To be consistent with Image and its support for ResourceReferences, ImageButton was modified to exhibit the same behaviors.
> New constructors and methods have been added.
> Existing methods have been modified to behave similiar as Image but maintaining the Button constructs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.