You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ponymail.apache.org by GitBox <gi...@apache.org> on 2021/05/06 11:59:57 UTC

[GitHub] [incubator-ponymail-foal] sbp opened a new pull request #19: Add focus_domain preference to restrict lists to the current domain

sbp opened a new pull request #19:
URL: https://github.com/apache/incubator-ponymail-foal/pull/19


   When hosting Foal across multiple domains or subdomains it may be desirable to show only the mailing lists for the current domain or subdomain in the user interface. This PR adds a boolean configuration option called `ui.focus_domain`, set to `False` by default, which when set to `True` implements this functionality.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ponymail-foal] Humbedooh commented on pull request #19: Add focus_domain preference to restrict lists to the current domain

Posted by GitBox <gi...@apache.org>.
Humbedooh commented on pull request #19:
URL: https://github.com/apache/incubator-ponymail-foal/pull/19#issuecomment-833586798


   I think this is a good improvement, and I'll merge unless I hear otherwise.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ponymail-foal] sbp commented on pull request #19: Add focus_domain preference to restrict lists to the current domain

Posted by GitBox <gi...@apache.org>.
sbp commented on pull request #19:
URL: https://github.com/apache/incubator-ponymail-foal/pull/19#issuecomment-833544205


   This is now implemented in e724d9b, with the slight difference that instead of `Union[bool, str]` it uses just `str` and the empty string `""` is the old `True` and an asterisk `"*"` is the old `False`. In other words:
   
   * `ui.focus_domain: ""` <- focus on host: attribute only
   * `ui.focus_domain: "*"` <- no focus, show all lists (default)
   * `ui.focus_domain: example.org` <- focus on *@example.org only
   * `ui.focus_domain: "*.example.org"` <- focus on all \*@\*.example.org lists only
   
   The default is `"*"`, so if no `ui.focus_domain` parameter is specified the behaviour will be as normal. Wildcards in subdomains have to be followed by a full stop, so for example `*.example.org` works but `*partial.example.org` does not (it doesn't focus on any subdomain at all). Also, YAML appears to require quote marks around any string value starting with an asterisk.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ponymail-foal] Humbedooh merged pull request #19: Add focus_domain preference to restrict lists to the current domain

Posted by GitBox <gi...@apache.org>.
Humbedooh merged pull request #19:
URL: https://github.com/apache/incubator-ponymail-foal/pull/19


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ponymail-foal] Humbedooh commented on pull request #19: Add focus_domain preference to restrict lists to the current domain

Posted by GitBox <gi...@apache.org>.
Humbedooh commented on pull request #19:
URL: https://github.com/apache/incubator-ponymail-foal/pull/19#issuecomment-833485086


   I like this idea.
   Could it be extended so that focus_domain could be either a boolean (use host: attribute) OR a string, in which case it would match lists against the string, potentially fnmatch'ed ?
   
   So that...
   * `ui.focus_domain: true` <- focus on host: attribute only
   * `ui.focus_domain: example.org`  <- focus on *@example.org only
   * `ui.focus_domain: *.example.org` <- focus on all *@*.example.org lists only
   
   This of course will depend on what the ultimate goal is, maybe my idea is suited for another variable..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org