You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2026/01/06 22:18:54 UTC
Re: [PR] Add react compiler [airflow]
bbovenzi commented on code in PR #59533:
URL: https://github.com/apache/airflow/pull/59533#discussion_r2666471015
##########
airflow-core/src/airflow/ui/src/components/DataTable/DataTable.tsx:
##########
@@ -29,7 +29,7 @@ import {
type Table as TanStackTable,
type Updater,
} from "@tanstack/react-table";
-import React, { type ReactNode, useCallback, useRef, useState } from "react";
+import React, { type ReactNode, useRef, useState, useCallback } from "react";
Review Comment:
We need to keep memo and callback to make tanstack/react-table work. This also meant not passing the entire `table` object as props to other components
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org