You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "rickyma (via GitHub)" <gi...@apache.org> on 2024/05/28 05:11:31 UTC

[PR] [#1699][FOLLOWUP] fix(client): Add commons-collections4 dependencies in shaded clients [incubator-uniffle]

rickyma opened a new pull request, #1742:
URL: https://github.com/apache/incubator-uniffle/pull/1742

   ### What changes were proposed in this pull request?
   
   Add commons-collections4 dependencies in shaded clients.
   
   ### Why are the changes needed?
   
   After https://github.com/apache/incubator-uniffle/pull/1700, in some versions of Spark, the `commons-collections4` dependency could be missing. Add the potential missing dependency to improve robustness.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Existing UTs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1699][FOLLOWUP] fix(client): Add commons-collections4 dependencies in shaded clients [incubator-uniffle]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1742:
URL: https://github.com/apache/incubator-uniffle/pull/1742#issuecomment-2134385917

   ## Test Results
    2 419 files  ±0   2 419 suites  ±0   4h 58m 23s :stopwatch: -17s
      933 tests ±0     932 :white_check_mark: ±0   1 :zzz: ±0  0 :x: ±0 
   10 819 runs  ±0  10 805 :white_check_mark: ±0  14 :zzz: ±0  0 :x: ±0 
   
   Results for commit 2afef5df. ± Comparison against base commit 59b899eb.
   
   [test-results]:data:application/gzip;base64,H4sIAJ5uVWYC/03NSw7CIBhG0a00jB3wrOBmDAX+hNgWQ2Fk3LtAWmT4HeDyQeBXd6DHRDlRtwkd2adx2xx18mEvQu4Ks0LlPNUbivX1PLIxjeifXv5dX3UA7dcCuIOLMcRTYt5rk2DZvq3zihbDottZ5RcM1bbHqAnb5lMZiGpwICxQyYEuUgjGQTEpsTIzE9JyOy/AMEXfH+S7jXQSAQAA
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1699][FOLLOWUP] fix(client): Add commons-collections4 dependencies in shaded clients [incubator-uniffle]

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #1742:
URL: https://github.com/apache/incubator-uniffle/pull/1742


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1699][FOLLOWUP] fix(client): Add commons-collections4 dependencies in shaded clients [incubator-uniffle]

Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1742:
URL: https://github.com/apache/incubator-uniffle/pull/1742#issuecomment-2138808231

   This should be merged too. It might affect some old spark versions which do not have commons-collections4 dependencies.
   
   @jerqi @zuston 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1699][FOLLOWUP] fix(client): Add commons-collections4 dependencies in shaded clients [incubator-uniffle]

Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1742:
URL: https://github.com/apache/incubator-uniffle/pull/1742#issuecomment-2134428222

   @zuston @jerqi PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1699][FOLLOWUP] fix(client): Add commons-collections4 dependencies in shaded clients [incubator-uniffle]

Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1742:
URL: https://github.com/apache/incubator-uniffle/pull/1742#issuecomment-2144215764

   ping @zuston @jerqi ~~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org