[jira] [Commented] (GEODE-160) Use '--is-inside-working-tree' to verify Git workspace

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643296#comment-14643296 ] 

ASF subversion and git services commented on GEODE-160:
-------------------------------------------------------

Commit 2647f0e71b341804a5efc69d58c593336e02672b in incubator-geode's branch refs/heads/feature/GEODE-160 from [~mbretl]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=2647f0e ]

[GEODE-160] Modify Git workspace check to use '--is-inside-working-tree' git command

Tested with using Git checkout and outside Git workspace using git archive


> Use '--is-inside-working-tree' to verify Git workspace
> ------------------------------------------------------
>
>                 Key: GEODE-160
>                 URL: https://issues.apache.org/jira/browse/GEODE-160
>             Project: Geode
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 1.0.0-incubating
>            Reporter: Mark Bretl
>            Assignee: Mark Bretl
>            Priority: Minor
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> In order to find out if the working directory is a Git workspace, the build tries to find the '.git' directory and then assumes it is a Git workspace with a working git executable command.
> The logic is flawed and the build can use the git command 'git rev-parse --is-inside-working-tree' to figure out both if it has a working git executable and if it is inside a Git workspace.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)