You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "hussein-awala (via GitHub)" <gi...@apache.org> on 2023/08/07 20:25:42 UTC
[GitHub] [airflow] hussein-awala commented on pull request #30558: Clean microsoft azure provider by deleting the custom prefix from conn extra fields
hussein-awala commented on PR #30558:
URL: https://github.com/apache/airflow/pull/30558#issuecomment-1668523646
@potiuk I tested this PR with 2.4.0 (the current min version) and with main, I can create connections with and without the `extra__azure__` prefix without any issue. What kind of tests should I do before merging it?
And for this commet:
> Hmm. I think the problem was that without the "ensure prefixes" providers_manager woudl crash during building the UI fir connections or at least wreak some havoc. I think we would need to build such provder and install it in airflow 2.3 to be sure.
There is no problems with the UI:
(6.2.3 because I built it with breeze and installed it from source in a clean conda env)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org