You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/19 03:41:15 UTC

[GitHub] [incubator-devlake] klesh commented on pull request #2995: feat(config-ui): added prettier to help format code

klesh commented on PR #2995:
URL: https://github.com/apache/incubator-devlake/pull/2995#issuecomment-1250534700

   According to what I learned from @mintsweet, the configuration of this PR is compatible with the current codebase. 
   
   The plan is:
   1. Setup prettier based on the current codebase in this milestone
   2. **Maybe** change some settings as we see fit, **Must** format all config-ui source files in the next milestone
   
   If I understand it correctly, this PR should be merged ASAP:
   1. This is local-setup, specifically for `config-ui` in terms of developers working on multiple frontend projects at the same time.
   2. This is not a breaking-change at the moment
   3. This is making @mintsweet hard to do his work, because he has to format the code manually. Asking one to set it up on IDE/Editor level(Globally) is not a good way for an open source project.
   
   @e2corporation I think we should merge this one first, what do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org