You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2014/01/05 14:12:05 UTC
svn commit: r1555492 - /subversion/trunk/subversion/libsvn_fs_fs/tree.c
Author: stefan2
Date: Sun Jan 5 13:12:04 2014
New Revision: 1555492
URL: http://svn.apache.org/r1555492
Log:
Fix a "will not be inlined" warning.
* subversion/libsvn_fs_fs/tree.c
(stringify_node): Drop the inline marker since this function will
onlx be called for error object creation.
Modified:
subversion/trunk/subversion/libsvn_fs_fs/tree.c
Modified: subversion/trunk/subversion/libsvn_fs_fs/tree.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/tree.c?rev=1555492&r1=1555491&r2=1555492&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_fs/tree.c (original)
+++ subversion/trunk/subversion/libsvn_fs_fs/tree.c Sun Jan 5 13:12:04 2014
@@ -4450,7 +4450,7 @@ make_txn_root(svn_fs_root_t **root_p,
/* Verify. */
-static APR_INLINE const char *
+static const char *
stringify_node(dag_node_t *node,
apr_pool_t *pool)
{
Re: svn commit: r1555492 - /subversion/trunk/subversion/libsvn_fs_fs/tree.c
Posted by Branko Čibej <br...@wandisco.com>.
On 05.01.2014 14:12, stefan2@apache.org wrote:
> Author: stefan2
> Date: Sun Jan 5 13:12:04 2014
> New Revision: 1555492
>
> URL: http://svn.apache.org/r1555492
> Log:
> Fix a "will not be inlined" warning.
>
> * subversion/libsvn_fs_fs/tree.c
> (stringify_node): Drop the inline marker since this function will
> onlx be called for error object creation.
Do you think it's worth the churn to simply drop all APR_INLINE markers
throughout our C code? I would guess that, these days, they're
completely unnecessary.
-- Brane
--
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane@wandisco.com