You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sahil Takiar (Code Review)" <ge...@cloudera.org> on 2020/03/03 01:06:28 UTC

[Impala-ASF-CR] santizer and -release flags should cause buildall.sh to exit

Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15341


Change subject: santizer and -release flags should cause buildall.sh to exit
......................................................................

santizer and -release flags should cause buildall.sh to exit

Currently, if any sanitizer (or clang-tidy) flag is added to buildall.sh
and the -release flag is added, then buildall.sh will silently ignore
the -release flag. Impala does not support adding sanitizer flags to
debug/release builds. Sanitizers, release, and debug builds are all
distinct and use their own set of compile flags.

This patch changes the behavior of buildall.sh so that if -release and
any sanitizer flag is specified, the build exits with the error:
"ERROR: more than one CMake build type defined: RELEASE TSAN"

Testing:
* './buildall.sh -skiptests -noclean -tsan -release' fails (as expected)
* './buildall.sh -skiptests -noclean -tsan' passes
* './buildall.sh -notests -noclean -codecoverage -release' passes

Change-Id: Ide0c2017d4e5abbf6fcb25c890d241bbcee8422e
---
M buildall.sh
1 file changed, 10 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/15341/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide0c2017d4e5abbf6fcb25c890d241bbcee8422e
Gerrit-Change-Number: 15341
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>

[Impala-ASF-CR] santizer and -release flags should cause buildall.sh to exit

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15341 )

Change subject: santizer and -release flags should cause buildall.sh to exit
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5395/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide0c2017d4e5abbf6fcb25c890d241bbcee8422e
Gerrit-Change-Number: 15341
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 01:29:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] santizer and -release flags should cause buildall.sh to exit

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15341 )

Change subject: santizer and -release flags should cause buildall.sh to exit
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide0c2017d4e5abbf6fcb25c890d241bbcee8422e
Gerrit-Change-Number: 15341
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 01:53:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] santizer and -release flags should cause buildall.sh to exit

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15341 )

Change subject: santizer and -release flags should cause buildall.sh to exit
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide0c2017d4e5abbf6fcb25c890d241bbcee8422e
Gerrit-Change-Number: 15341
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 06:02:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] santizer and -release flags should cause buildall.sh to exit

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15341 )

Change subject: santizer and -release flags should cause buildall.sh to exit
......................................................................

santizer and -release flags should cause buildall.sh to exit

Currently, if any sanitizer (or clang-tidy) flag is added to buildall.sh
and the -release flag is added, then buildall.sh will silently ignore
the -release flag. Impala does not support adding sanitizer flags to
debug/release builds. Sanitizers, release, and debug builds are all
distinct and use their own set of compile flags.

This patch changes the behavior of buildall.sh so that if -release and
any sanitizer flag is specified, the build exits with the error:
"ERROR: more than one CMake build type defined: RELEASE TSAN"

Testing:
* './buildall.sh -skiptests -noclean -tsan -release' fails (as expected)
* './buildall.sh -skiptests -noclean -tsan' passes
* './buildall.sh -notests -noclean -codecoverage -release' passes

Change-Id: Ide0c2017d4e5abbf6fcb25c890d241bbcee8422e
Reviewed-on: http://gerrit.cloudera.org:8080/15341
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M buildall.sh
1 file changed, 10 insertions(+), 7 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide0c2017d4e5abbf6fcb25c890d241bbcee8422e
Gerrit-Change-Number: 15341
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] santizer and -release flags should cause buildall.sh to exit

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15341 )

Change subject: santizer and -release flags should cause buildall.sh to exit
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5440/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide0c2017d4e5abbf6fcb25c890d241bbcee8422e
Gerrit-Change-Number: 15341
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 01:07:15 +0000
Gerrit-HasComments: No