You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by nottyjay <gi...@git.apache.org> on 2016/12/26 08:22:14 UTC

[GitHub] incubator-rocketmq pull request #13: [ROCKETMQ-15] Add config file. easy to ...

GitHub user nottyjay opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/13

    [ROCKETMQ-15] Add config file. easy to change some setting

    Add namesrv.conf and broker.conf, add port setting in `BrokerConfig` and `NameServerConfig`.
    Step 1: change port setting in namesrv.conf and broker.conf
    Step 2: run `bin/mqnamesrv` and `bin/mqbroker -n localhost:{new nameserver port}`
    Step 3: run `expamle.Producer` and `example.Consumer`
    
    JIRA issue:[https://issues.apache.org/jira/browse/ROCKETMQ-7](https://issues.apache.org/jira/browse/ROCKETMQ-7)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nottyjay/incubator-rocketmq master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13
    
----
commit 32e6333a73e72a8282aa0d26bac38136a0c6d747
Author: Nottyjay <89...@qq.com>
Date:   2016-12-22T10:11:46Z

    Null check is not needed -- can't be null when reaches this point.

commit 0d12646515f7ece16f5790c1579b67ca00c0e2f6
Author: Nottyjay <89...@qq.com>
Date:   2016-12-23T06:04:16Z

    Merge branches 'master' and 'master' of github.com:apache/incubator-rocketmq

commit d7b162a7ba609dc976e3e67b0610f30efa28b562
Author: Nottyjay <co...@gmail.com>
Date:   2016-12-25T14:28:55Z

    Add namesrv config file

commit a245677b0c4e19a17dd4c0893922bd542deb1765
Author: Nottyjay <co...@gmail.com>
Date:   2016-12-25T14:29:01Z

    Merge branch 'master' of github.com:apache/incubator-rocketmq

commit 12f978c6abdd1853afb49164b0efe1049a13dabe
Author: Nottyjay <co...@gmail.com>
Date:   2016-12-25T16:28:37Z

    NameServerConnector Test unit

commit 54aab0b122377d0175fbc4ad972b946fead02a3e
Author: Nottyjay <89...@qq.com>
Date:   2016-12-26T06:31:54Z

    Add broker config

commit bb1f2c70d8f80743b481105a75bba7bbe96cc4e5
Author: Nottyjay <89...@qq.com>
Date:   2016-12-26T06:32:52Z

    change print message

commit 8f77c5a1772aa7c13fdcc0992dfea23e2d2a7f85
Author: Nottyjay <89...@qq.com>
Date:   2016-12-26T07:37:54Z

    fix broker start bug.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #13: [ROCKETMQ-15] Add config file. easy to change ...

Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/13
  
    Hi,
    
    Just config `listenPort` in `broker.conf` or `namesrv.conf`,  the server will parse and use it.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #13: [ROCKETMQ-15] Add config file. easy to ...

Posted by nottyjay <gi...@git.apache.org>.
Github user nottyjay closed the pull request at:

    https://github.com/apache/incubator-rocketmq/pull/13


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #13: [ROCKETMQ-15] Add config file. easy to change ...

Posted by nottyjay <gi...@git.apache.org>.
Github user nottyjay commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/13
  
    ok. This fix is only needed in my company. So i code it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #13: [ROCKETMQ-15] Add config file. easy to change ...

Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/13
  
    Hi @nottyjay 
    
    There is no need to add `port` to NamesrvConfig, please check `NettyServerConfig.listenPort`.
    
    And I replied you that all the fields in *Config.java are configurable in JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-7.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---