You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airflow.apache.org by Bas Harenslak <ba...@godatadriven.com> on 2019/04/11 20:50:01 UTC
[VOTE] AIP-6 Apply Pylint to Airflow
Hello Airflow community,
This email calls for a vote to introduce Pylint in the Airflow project. The vote will last for at least 1 week (April 18th 23:00 CET), and at least three +1 (binding) votes have been cast.
After feedback on AIP-6 and discussion on Slack<https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400>, I propose to vote for adding Pylint<https://pylint.org> to the Airflow project for static code checking. Pylint complements Flake8 with stricter rules, detects code smells and is customisable so unnecessary checks can be ignored. This should benefit the Airflow code base with consistent, documented code and less errors.
Note that Pylint 2.0 works with Python 3 only, so if the vote is successful, it should be introduced after dropping support for Python 2 (AIRFLOW-4196<https://issues.apache.org/jira/browse/AIRFLOW-4196>).
Note2: to keep the scope as small as possible, I’ll create a separate vote for Black formatting.
Cheers,
Bas
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by Felix Uellendall <fe...@gmx.de>.
That's sounds good. Start with the diffs and see what error-codes we
want to enable.
-feluelle
Am 14/04/2019 um 23:02 schrieb Driesprong, Fokko:
> We could also consider first ignoring all the error-codes globally, and
> then enable them one by one, based on which violations we find important.
>
> Cheers, Fokko
>
> Op zo 14 apr. 2019 om 23:00 schreef Bas Harenslak <
> basharenslak@godatadriven.com>:
>
>> Applying it on the diff first sounds good. At some point in time we’ll
>> need to do a big bang to make the lesser-touched parts of Airflow
>> compatible with Pylint.
>>
>> I’ll check how to apply it on the diff when I find time.
>>
>> Bas
>>
>> On 14 Apr 2019, at 22:37, Driesprong, Fokko <fokko@driesprong.frl<mailto:
>> fokko@driesprong.frl>> wrote:
>>
>> My main question is how are we going to enforce this. Did a quick check:
>>
>> Right now we have around 22k violations on master:
>>
>> MacBook-Pro-van-Fokko:incubator-airflow fokkodriesprong$ find . -name
>> "*.py" | xargs pylint | wc -l
>> No config file found, using default configuration
>> 22465
>>
>> After applying Black, we end up with over 36k :p
>>
>> MacBook-Pro-van-Fokko:incubator-airflow fokkodriesprong$ find . -name
>> "*.py" | xargs pylint | wc -l
>> No config file found, using default configuration
>> 36728
>>
>> Maybe we should do it as we did for Flake8, and do diff's between new PR's
>> and master first.
>>
>> Cheers, Fokko
>>
>>
>>
>> Op za 13 apr. 2019 om 10:47 schreef Felix Uellendall <
>> felix.uellendall@gmx.de<ma...@gmx.de>>:
>>
>> +1 (non-binding)
>>
>> -feluelle
>>
>> Am 13/04/2019 um 07:53 schrieb Chao-Han Tsai:
>> +1 (non-binding)
>>
>> On Fri, Apr 12, 2019 at 8:05 AM Chen Tong <cixuuz@gmail.com<mailto:
>> cixuuz@gmail.com>> wrote:
>>
>> +1 (non-binding).
>>
>> On Fri, Apr 12, 2019 at 9:28 AM Julian De Ruiter <
>> julianderuiter@godatadriven.com<ma...@godatadriven.com>>
>> wrote:
>>
>> I also wouldn’t mind including black for checking formatting.
>>
>> On 12 Apr 2019, at 15:20, Julian De Ruiter <
>> julianderuiter@godatadriven.com<ma...@godatadriven.com>>
>> wrote:
>> +1 non-binding
>>
>> On 12 Apr 2019, at 07:25, Maxime Beauchemin <
>> maximebeauchemin@gmail.com<ma...@gmail.com>>
>> wrote:
>> +1 (binding)
>>
>> Also check out black to auto-pep8!
>> https://github.com/ambv/black
>>
>> On Thu, Apr 11, 2019 at 5:12 PM Tao Feng <fe...@gmail.com>
>> wrote:
>>
>> +1
>>
>> On Thu, Apr 11, 2019 at 4:27 PM Beau Barker <
>> beauinmelbourne@gmail.com<ma...@gmail.com>
>> wrote:
>>
>> +1 non binding
>>
>> Pylint is extremely strict so your may want to be selective about
>> the
>> rules it applies.
>>
>>
>> On 12 Apr 2019, at 7:15 am, Kamil Breguła <
>> kamil.bregula@polidea.com
>> wrote:
>> +! (non-binding)
>>
>> On Thu, Apr 11, 2019 at 11:05 PM Driesprong, Fokko
>> <fokko@driesprong.frl
>> wrote:
>>
>> +1 (binding)
>>
>> For more information about AIP-6:
>>
>>
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=99844429
>> Op do 11 apr. 2019 om 23:03 schreef Kaxil Naik <
>> kaxilnaik@gmail.com
>> :
>> +1 (binding)
>>
>> On Thu, Apr 11, 2019 at 9:51 PM Jarek Potiuk <
>> Jarek.Potiuk@polidea.com
>> wrote:
>>
>> +1 (non-binding).
>>
>> On Thu, Apr 11, 2019 at 10:50 PM Bas Harenslak <
>> basharenslak@godatadriven.com> wrote:
>>
>> Hello Airflow community,
>>
>> This email calls for a vote to introduce Pylint in the Airflow
>> project.
>> The vote will last for at least 1 week (April 18th 23:00 CET),
>> and
>> at
>> least
>> three +1 (binding) votes have been cast.
>>
>> After feedback on AIP-6 and discussion on Slack<
>>
>> https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400
>> ,
>> I
>> propose to vote for adding Pylint<https://pylint.org> to the
>> Airflow
>> project for static code checking. Pylint complements Flake8
>> with
>> stricter
>> rules, detects code smells and is customisable so unnecessary
>> checks
>> can
>> be
>> ignored. This should benefit the Airflow code base with
>> consistent,
>> documented code and less errors.
>>
>> Note that Pylint 2.0 works with Python 3 only, so if the vote
>> is
>> successful, it should be introduced after dropping support for
>> Python 2
>> (AIRFLOW-4196<
>> https://issues.apache.org/jira/browse/AIRFLOW-4196
>> ).
>> Note2: to keep the scope as small as possible, I’ll create a
>> separate
>> vote
>> for Black formatting.
>>
>> Cheers,
>> Bas
>>
>>
>> --
>>
>> Jarek Potiuk
>> Polidea <https://www.polidea.com/> | Principal Software
>> Engineer
>> M: +48 660 796 129 <+48660796129>
>> E: jarek.potiuk@polidea.com
>>
>>
>> --
>> *Kaxil Naik*
>> *Big Data Consultant *@ *Data Reply UK*
>> *Certified *Google Cloud Data Engineer | *Certified* Apache
>> Spark &
>> Neo4j
>> Developer
>> *LinkedIn*: https://www.linkedin.com/in/kaxil
>>
>>
>> --
>>
>> Kamil Breguła
>> Polidea <https://www.polidea.com/> | Software Engineer
>>
>> M: +48 505 458 451 <+48505458451>
>> E: kamil.bregula@polidea.com
>> [image: Polidea] <https://www.polidea.com/>
>>
>> We create human & business stories through technology.
>> Check out our projects! <https://www.polidea.com/our-work>
>> [image: Github] <https://github.com/Polidea> [image: Facebook]
>> <https://www.facebook.com/Polidea.Software> [image: Twitter]
>> <https://twitter.com/polidea> [image: Linkedin]
>> <https://www.linkedin.com/company/polidea> [image: Instagram]
>> <https://instagram.com/polidea> [image: Behance]
>> <https://www.behance.net/polidea>
>>
>>
>>
>>
>>
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by "Driesprong, Fokko" <fo...@driesprong.frl>.
We could also consider first ignoring all the error-codes globally, and
then enable them one by one, based on which violations we find important.
Cheers, Fokko
Op zo 14 apr. 2019 om 23:00 schreef Bas Harenslak <
basharenslak@godatadriven.com>:
> Applying it on the diff first sounds good. At some point in time we’ll
> need to do a big bang to make the lesser-touched parts of Airflow
> compatible with Pylint.
>
> I’ll check how to apply it on the diff when I find time.
>
> Bas
>
> On 14 Apr 2019, at 22:37, Driesprong, Fokko <fokko@driesprong.frl<mailto:
> fokko@driesprong.frl>> wrote:
>
> My main question is how are we going to enforce this. Did a quick check:
>
> Right now we have around 22k violations on master:
>
> MacBook-Pro-van-Fokko:incubator-airflow fokkodriesprong$ find . -name
> "*.py" | xargs pylint | wc -l
> No config file found, using default configuration
> 22465
>
> After applying Black, we end up with over 36k :p
>
> MacBook-Pro-van-Fokko:incubator-airflow fokkodriesprong$ find . -name
> "*.py" | xargs pylint | wc -l
> No config file found, using default configuration
> 36728
>
> Maybe we should do it as we did for Flake8, and do diff's between new PR's
> and master first.
>
> Cheers, Fokko
>
>
>
> Op za 13 apr. 2019 om 10:47 schreef Felix Uellendall <
> felix.uellendall@gmx.de<ma...@gmx.de>>:
>
> +1 (non-binding)
>
> -feluelle
>
> Am 13/04/2019 um 07:53 schrieb Chao-Han Tsai:
> +1 (non-binding)
>
> On Fri, Apr 12, 2019 at 8:05 AM Chen Tong <cixuuz@gmail.com<mailto:
> cixuuz@gmail.com>> wrote:
>
> +1 (non-binding).
>
> On Fri, Apr 12, 2019 at 9:28 AM Julian De Ruiter <
> julianderuiter@godatadriven.com<ma...@godatadriven.com>>
> wrote:
>
> I also wouldn’t mind including black for checking formatting.
>
> On 12 Apr 2019, at 15:20, Julian De Ruiter <
> julianderuiter@godatadriven.com<ma...@godatadriven.com>>
> wrote:
> +1 non-binding
>
> On 12 Apr 2019, at 07:25, Maxime Beauchemin <
> maximebeauchemin@gmail.com<ma...@gmail.com>>
> wrote:
> +1 (binding)
>
> Also check out black to auto-pep8!
> https://github.com/ambv/black
>
> On Thu, Apr 11, 2019 at 5:12 PM Tao Feng <fe...@gmail.com>
> wrote:
>
> +1
>
> On Thu, Apr 11, 2019 at 4:27 PM Beau Barker <
> beauinmelbourne@gmail.com<ma...@gmail.com>
> wrote:
>
> +1 non binding
>
> Pylint is extremely strict so your may want to be selective about
> the
> rules it applies.
>
>
> On 12 Apr 2019, at 7:15 am, Kamil Breguła <
> kamil.bregula@polidea.com
> wrote:
> +! (non-binding)
>
> On Thu, Apr 11, 2019 at 11:05 PM Driesprong, Fokko
> <fokko@driesprong.frl
> wrote:
>
> +1 (binding)
>
> For more information about AIP-6:
>
>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=99844429
> Op do 11 apr. 2019 om 23:03 schreef Kaxil Naik <
> kaxilnaik@gmail.com
> :
> +1 (binding)
>
> On Thu, Apr 11, 2019 at 9:51 PM Jarek Potiuk <
> Jarek.Potiuk@polidea.com
> wrote:
>
> +1 (non-binding).
>
> On Thu, Apr 11, 2019 at 10:50 PM Bas Harenslak <
> basharenslak@godatadriven.com> wrote:
>
> Hello Airflow community,
>
> This email calls for a vote to introduce Pylint in the Airflow
> project.
> The vote will last for at least 1 week (April 18th 23:00 CET),
> and
> at
> least
> three +1 (binding) votes have been cast.
>
> After feedback on AIP-6 and discussion on Slack<
>
> https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400
> ,
> I
> propose to vote for adding Pylint<https://pylint.org> to the
> Airflow
> project for static code checking. Pylint complements Flake8
> with
> stricter
> rules, detects code smells and is customisable so unnecessary
> checks
> can
> be
> ignored. This should benefit the Airflow code base with
> consistent,
> documented code and less errors.
>
> Note that Pylint 2.0 works with Python 3 only, so if the vote
> is
> successful, it should be introduced after dropping support for
> Python 2
> (AIRFLOW-4196<
> https://issues.apache.org/jira/browse/AIRFLOW-4196
> ).
> Note2: to keep the scope as small as possible, I’ll create a
> separate
> vote
> for Black formatting.
>
> Cheers,
> Bas
>
>
> --
>
> Jarek Potiuk
> Polidea <https://www.polidea.com/> | Principal Software
> Engineer
> M: +48 660 796 129 <+48660796129>
> E: jarek.potiuk@polidea.com
>
>
> --
> *Kaxil Naik*
> *Big Data Consultant *@ *Data Reply UK*
> *Certified *Google Cloud Data Engineer | *Certified* Apache
> Spark &
> Neo4j
> Developer
> *LinkedIn*: https://www.linkedin.com/in/kaxil
>
>
> --
>
> Kamil Breguła
> Polidea <https://www.polidea.com/> | Software Engineer
>
> M: +48 505 458 451 <+48505458451>
> E: kamil.bregula@polidea.com
> [image: Polidea] <https://www.polidea.com/>
>
> We create human & business stories through technology.
> Check out our projects! <https://www.polidea.com/our-work>
> [image: Github] <https://github.com/Polidea> [image: Facebook]
> <https://www.facebook.com/Polidea.Software> [image: Twitter]
> <https://twitter.com/polidea> [image: Linkedin]
> <https://www.linkedin.com/company/polidea> [image: Instagram]
> <https://instagram.com/polidea> [image: Behance]
> <https://www.behance.net/polidea>
>
>
>
>
>
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by Bas Harenslak <ba...@godatadriven.com>.
Applying it on the diff first sounds good. At some point in time we’ll need to do a big bang to make the lesser-touched parts of Airflow compatible with Pylint.
I’ll check how to apply it on the diff when I find time.
Bas
On 14 Apr 2019, at 22:37, Driesprong, Fokko <fo...@driesprong.frl>> wrote:
My main question is how are we going to enforce this. Did a quick check:
Right now we have around 22k violations on master:
MacBook-Pro-van-Fokko:incubator-airflow fokkodriesprong$ find . -name
"*.py" | xargs pylint | wc -l
No config file found, using default configuration
22465
After applying Black, we end up with over 36k :p
MacBook-Pro-van-Fokko:incubator-airflow fokkodriesprong$ find . -name
"*.py" | xargs pylint | wc -l
No config file found, using default configuration
36728
Maybe we should do it as we did for Flake8, and do diff's between new PR's
and master first.
Cheers, Fokko
Op za 13 apr. 2019 om 10:47 schreef Felix Uellendall <
felix.uellendall@gmx.de<ma...@gmx.de>>:
+1 (non-binding)
-feluelle
Am 13/04/2019 um 07:53 schrieb Chao-Han Tsai:
+1 (non-binding)
On Fri, Apr 12, 2019 at 8:05 AM Chen Tong <ci...@gmail.com>> wrote:
+1 (non-binding).
On Fri, Apr 12, 2019 at 9:28 AM Julian De Ruiter <
julianderuiter@godatadriven.com<ma...@godatadriven.com>> wrote:
I also wouldn’t mind including black for checking formatting.
On 12 Apr 2019, at 15:20, Julian De Ruiter <
julianderuiter@godatadriven.com<ma...@godatadriven.com>> wrote:
+1 non-binding
On 12 Apr 2019, at 07:25, Maxime Beauchemin <
maximebeauchemin@gmail.com<ma...@gmail.com>>
wrote:
+1 (binding)
Also check out black to auto-pep8!
https://github.com/ambv/black
On Thu, Apr 11, 2019 at 5:12 PM Tao Feng <fe...@gmail.com>
wrote:
+1
On Thu, Apr 11, 2019 at 4:27 PM Beau Barker <
beauinmelbourne@gmail.com<ma...@gmail.com>
wrote:
+1 non binding
Pylint is extremely strict so your may want to be selective about
the
rules it applies.
On 12 Apr 2019, at 7:15 am, Kamil Breguła <
kamil.bregula@polidea.com
wrote:
+! (non-binding)
On Thu, Apr 11, 2019 at 11:05 PM Driesprong, Fokko
<fokko@driesprong.frl
wrote:
+1 (binding)
For more information about AIP-6:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=99844429
Op do 11 apr. 2019 om 23:03 schreef Kaxil Naik <
kaxilnaik@gmail.com
:
+1 (binding)
On Thu, Apr 11, 2019 at 9:51 PM Jarek Potiuk <
Jarek.Potiuk@polidea.com
wrote:
+1 (non-binding).
On Thu, Apr 11, 2019 at 10:50 PM Bas Harenslak <
basharenslak@godatadriven.com> wrote:
Hello Airflow community,
This email calls for a vote to introduce Pylint in the Airflow
project.
The vote will last for at least 1 week (April 18th 23:00 CET),
and
at
least
three +1 (binding) votes have been cast.
After feedback on AIP-6 and discussion on Slack<
https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400
,
I
propose to vote for adding Pylint<https://pylint.org> to the
Airflow
project for static code checking. Pylint complements Flake8
with
stricter
rules, detects code smells and is customisable so unnecessary
checks
can
be
ignored. This should benefit the Airflow code base with
consistent,
documented code and less errors.
Note that Pylint 2.0 works with Python 3 only, so if the vote
is
successful, it should be introduced after dropping support for
Python 2
(AIRFLOW-4196<
https://issues.apache.org/jira/browse/AIRFLOW-4196
).
Note2: to keep the scope as small as possible, I’ll create a
separate
vote
for Black formatting.
Cheers,
Bas
--
Jarek Potiuk
Polidea <https://www.polidea.com/> | Principal Software
Engineer
M: +48 660 796 129 <+48660796129>
E: jarek.potiuk@polidea.com
--
*Kaxil Naik*
*Big Data Consultant *@ *Data Reply UK*
*Certified *Google Cloud Data Engineer | *Certified* Apache
Spark &
Neo4j
Developer
*LinkedIn*: https://www.linkedin.com/in/kaxil
--
Kamil Breguła
Polidea <https://www.polidea.com/> | Software Engineer
M: +48 505 458 451 <+48505458451>
E: kamil.bregula@polidea.com
[image: Polidea] <https://www.polidea.com/>
We create human & business stories through technology.
Check out our projects! <https://www.polidea.com/our-work>
[image: Github] <https://github.com/Polidea> [image: Facebook]
<https://www.facebook.com/Polidea.Software> [image: Twitter]
<https://twitter.com/polidea> [image: Linkedin]
<https://www.linkedin.com/company/polidea> [image: Instagram]
<https://instagram.com/polidea> [image: Behance]
<https://www.behance.net/polidea>
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by "Driesprong, Fokko" <fo...@driesprong.frl>.
My main question is how are we going to enforce this. Did a quick check:
Right now we have around 22k violations on master:
MacBook-Pro-van-Fokko:incubator-airflow fokkodriesprong$ find . -name
"*.py" | xargs pylint | wc -l
No config file found, using default configuration
22465
After applying Black, we end up with over 36k :p
MacBook-Pro-van-Fokko:incubator-airflow fokkodriesprong$ find . -name
"*.py" | xargs pylint | wc -l
No config file found, using default configuration
36728
Maybe we should do it as we did for Flake8, and do diff's between new PR's
and master first.
Cheers, Fokko
Op za 13 apr. 2019 om 10:47 schreef Felix Uellendall <
felix.uellendall@gmx.de>:
> +1 (non-binding)
>
> -feluelle
>
> Am 13/04/2019 um 07:53 schrieb Chao-Han Tsai:
> > +1 (non-binding)
> >
> > On Fri, Apr 12, 2019 at 8:05 AM Chen Tong <ci...@gmail.com> wrote:
> >
> >> +1 (non-binding).
> >>
> >> On Fri, Apr 12, 2019 at 9:28 AM Julian De Ruiter <
> >> julianderuiter@godatadriven.com> wrote:
> >>
> >>> I also wouldn’t mind including black for checking formatting.
> >>>
> >>>> On 12 Apr 2019, at 15:20, Julian De Ruiter <
> >>> julianderuiter@godatadriven.com> wrote:
> >>>> +1 non-binding
> >>>>
> >>>>> On 12 Apr 2019, at 07:25, Maxime Beauchemin <
> >> maximebeauchemin@gmail.com>
> >>> wrote:
> >>>>> +1 (binding)
> >>>>>
> >>>>> Also check out black to auto-pep8!
> >>>>> https://github.com/ambv/black
> >>>>>
> >>>>> On Thu, Apr 11, 2019 at 5:12 PM Tao Feng <fe...@gmail.com>
> wrote:
> >>>>>
> >>>>>> +1
> >>>>>>
> >>>>>> On Thu, Apr 11, 2019 at 4:27 PM Beau Barker <
> >> beauinmelbourne@gmail.com
> >>>>>> wrote:
> >>>>>>
> >>>>>>> +1 non binding
> >>>>>>>
> >>>>>>> Pylint is extremely strict so your may want to be selective about
> >> the
> >>>>>>> rules it applies.
> >>>>>>>
> >>>>>>>
> >>>>>>>> On 12 Apr 2019, at 7:15 am, Kamil Breguła <
> >> kamil.bregula@polidea.com
> >>>>>>> wrote:
> >>>>>>>> +! (non-binding)
> >>>>>>>>
> >>>>>>>> On Thu, Apr 11, 2019 at 11:05 PM Driesprong, Fokko
> >>>>>> <fokko@driesprong.frl
> >>>>>>>> wrote:
> >>>>>>>>
> >>>>>>>>> +1 (binding)
> >>>>>>>>>
> >>>>>>>>> For more information about AIP-6:
> >>>>>>>>>
> >>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=99844429
> >>>>>>>>> Op do 11 apr. 2019 om 23:03 schreef Kaxil Naik <
> >> kaxilnaik@gmail.com
> >>>> :
> >>>>>>>>>> +1 (binding)
> >>>>>>>>>>
> >>>>>>>>>> On Thu, Apr 11, 2019 at 9:51 PM Jarek Potiuk <
> >>>>>> Jarek.Potiuk@polidea.com
> >>>>>>>>>> wrote:
> >>>>>>>>>>
> >>>>>>>>>>> +1 (non-binding).
> >>>>>>>>>>>
> >>>>>>>>>>> On Thu, Apr 11, 2019 at 10:50 PM Bas Harenslak <
> >>>>>>>>>>> basharenslak@godatadriven.com> wrote:
> >>>>>>>>>>>
> >>>>>>>>>>>> Hello Airflow community,
> >>>>>>>>>>>>
> >>>>>>>>>>>> This email calls for a vote to introduce Pylint in the Airflow
> >>>>>>>>> project.
> >>>>>>>>>>>> The vote will last for at least 1 week (April 18th 23:00 CET),
> >>> and
> >>>>>> at
> >>>>>>>>>>> least
> >>>>>>>>>>>> three +1 (binding) votes have been cast.
> >>>>>>>>>>>>
> >>>>>>>>>>>> After feedback on AIP-6 and discussion on Slack<
> >>>>>>>>>>>>
> >>> https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400
> >>>>>>>>>>> ,
> >>>>>>>>>>> I
> >>>>>>>>>>>> propose to vote for adding Pylint<https://pylint.org> to the
> >>>>>> Airflow
> >>>>>>>>>>>> project for static code checking. Pylint complements Flake8
> >> with
> >>>>>>>>>> stricter
> >>>>>>>>>>>> rules, detects code smells and is customisable so unnecessary
> >>>>>> checks
> >>>>>>>>>> can
> >>>>>>>>>>> be
> >>>>>>>>>>>> ignored. This should benefit the Airflow code base with
> >>> consistent,
> >>>>>>>>>>>> documented code and less errors.
> >>>>>>>>>>>>
> >>>>>>>>>>>> Note that Pylint 2.0 works with Python 3 only, so if the vote
> >> is
> >>>>>>>>>>>> successful, it should be introduced after dropping support for
> >>>>>>>>> Python 2
> >>>>>>>>>>>> (AIRFLOW-4196<
> >> https://issues.apache.org/jira/browse/AIRFLOW-4196
> >>>>>>> ).
> >>>>>>>>>>>> Note2: to keep the scope as small as possible, I’ll create a
> >>>>>> separate
> >>>>>>>>>>> vote
> >>>>>>>>>>>> for Black formatting.
> >>>>>>>>>>>>
> >>>>>>>>>>>> Cheers,
> >>>>>>>>>>>> Bas
> >>>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>> --
> >>>>>>>>>>>
> >>>>>>>>>>> Jarek Potiuk
> >>>>>>>>>>> Polidea <https://www.polidea.com/> | Principal Software
> >> Engineer
> >>>>>>>>>>> M: +48 660 796 129 <+48660796129>
> >>>>>>>>>>> E: jarek.potiuk@polidea.com
> >>>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> --
> >>>>>>>>>> *Kaxil Naik*
> >>>>>>>>>> *Big Data Consultant *@ *Data Reply UK*
> >>>>>>>>>> *Certified *Google Cloud Data Engineer | *Certified* Apache
> >> Spark &
> >>>>>>> Neo4j
> >>>>>>>>>> Developer
> >>>>>>>>>> *LinkedIn*: https://www.linkedin.com/in/kaxil
> >>>>>>>>>>
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>>
> >>>>>>>> Kamil Breguła
> >>>>>>>> Polidea <https://www.polidea.com/> | Software Engineer
> >>>>>>>>
> >>>>>>>> M: +48 505 458 451 <+48505458451>
> >>>>>>>> E: kamil.bregula@polidea.com
> >>>>>>>> [image: Polidea] <https://www.polidea.com/>
> >>>>>>>>
> >>>>>>>> We create human & business stories through technology.
> >>>>>>>> Check out our projects! <https://www.polidea.com/our-work>
> >>>>>>>> [image: Github] <https://github.com/Polidea> [image: Facebook]
> >>>>>>>> <https://www.facebook.com/Polidea.Software> [image: Twitter]
> >>>>>>>> <https://twitter.com/polidea> [image: Linkedin]
> >>>>>>>> <https://www.linkedin.com/company/polidea> [image: Instagram]
> >>>>>>>> <https://instagram.com/polidea> [image: Behance]
> >>>>>>>> <https://www.behance.net/polidea>
> >>>
> >
>
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by Felix Uellendall <fe...@gmx.de>.
+1 (non-binding)
-feluelle
Am 13/04/2019 um 07:53 schrieb Chao-Han Tsai:
> +1 (non-binding)
>
> On Fri, Apr 12, 2019 at 8:05 AM Chen Tong <ci...@gmail.com> wrote:
>
>> +1 (non-binding).
>>
>> On Fri, Apr 12, 2019 at 9:28 AM Julian De Ruiter <
>> julianderuiter@godatadriven.com> wrote:
>>
>>> I also wouldn’t mind including black for checking formatting.
>>>
>>>> On 12 Apr 2019, at 15:20, Julian De Ruiter <
>>> julianderuiter@godatadriven.com> wrote:
>>>> +1 non-binding
>>>>
>>>>> On 12 Apr 2019, at 07:25, Maxime Beauchemin <
>> maximebeauchemin@gmail.com>
>>> wrote:
>>>>> +1 (binding)
>>>>>
>>>>> Also check out black to auto-pep8!
>>>>> https://github.com/ambv/black
>>>>>
>>>>> On Thu, Apr 11, 2019 at 5:12 PM Tao Feng <fe...@gmail.com> wrote:
>>>>>
>>>>>> +1
>>>>>>
>>>>>> On Thu, Apr 11, 2019 at 4:27 PM Beau Barker <
>> beauinmelbourne@gmail.com
>>>>>> wrote:
>>>>>>
>>>>>>> +1 non binding
>>>>>>>
>>>>>>> Pylint is extremely strict so your may want to be selective about
>> the
>>>>>>> rules it applies.
>>>>>>>
>>>>>>>
>>>>>>>> On 12 Apr 2019, at 7:15 am, Kamil Breguła <
>> kamil.bregula@polidea.com
>>>>>>> wrote:
>>>>>>>> +! (non-binding)
>>>>>>>>
>>>>>>>> On Thu, Apr 11, 2019 at 11:05 PM Driesprong, Fokko
>>>>>> <fokko@driesprong.frl
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> +1 (binding)
>>>>>>>>>
>>>>>>>>> For more information about AIP-6:
>>>>>>>>>
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=99844429
>>>>>>>>> Op do 11 apr. 2019 om 23:03 schreef Kaxil Naik <
>> kaxilnaik@gmail.com
>>>> :
>>>>>>>>>> +1 (binding)
>>>>>>>>>>
>>>>>>>>>> On Thu, Apr 11, 2019 at 9:51 PM Jarek Potiuk <
>>>>>> Jarek.Potiuk@polidea.com
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> +1 (non-binding).
>>>>>>>>>>>
>>>>>>>>>>> On Thu, Apr 11, 2019 at 10:50 PM Bas Harenslak <
>>>>>>>>>>> basharenslak@godatadriven.com> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hello Airflow community,
>>>>>>>>>>>>
>>>>>>>>>>>> This email calls for a vote to introduce Pylint in the Airflow
>>>>>>>>> project.
>>>>>>>>>>>> The vote will last for at least 1 week (April 18th 23:00 CET),
>>> and
>>>>>> at
>>>>>>>>>>> least
>>>>>>>>>>>> three +1 (binding) votes have been cast.
>>>>>>>>>>>>
>>>>>>>>>>>> After feedback on AIP-6 and discussion on Slack<
>>>>>>>>>>>>
>>> https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400
>>>>>>>>>>> ,
>>>>>>>>>>> I
>>>>>>>>>>>> propose to vote for adding Pylint<https://pylint.org> to the
>>>>>> Airflow
>>>>>>>>>>>> project for static code checking. Pylint complements Flake8
>> with
>>>>>>>>>> stricter
>>>>>>>>>>>> rules, detects code smells and is customisable so unnecessary
>>>>>> checks
>>>>>>>>>> can
>>>>>>>>>>> be
>>>>>>>>>>>> ignored. This should benefit the Airflow code base with
>>> consistent,
>>>>>>>>>>>> documented code and less errors.
>>>>>>>>>>>>
>>>>>>>>>>>> Note that Pylint 2.0 works with Python 3 only, so if the vote
>> is
>>>>>>>>>>>> successful, it should be introduced after dropping support for
>>>>>>>>> Python 2
>>>>>>>>>>>> (AIRFLOW-4196<
>> https://issues.apache.org/jira/browse/AIRFLOW-4196
>>>>>>> ).
>>>>>>>>>>>> Note2: to keep the scope as small as possible, I’ll create a
>>>>>> separate
>>>>>>>>>>> vote
>>>>>>>>>>>> for Black formatting.
>>>>>>>>>>>>
>>>>>>>>>>>> Cheers,
>>>>>>>>>>>> Bas
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>>
>>>>>>>>>>> Jarek Potiuk
>>>>>>>>>>> Polidea <https://www.polidea.com/> | Principal Software
>> Engineer
>>>>>>>>>>> M: +48 660 796 129 <+48660796129>
>>>>>>>>>>> E: jarek.potiuk@polidea.com
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> *Kaxil Naik*
>>>>>>>>>> *Big Data Consultant *@ *Data Reply UK*
>>>>>>>>>> *Certified *Google Cloud Data Engineer | *Certified* Apache
>> Spark &
>>>>>>> Neo4j
>>>>>>>>>> Developer
>>>>>>>>>> *LinkedIn*: https://www.linkedin.com/in/kaxil
>>>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>>
>>>>>>>> Kamil Breguła
>>>>>>>> Polidea <https://www.polidea.com/> | Software Engineer
>>>>>>>>
>>>>>>>> M: +48 505 458 451 <+48505458451>
>>>>>>>> E: kamil.bregula@polidea.com
>>>>>>>> [image: Polidea] <https://www.polidea.com/>
>>>>>>>>
>>>>>>>> We create human & business stories through technology.
>>>>>>>> Check out our projects! <https://www.polidea.com/our-work>
>>>>>>>> [image: Github] <https://github.com/Polidea> [image: Facebook]
>>>>>>>> <https://www.facebook.com/Polidea.Software> [image: Twitter]
>>>>>>>> <https://twitter.com/polidea> [image: Linkedin]
>>>>>>>> <https://www.linkedin.com/company/polidea> [image: Instagram]
>>>>>>>> <https://instagram.com/polidea> [image: Behance]
>>>>>>>> <https://www.behance.net/polidea>
>>>
>
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by Chao-Han Tsai <mi...@gmail.com>.
+1 (non-binding)
On Fri, Apr 12, 2019 at 8:05 AM Chen Tong <ci...@gmail.com> wrote:
> +1 (non-binding).
>
> On Fri, Apr 12, 2019 at 9:28 AM Julian De Ruiter <
> julianderuiter@godatadriven.com> wrote:
>
> > I also wouldn’t mind including black for checking formatting.
> >
> > > On 12 Apr 2019, at 15:20, Julian De Ruiter <
> > julianderuiter@godatadriven.com> wrote:
> > >
> > > +1 non-binding
> > >
> > >> On 12 Apr 2019, at 07:25, Maxime Beauchemin <
> maximebeauchemin@gmail.com>
> > wrote:
> > >>
> > >> +1 (binding)
> > >>
> > >> Also check out black to auto-pep8!
> > >> https://github.com/ambv/black
> > >>
> > >> On Thu, Apr 11, 2019 at 5:12 PM Tao Feng <fe...@gmail.com> wrote:
> > >>
> > >>> +1
> > >>>
> > >>> On Thu, Apr 11, 2019 at 4:27 PM Beau Barker <
> beauinmelbourne@gmail.com
> > >
> > >>> wrote:
> > >>>
> > >>>> +1 non binding
> > >>>>
> > >>>> Pylint is extremely strict so your may want to be selective about
> the
> > >>>> rules it applies.
> > >>>>
> > >>>>
> > >>>>> On 12 Apr 2019, at 7:15 am, Kamil Breguła <
> kamil.bregula@polidea.com
> > >
> > >>>> wrote:
> > >>>>>
> > >>>>> +! (non-binding)
> > >>>>>
> > >>>>> On Thu, Apr 11, 2019 at 11:05 PM Driesprong, Fokko
> > >>> <fokko@driesprong.frl
> > >>>>>
> > >>>>> wrote:
> > >>>>>
> > >>>>>> +1 (binding)
> > >>>>>>
> > >>>>>> For more information about AIP-6:
> > >>>>>>
> > >>>>
> > >>>
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=99844429
> > >>>>>>
> > >>>>>> Op do 11 apr. 2019 om 23:03 schreef Kaxil Naik <
> kaxilnaik@gmail.com
> > >:
> > >>>>>>
> > >>>>>>> +1 (binding)
> > >>>>>>>
> > >>>>>>> On Thu, Apr 11, 2019 at 9:51 PM Jarek Potiuk <
> > >>> Jarek.Potiuk@polidea.com
> > >>>>>
> > >>>>>>> wrote:
> > >>>>>>>
> > >>>>>>>> +1 (non-binding).
> > >>>>>>>>
> > >>>>>>>> On Thu, Apr 11, 2019 at 10:50 PM Bas Harenslak <
> > >>>>>>>> basharenslak@godatadriven.com> wrote:
> > >>>>>>>>
> > >>>>>>>>> Hello Airflow community,
> > >>>>>>>>>
> > >>>>>>>>> This email calls for a vote to introduce Pylint in the Airflow
> > >>>>>> project.
> > >>>>>>>>> The vote will last for at least 1 week (April 18th 23:00 CET),
> > and
> > >>> at
> > >>>>>>>> least
> > >>>>>>>>> three +1 (binding) votes have been cast.
> > >>>>>>>>>
> > >>>>>>>>> After feedback on AIP-6 and discussion on Slack<
> > >>>>>>>>>
> > >>>>>>
> > https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400
> > >>>>>>>> ,
> > >>>>>>>> I
> > >>>>>>>>> propose to vote for adding Pylint<https://pylint.org> to the
> > >>> Airflow
> > >>>>>>>>> project for static code checking. Pylint complements Flake8
> with
> > >>>>>>> stricter
> > >>>>>>>>> rules, detects code smells and is customisable so unnecessary
> > >>> checks
> > >>>>>>> can
> > >>>>>>>> be
> > >>>>>>>>> ignored. This should benefit the Airflow code base with
> > consistent,
> > >>>>>>>>> documented code and less errors.
> > >>>>>>>>>
> > >>>>>>>>> Note that Pylint 2.0 works with Python 3 only, so if the vote
> is
> > >>>>>>>>> successful, it should be introduced after dropping support for
> > >>>>>> Python 2
> > >>>>>>>>> (AIRFLOW-4196<
> https://issues.apache.org/jira/browse/AIRFLOW-4196
> > >>>> ).
> > >>>>>>>>> Note2: to keep the scope as small as possible, I’ll create a
> > >>> separate
> > >>>>>>>> vote
> > >>>>>>>>> for Black formatting.
> > >>>>>>>>>
> > >>>>>>>>> Cheers,
> > >>>>>>>>> Bas
> > >>>>>>>>>
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>> --
> > >>>>>>>>
> > >>>>>>>> Jarek Potiuk
> > >>>>>>>> Polidea <https://www.polidea.com/> | Principal Software
> Engineer
> > >>>>>>>>
> > >>>>>>>> M: +48 660 796 129 <+48660796129>
> > >>>>>>>> E: jarek.potiuk@polidea.com
> > >>>>>>>>
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> --
> > >>>>>>> *Kaxil Naik*
> > >>>>>>> *Big Data Consultant *@ *Data Reply UK*
> > >>>>>>> *Certified *Google Cloud Data Engineer | *Certified* Apache
> Spark &
> > >>>> Neo4j
> > >>>>>>> Developer
> > >>>>>>> *LinkedIn*: https://www.linkedin.com/in/kaxil
> > >>>>>>>
> > >>>>>>
> > >>>>>
> > >>>>>
> > >>>>> --
> > >>>>>
> > >>>>> Kamil Breguła
> > >>>>> Polidea <https://www.polidea.com/> | Software Engineer
> > >>>>>
> > >>>>> M: +48 505 458 451 <+48505458451>
> > >>>>> E: kamil.bregula@polidea.com
> > >>>>> [image: Polidea] <https://www.polidea.com/>
> > >>>>>
> > >>>>> We create human & business stories through technology.
> > >>>>> Check out our projects! <https://www.polidea.com/our-work>
> > >>>>> [image: Github] <https://github.com/Polidea> [image: Facebook]
> > >>>>> <https://www.facebook.com/Polidea.Software> [image: Twitter]
> > >>>>> <https://twitter.com/polidea> [image: Linkedin]
> > >>>>> <https://www.linkedin.com/company/polidea> [image: Instagram]
> > >>>>> <https://instagram.com/polidea> [image: Behance]
> > >>>>> <https://www.behance.net/polidea>
> > >>>>
> > >>>
> > >
> >
> >
>
--
Chao-Han Tsai
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by Chen Tong <ci...@gmail.com>.
+1 (non-binding).
On Fri, Apr 12, 2019 at 9:28 AM Julian De Ruiter <
julianderuiter@godatadriven.com> wrote:
> I also wouldn’t mind including black for checking formatting.
>
> > On 12 Apr 2019, at 15:20, Julian De Ruiter <
> julianderuiter@godatadriven.com> wrote:
> >
> > +1 non-binding
> >
> >> On 12 Apr 2019, at 07:25, Maxime Beauchemin <ma...@gmail.com>
> wrote:
> >>
> >> +1 (binding)
> >>
> >> Also check out black to auto-pep8!
> >> https://github.com/ambv/black
> >>
> >> On Thu, Apr 11, 2019 at 5:12 PM Tao Feng <fe...@gmail.com> wrote:
> >>
> >>> +1
> >>>
> >>> On Thu, Apr 11, 2019 at 4:27 PM Beau Barker <beauinmelbourne@gmail.com
> >
> >>> wrote:
> >>>
> >>>> +1 non binding
> >>>>
> >>>> Pylint is extremely strict so your may want to be selective about the
> >>>> rules it applies.
> >>>>
> >>>>
> >>>>> On 12 Apr 2019, at 7:15 am, Kamil Breguła <kamil.bregula@polidea.com
> >
> >>>> wrote:
> >>>>>
> >>>>> +! (non-binding)
> >>>>>
> >>>>> On Thu, Apr 11, 2019 at 11:05 PM Driesprong, Fokko
> >>> <fokko@driesprong.frl
> >>>>>
> >>>>> wrote:
> >>>>>
> >>>>>> +1 (binding)
> >>>>>>
> >>>>>> For more information about AIP-6:
> >>>>>>
> >>>>
> >>>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=99844429
> >>>>>>
> >>>>>> Op do 11 apr. 2019 om 23:03 schreef Kaxil Naik <kaxilnaik@gmail.com
> >:
> >>>>>>
> >>>>>>> +1 (binding)
> >>>>>>>
> >>>>>>> On Thu, Apr 11, 2019 at 9:51 PM Jarek Potiuk <
> >>> Jarek.Potiuk@polidea.com
> >>>>>
> >>>>>>> wrote:
> >>>>>>>
> >>>>>>>> +1 (non-binding).
> >>>>>>>>
> >>>>>>>> On Thu, Apr 11, 2019 at 10:50 PM Bas Harenslak <
> >>>>>>>> basharenslak@godatadriven.com> wrote:
> >>>>>>>>
> >>>>>>>>> Hello Airflow community,
> >>>>>>>>>
> >>>>>>>>> This email calls for a vote to introduce Pylint in the Airflow
> >>>>>> project.
> >>>>>>>>> The vote will last for at least 1 week (April 18th 23:00 CET),
> and
> >>> at
> >>>>>>>> least
> >>>>>>>>> three +1 (binding) votes have been cast.
> >>>>>>>>>
> >>>>>>>>> After feedback on AIP-6 and discussion on Slack<
> >>>>>>>>>
> >>>>>>
> https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400
> >>>>>>>> ,
> >>>>>>>> I
> >>>>>>>>> propose to vote for adding Pylint<https://pylint.org> to the
> >>> Airflow
> >>>>>>>>> project for static code checking. Pylint complements Flake8 with
> >>>>>>> stricter
> >>>>>>>>> rules, detects code smells and is customisable so unnecessary
> >>> checks
> >>>>>>> can
> >>>>>>>> be
> >>>>>>>>> ignored. This should benefit the Airflow code base with
> consistent,
> >>>>>>>>> documented code and less errors.
> >>>>>>>>>
> >>>>>>>>> Note that Pylint 2.0 works with Python 3 only, so if the vote is
> >>>>>>>>> successful, it should be introduced after dropping support for
> >>>>>> Python 2
> >>>>>>>>> (AIRFLOW-4196<https://issues.apache.org/jira/browse/AIRFLOW-4196
> >>>> ).
> >>>>>>>>> Note2: to keep the scope as small as possible, I’ll create a
> >>> separate
> >>>>>>>> vote
> >>>>>>>>> for Black formatting.
> >>>>>>>>>
> >>>>>>>>> Cheers,
> >>>>>>>>> Bas
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>>
> >>>>>>>> Jarek Potiuk
> >>>>>>>> Polidea <https://www.polidea.com/> | Principal Software Engineer
> >>>>>>>>
> >>>>>>>> M: +48 660 796 129 <+48660796129>
> >>>>>>>> E: jarek.potiuk@polidea.com
> >>>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> --
> >>>>>>> *Kaxil Naik*
> >>>>>>> *Big Data Consultant *@ *Data Reply UK*
> >>>>>>> *Certified *Google Cloud Data Engineer | *Certified* Apache Spark &
> >>>> Neo4j
> >>>>>>> Developer
> >>>>>>> *LinkedIn*: https://www.linkedin.com/in/kaxil
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>>
> >>>>> Kamil Breguła
> >>>>> Polidea <https://www.polidea.com/> | Software Engineer
> >>>>>
> >>>>> M: +48 505 458 451 <+48505458451>
> >>>>> E: kamil.bregula@polidea.com
> >>>>> [image: Polidea] <https://www.polidea.com/>
> >>>>>
> >>>>> We create human & business stories through technology.
> >>>>> Check out our projects! <https://www.polidea.com/our-work>
> >>>>> [image: Github] <https://github.com/Polidea> [image: Facebook]
> >>>>> <https://www.facebook.com/Polidea.Software> [image: Twitter]
> >>>>> <https://twitter.com/polidea> [image: Linkedin]
> >>>>> <https://www.linkedin.com/company/polidea> [image: Instagram]
> >>>>> <https://instagram.com/polidea> [image: Behance]
> >>>>> <https://www.behance.net/polidea>
> >>>>
> >>>
> >
>
>
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by Julian De Ruiter <ju...@godatadriven.com>.
I also wouldn’t mind including black for checking formatting.
> On 12 Apr 2019, at 15:20, Julian De Ruiter <ju...@godatadriven.com> wrote:
>
> +1 non-binding
>
>> On 12 Apr 2019, at 07:25, Maxime Beauchemin <ma...@gmail.com> wrote:
>>
>> +1 (binding)
>>
>> Also check out black to auto-pep8!
>> https://github.com/ambv/black
>>
>> On Thu, Apr 11, 2019 at 5:12 PM Tao Feng <fe...@gmail.com> wrote:
>>
>>> +1
>>>
>>> On Thu, Apr 11, 2019 at 4:27 PM Beau Barker <be...@gmail.com>
>>> wrote:
>>>
>>>> +1 non binding
>>>>
>>>> Pylint is extremely strict so your may want to be selective about the
>>>> rules it applies.
>>>>
>>>>
>>>>> On 12 Apr 2019, at 7:15 am, Kamil Breguła <ka...@polidea.com>
>>>> wrote:
>>>>>
>>>>> +! (non-binding)
>>>>>
>>>>> On Thu, Apr 11, 2019 at 11:05 PM Driesprong, Fokko
>>> <fokko@driesprong.frl
>>>>>
>>>>> wrote:
>>>>>
>>>>>> +1 (binding)
>>>>>>
>>>>>> For more information about AIP-6:
>>>>>>
>>>>
>>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=99844429
>>>>>>
>>>>>> Op do 11 apr. 2019 om 23:03 schreef Kaxil Naik <ka...@gmail.com>:
>>>>>>
>>>>>>> +1 (binding)
>>>>>>>
>>>>>>> On Thu, Apr 11, 2019 at 9:51 PM Jarek Potiuk <
>>> Jarek.Potiuk@polidea.com
>>>>>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> +1 (non-binding).
>>>>>>>>
>>>>>>>> On Thu, Apr 11, 2019 at 10:50 PM Bas Harenslak <
>>>>>>>> basharenslak@godatadriven.com> wrote:
>>>>>>>>
>>>>>>>>> Hello Airflow community,
>>>>>>>>>
>>>>>>>>> This email calls for a vote to introduce Pylint in the Airflow
>>>>>> project.
>>>>>>>>> The vote will last for at least 1 week (April 18th 23:00 CET), and
>>> at
>>>>>>>> least
>>>>>>>>> three +1 (binding) votes have been cast.
>>>>>>>>>
>>>>>>>>> After feedback on AIP-6 and discussion on Slack<
>>>>>>>>>
>>>>>> https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400
>>>>>>>> ,
>>>>>>>> I
>>>>>>>>> propose to vote for adding Pylint<https://pylint.org> to the
>>> Airflow
>>>>>>>>> project for static code checking. Pylint complements Flake8 with
>>>>>>> stricter
>>>>>>>>> rules, detects code smells and is customisable so unnecessary
>>> checks
>>>>>>> can
>>>>>>>> be
>>>>>>>>> ignored. This should benefit the Airflow code base with consistent,
>>>>>>>>> documented code and less errors.
>>>>>>>>>
>>>>>>>>> Note that Pylint 2.0 works with Python 3 only, so if the vote is
>>>>>>>>> successful, it should be introduced after dropping support for
>>>>>> Python 2
>>>>>>>>> (AIRFLOW-4196<https://issues.apache.org/jira/browse/AIRFLOW-4196
>>>> ).
>>>>>>>>> Note2: to keep the scope as small as possible, I’ll create a
>>> separate
>>>>>>>> vote
>>>>>>>>> for Black formatting.
>>>>>>>>>
>>>>>>>>> Cheers,
>>>>>>>>> Bas
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>>
>>>>>>>> Jarek Potiuk
>>>>>>>> Polidea <https://www.polidea.com/> | Principal Software Engineer
>>>>>>>>
>>>>>>>> M: +48 660 796 129 <+48660796129>
>>>>>>>> E: jarek.potiuk@polidea.com
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> *Kaxil Naik*
>>>>>>> *Big Data Consultant *@ *Data Reply UK*
>>>>>>> *Certified *Google Cloud Data Engineer | *Certified* Apache Spark &
>>>> Neo4j
>>>>>>> Developer
>>>>>>> *LinkedIn*: https://www.linkedin.com/in/kaxil
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> Kamil Breguła
>>>>> Polidea <https://www.polidea.com/> | Software Engineer
>>>>>
>>>>> M: +48 505 458 451 <+48505458451>
>>>>> E: kamil.bregula@polidea.com
>>>>> [image: Polidea] <https://www.polidea.com/>
>>>>>
>>>>> We create human & business stories through technology.
>>>>> Check out our projects! <https://www.polidea.com/our-work>
>>>>> [image: Github] <https://github.com/Polidea> [image: Facebook]
>>>>> <https://www.facebook.com/Polidea.Software> [image: Twitter]
>>>>> <https://twitter.com/polidea> [image: Linkedin]
>>>>> <https://www.linkedin.com/company/polidea> [image: Instagram]
>>>>> <https://instagram.com/polidea> [image: Behance]
>>>>> <https://www.behance.net/polidea>
>>>>
>>>
>
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by Julian De Ruiter <ju...@godatadriven.com>.
+1 non-binding
> On 12 Apr 2019, at 07:25, Maxime Beauchemin <ma...@gmail.com> wrote:
>
> +1 (binding)
>
> Also check out black to auto-pep8!
> https://github.com/ambv/black
>
> On Thu, Apr 11, 2019 at 5:12 PM Tao Feng <fe...@gmail.com> wrote:
>
>> +1
>>
>> On Thu, Apr 11, 2019 at 4:27 PM Beau Barker <be...@gmail.com>
>> wrote:
>>
>>> +1 non binding
>>>
>>> Pylint is extremely strict so your may want to be selective about the
>>> rules it applies.
>>>
>>>
>>>> On 12 Apr 2019, at 7:15 am, Kamil Breguła <ka...@polidea.com>
>>> wrote:
>>>>
>>>> +! (non-binding)
>>>>
>>>> On Thu, Apr 11, 2019 at 11:05 PM Driesprong, Fokko
>> <fokko@driesprong.frl
>>>>
>>>> wrote:
>>>>
>>>>> +1 (binding)
>>>>>
>>>>> For more information about AIP-6:
>>>>>
>>>
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=99844429
>>>>>
>>>>> Op do 11 apr. 2019 om 23:03 schreef Kaxil Naik <ka...@gmail.com>:
>>>>>
>>>>>> +1 (binding)
>>>>>>
>>>>>> On Thu, Apr 11, 2019 at 9:51 PM Jarek Potiuk <
>> Jarek.Potiuk@polidea.com
>>>>
>>>>>> wrote:
>>>>>>
>>>>>>> +1 (non-binding).
>>>>>>>
>>>>>>> On Thu, Apr 11, 2019 at 10:50 PM Bas Harenslak <
>>>>>>> basharenslak@godatadriven.com> wrote:
>>>>>>>
>>>>>>>> Hello Airflow community,
>>>>>>>>
>>>>>>>> This email calls for a vote to introduce Pylint in the Airflow
>>>>> project.
>>>>>>>> The vote will last for at least 1 week (April 18th 23:00 CET), and
>> at
>>>>>>> least
>>>>>>>> three +1 (binding) votes have been cast.
>>>>>>>>
>>>>>>>> After feedback on AIP-6 and discussion on Slack<
>>>>>>>>
>>>>> https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400
>>>>>>> ,
>>>>>>> I
>>>>>>>> propose to vote for adding Pylint<https://pylint.org> to the
>> Airflow
>>>>>>>> project for static code checking. Pylint complements Flake8 with
>>>>>> stricter
>>>>>>>> rules, detects code smells and is customisable so unnecessary
>> checks
>>>>>> can
>>>>>>> be
>>>>>>>> ignored. This should benefit the Airflow code base with consistent,
>>>>>>>> documented code and less errors.
>>>>>>>>
>>>>>>>> Note that Pylint 2.0 works with Python 3 only, so if the vote is
>>>>>>>> successful, it should be introduced after dropping support for
>>>>> Python 2
>>>>>>>> (AIRFLOW-4196<https://issues.apache.org/jira/browse/AIRFLOW-4196
>>> ).
>>>>>>>> Note2: to keep the scope as small as possible, I’ll create a
>> separate
>>>>>>> vote
>>>>>>>> for Black formatting.
>>>>>>>>
>>>>>>>> Cheers,
>>>>>>>> Bas
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>>
>>>>>>> Jarek Potiuk
>>>>>>> Polidea <https://www.polidea.com/> | Principal Software Engineer
>>>>>>>
>>>>>>> M: +48 660 796 129 <+48660796129>
>>>>>>> E: jarek.potiuk@polidea.com
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> *Kaxil Naik*
>>>>>> *Big Data Consultant *@ *Data Reply UK*
>>>>>> *Certified *Google Cloud Data Engineer | *Certified* Apache Spark &
>>> Neo4j
>>>>>> Developer
>>>>>> *LinkedIn*: https://www.linkedin.com/in/kaxil
>>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> Kamil Breguła
>>>> Polidea <https://www.polidea.com/> | Software Engineer
>>>>
>>>> M: +48 505 458 451 <+48505458451>
>>>> E: kamil.bregula@polidea.com
>>>> [image: Polidea] <https://www.polidea.com/>
>>>>
>>>> We create human & business stories through technology.
>>>> Check out our projects! <https://www.polidea.com/our-work>
>>>> [image: Github] <https://github.com/Polidea> [image: Facebook]
>>>> <https://www.facebook.com/Polidea.Software> [image: Twitter]
>>>> <https://twitter.com/polidea> [image: Linkedin]
>>>> <https://www.linkedin.com/company/polidea> [image: Instagram]
>>>> <https://instagram.com/polidea> [image: Behance]
>>>> <https://www.behance.net/polidea>
>>>
>>
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by Maxime Beauchemin <ma...@gmail.com>.
+1 (binding)
Also check out black to auto-pep8!
https://github.com/ambv/black
On Thu, Apr 11, 2019 at 5:12 PM Tao Feng <fe...@gmail.com> wrote:
> +1
>
> On Thu, Apr 11, 2019 at 4:27 PM Beau Barker <be...@gmail.com>
> wrote:
>
> > +1 non binding
> >
> > Pylint is extremely strict so your may want to be selective about the
> > rules it applies.
> >
> >
> > > On 12 Apr 2019, at 7:15 am, Kamil Breguła <ka...@polidea.com>
> > wrote:
> > >
> > > +! (non-binding)
> > >
> > > On Thu, Apr 11, 2019 at 11:05 PM Driesprong, Fokko
> <fokko@driesprong.frl
> > >
> > > wrote:
> > >
> > >> +1 (binding)
> > >>
> > >> For more information about AIP-6:
> > >>
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=99844429
> > >>
> > >> Op do 11 apr. 2019 om 23:03 schreef Kaxil Naik <ka...@gmail.com>:
> > >>
> > >>> +1 (binding)
> > >>>
> > >>> On Thu, Apr 11, 2019 at 9:51 PM Jarek Potiuk <
> Jarek.Potiuk@polidea.com
> > >
> > >>> wrote:
> > >>>
> > >>>> +1 (non-binding).
> > >>>>
> > >>>> On Thu, Apr 11, 2019 at 10:50 PM Bas Harenslak <
> > >>>> basharenslak@godatadriven.com> wrote:
> > >>>>
> > >>>>> Hello Airflow community,
> > >>>>>
> > >>>>> This email calls for a vote to introduce Pylint in the Airflow
> > >> project.
> > >>>>> The vote will last for at least 1 week (April 18th 23:00 CET), and
> at
> > >>>> least
> > >>>>> three +1 (binding) votes have been cast.
> > >>>>>
> > >>>>> After feedback on AIP-6 and discussion on Slack<
> > >>>>>
> > >> https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400
> > >>>> ,
> > >>>> I
> > >>>>> propose to vote for adding Pylint<https://pylint.org> to the
> Airflow
> > >>>>> project for static code checking. Pylint complements Flake8 with
> > >>> stricter
> > >>>>> rules, detects code smells and is customisable so unnecessary
> checks
> > >>> can
> > >>>> be
> > >>>>> ignored. This should benefit the Airflow code base with consistent,
> > >>>>> documented code and less errors.
> > >>>>>
> > >>>>> Note that Pylint 2.0 works with Python 3 only, so if the vote is
> > >>>>> successful, it should be introduced after dropping support for
> > >> Python 2
> > >>>>> (AIRFLOW-4196<https://issues.apache.org/jira/browse/AIRFLOW-4196
> >).
> > >>>>> Note2: to keep the scope as small as possible, I’ll create a
> separate
> > >>>> vote
> > >>>>> for Black formatting.
> > >>>>>
> > >>>>> Cheers,
> > >>>>> Bas
> > >>>>>
> > >>>>
> > >>>>
> > >>>> --
> > >>>>
> > >>>> Jarek Potiuk
> > >>>> Polidea <https://www.polidea.com/> | Principal Software Engineer
> > >>>>
> > >>>> M: +48 660 796 129 <+48660796129>
> > >>>> E: jarek.potiuk@polidea.com
> > >>>>
> > >>>
> > >>>
> > >>> --
> > >>> *Kaxil Naik*
> > >>> *Big Data Consultant *@ *Data Reply UK*
> > >>> *Certified *Google Cloud Data Engineer | *Certified* Apache Spark &
> > Neo4j
> > >>> Developer
> > >>> *LinkedIn*: https://www.linkedin.com/in/kaxil
> > >>>
> > >>
> > >
> > >
> > > --
> > >
> > > Kamil Breguła
> > > Polidea <https://www.polidea.com/> | Software Engineer
> > >
> > > M: +48 505 458 451 <+48505458451>
> > > E: kamil.bregula@polidea.com
> > > [image: Polidea] <https://www.polidea.com/>
> > >
> > > We create human & business stories through technology.
> > > Check out our projects! <https://www.polidea.com/our-work>
> > > [image: Github] <https://github.com/Polidea> [image: Facebook]
> > > <https://www.facebook.com/Polidea.Software> [image: Twitter]
> > > <https://twitter.com/polidea> [image: Linkedin]
> > > <https://www.linkedin.com/company/polidea> [image: Instagram]
> > > <https://instagram.com/polidea> [image: Behance]
> > > <https://www.behance.net/polidea>
> >
>
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by Tao Feng <fe...@gmail.com>.
+1
On Thu, Apr 11, 2019 at 4:27 PM Beau Barker <be...@gmail.com>
wrote:
> +1 non binding
>
> Pylint is extremely strict so your may want to be selective about the
> rules it applies.
>
>
> > On 12 Apr 2019, at 7:15 am, Kamil Breguła <ka...@polidea.com>
> wrote:
> >
> > +! (non-binding)
> >
> > On Thu, Apr 11, 2019 at 11:05 PM Driesprong, Fokko <fokko@driesprong.frl
> >
> > wrote:
> >
> >> +1 (binding)
> >>
> >> For more information about AIP-6:
> >>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=99844429
> >>
> >> Op do 11 apr. 2019 om 23:03 schreef Kaxil Naik <ka...@gmail.com>:
> >>
> >>> +1 (binding)
> >>>
> >>> On Thu, Apr 11, 2019 at 9:51 PM Jarek Potiuk <Jarek.Potiuk@polidea.com
> >
> >>> wrote:
> >>>
> >>>> +1 (non-binding).
> >>>>
> >>>> On Thu, Apr 11, 2019 at 10:50 PM Bas Harenslak <
> >>>> basharenslak@godatadriven.com> wrote:
> >>>>
> >>>>> Hello Airflow community,
> >>>>>
> >>>>> This email calls for a vote to introduce Pylint in the Airflow
> >> project.
> >>>>> The vote will last for at least 1 week (April 18th 23:00 CET), and at
> >>>> least
> >>>>> three +1 (binding) votes have been cast.
> >>>>>
> >>>>> After feedback on AIP-6 and discussion on Slack<
> >>>>>
> >> https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400
> >>>> ,
> >>>> I
> >>>>> propose to vote for adding Pylint<https://pylint.org> to the Airflow
> >>>>> project for static code checking. Pylint complements Flake8 with
> >>> stricter
> >>>>> rules, detects code smells and is customisable so unnecessary checks
> >>> can
> >>>> be
> >>>>> ignored. This should benefit the Airflow code base with consistent,
> >>>>> documented code and less errors.
> >>>>>
> >>>>> Note that Pylint 2.0 works with Python 3 only, so if the vote is
> >>>>> successful, it should be introduced after dropping support for
> >> Python 2
> >>>>> (AIRFLOW-4196<https://issues.apache.org/jira/browse/AIRFLOW-4196>).
> >>>>> Note2: to keep the scope as small as possible, I’ll create a separate
> >>>> vote
> >>>>> for Black formatting.
> >>>>>
> >>>>> Cheers,
> >>>>> Bas
> >>>>>
> >>>>
> >>>>
> >>>> --
> >>>>
> >>>> Jarek Potiuk
> >>>> Polidea <https://www.polidea.com/> | Principal Software Engineer
> >>>>
> >>>> M: +48 660 796 129 <+48660796129>
> >>>> E: jarek.potiuk@polidea.com
> >>>>
> >>>
> >>>
> >>> --
> >>> *Kaxil Naik*
> >>> *Big Data Consultant *@ *Data Reply UK*
> >>> *Certified *Google Cloud Data Engineer | *Certified* Apache Spark &
> Neo4j
> >>> Developer
> >>> *LinkedIn*: https://www.linkedin.com/in/kaxil
> >>>
> >>
> >
> >
> > --
> >
> > Kamil Breguła
> > Polidea <https://www.polidea.com/> | Software Engineer
> >
> > M: +48 505 458 451 <+48505458451>
> > E: kamil.bregula@polidea.com
> > [image: Polidea] <https://www.polidea.com/>
> >
> > We create human & business stories through technology.
> > Check out our projects! <https://www.polidea.com/our-work>
> > [image: Github] <https://github.com/Polidea> [image: Facebook]
> > <https://www.facebook.com/Polidea.Software> [image: Twitter]
> > <https://twitter.com/polidea> [image: Linkedin]
> > <https://www.linkedin.com/company/polidea> [image: Instagram]
> > <https://instagram.com/polidea> [image: Behance]
> > <https://www.behance.net/polidea>
>
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by Beau Barker <be...@gmail.com>.
+1 non binding
Pylint is extremely strict so your may want to be selective about the rules it applies.
> On 12 Apr 2019, at 7:15 am, Kamil Breguła <ka...@polidea.com> wrote:
>
> +! (non-binding)
>
> On Thu, Apr 11, 2019 at 11:05 PM Driesprong, Fokko <fo...@driesprong.frl>
> wrote:
>
>> +1 (binding)
>>
>> For more information about AIP-6:
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=99844429
>>
>> Op do 11 apr. 2019 om 23:03 schreef Kaxil Naik <ka...@gmail.com>:
>>
>>> +1 (binding)
>>>
>>> On Thu, Apr 11, 2019 at 9:51 PM Jarek Potiuk <Ja...@polidea.com>
>>> wrote:
>>>
>>>> +1 (non-binding).
>>>>
>>>> On Thu, Apr 11, 2019 at 10:50 PM Bas Harenslak <
>>>> basharenslak@godatadriven.com> wrote:
>>>>
>>>>> Hello Airflow community,
>>>>>
>>>>> This email calls for a vote to introduce Pylint in the Airflow
>> project.
>>>>> The vote will last for at least 1 week (April 18th 23:00 CET), and at
>>>> least
>>>>> three +1 (binding) votes have been cast.
>>>>>
>>>>> After feedback on AIP-6 and discussion on Slack<
>>>>>
>> https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400
>>>> ,
>>>> I
>>>>> propose to vote for adding Pylint<https://pylint.org> to the Airflow
>>>>> project for static code checking. Pylint complements Flake8 with
>>> stricter
>>>>> rules, detects code smells and is customisable so unnecessary checks
>>> can
>>>> be
>>>>> ignored. This should benefit the Airflow code base with consistent,
>>>>> documented code and less errors.
>>>>>
>>>>> Note that Pylint 2.0 works with Python 3 only, so if the vote is
>>>>> successful, it should be introduced after dropping support for
>> Python 2
>>>>> (AIRFLOW-4196<https://issues.apache.org/jira/browse/AIRFLOW-4196>).
>>>>> Note2: to keep the scope as small as possible, I’ll create a separate
>>>> vote
>>>>> for Black formatting.
>>>>>
>>>>> Cheers,
>>>>> Bas
>>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> Jarek Potiuk
>>>> Polidea <https://www.polidea.com/> | Principal Software Engineer
>>>>
>>>> M: +48 660 796 129 <+48660796129>
>>>> E: jarek.potiuk@polidea.com
>>>>
>>>
>>>
>>> --
>>> *Kaxil Naik*
>>> *Big Data Consultant *@ *Data Reply UK*
>>> *Certified *Google Cloud Data Engineer | *Certified* Apache Spark & Neo4j
>>> Developer
>>> *LinkedIn*: https://www.linkedin.com/in/kaxil
>>>
>>
>
>
> --
>
> Kamil Breguła
> Polidea <https://www.polidea.com/> | Software Engineer
>
> M: +48 505 458 451 <+48505458451>
> E: kamil.bregula@polidea.com
> [image: Polidea] <https://www.polidea.com/>
>
> We create human & business stories through technology.
> Check out our projects! <https://www.polidea.com/our-work>
> [image: Github] <https://github.com/Polidea> [image: Facebook]
> <https://www.facebook.com/Polidea.Software> [image: Twitter]
> <https://twitter.com/polidea> [image: Linkedin]
> <https://www.linkedin.com/company/polidea> [image: Instagram]
> <https://instagram.com/polidea> [image: Behance]
> <https://www.behance.net/polidea>
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by Kamil Breguła <ka...@polidea.com>.
+! (non-binding)
On Thu, Apr 11, 2019 at 11:05 PM Driesprong, Fokko <fo...@driesprong.frl>
wrote:
> +1 (binding)
>
> For more information about AIP-6:
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=99844429
>
> Op do 11 apr. 2019 om 23:03 schreef Kaxil Naik <ka...@gmail.com>:
>
> > +1 (binding)
> >
> > On Thu, Apr 11, 2019 at 9:51 PM Jarek Potiuk <Ja...@polidea.com>
> > wrote:
> >
> > > +1 (non-binding).
> > >
> > > On Thu, Apr 11, 2019 at 10:50 PM Bas Harenslak <
> > > basharenslak@godatadriven.com> wrote:
> > >
> > > > Hello Airflow community,
> > > >
> > > > This email calls for a vote to introduce Pylint in the Airflow
> project.
> > > > The vote will last for at least 1 week (April 18th 23:00 CET), and at
> > > least
> > > > three +1 (binding) votes have been cast.
> > > >
> > > > After feedback on AIP-6 and discussion on Slack<
> > > >
> https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400
> > >,
> > > I
> > > > propose to vote for adding Pylint<https://pylint.org> to the Airflow
> > > > project for static code checking. Pylint complements Flake8 with
> > stricter
> > > > rules, detects code smells and is customisable so unnecessary checks
> > can
> > > be
> > > > ignored. This should benefit the Airflow code base with consistent,
> > > > documented code and less errors.
> > > >
> > > > Note that Pylint 2.0 works with Python 3 only, so if the vote is
> > > > successful, it should be introduced after dropping support for
> Python 2
> > > > (AIRFLOW-4196<https://issues.apache.org/jira/browse/AIRFLOW-4196>).
> > > > Note2: to keep the scope as small as possible, I’ll create a separate
> > > vote
> > > > for Black formatting.
> > > >
> > > > Cheers,
> > > > Bas
> > > >
> > >
> > >
> > > --
> > >
> > > Jarek Potiuk
> > > Polidea <https://www.polidea.com/> | Principal Software Engineer
> > >
> > > M: +48 660 796 129 <+48660796129>
> > > E: jarek.potiuk@polidea.com
> > >
> >
> >
> > --
> > *Kaxil Naik*
> > *Big Data Consultant *@ *Data Reply UK*
> > *Certified *Google Cloud Data Engineer | *Certified* Apache Spark & Neo4j
> > Developer
> > *LinkedIn*: https://www.linkedin.com/in/kaxil
> >
>
--
Kamil Breguła
Polidea <https://www.polidea.com/> | Software Engineer
M: +48 505 458 451 <+48505458451>
E: kamil.bregula@polidea.com
[image: Polidea] <https://www.polidea.com/>
We create human & business stories through technology.
Check out our projects! <https://www.polidea.com/our-work>
[image: Github] <https://github.com/Polidea> [image: Facebook]
<https://www.facebook.com/Polidea.Software> [image: Twitter]
<https://twitter.com/polidea> [image: Linkedin]
<https://www.linkedin.com/company/polidea> [image: Instagram]
<https://instagram.com/polidea> [image: Behance]
<https://www.behance.net/polidea>
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by "Driesprong, Fokko" <fo...@driesprong.frl>.
+1 (binding)
For more information about AIP-6:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=99844429
Op do 11 apr. 2019 om 23:03 schreef Kaxil Naik <ka...@gmail.com>:
> +1 (binding)
>
> On Thu, Apr 11, 2019 at 9:51 PM Jarek Potiuk <Ja...@polidea.com>
> wrote:
>
> > +1 (non-binding).
> >
> > On Thu, Apr 11, 2019 at 10:50 PM Bas Harenslak <
> > basharenslak@godatadriven.com> wrote:
> >
> > > Hello Airflow community,
> > >
> > > This email calls for a vote to introduce Pylint in the Airflow project.
> > > The vote will last for at least 1 week (April 18th 23:00 CET), and at
> > least
> > > three +1 (binding) votes have been cast.
> > >
> > > After feedback on AIP-6 and discussion on Slack<
> > > https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400
> >,
> > I
> > > propose to vote for adding Pylint<https://pylint.org> to the Airflow
> > > project for static code checking. Pylint complements Flake8 with
> stricter
> > > rules, detects code smells and is customisable so unnecessary checks
> can
> > be
> > > ignored. This should benefit the Airflow code base with consistent,
> > > documented code and less errors.
> > >
> > > Note that Pylint 2.0 works with Python 3 only, so if the vote is
> > > successful, it should be introduced after dropping support for Python 2
> > > (AIRFLOW-4196<https://issues.apache.org/jira/browse/AIRFLOW-4196>).
> > > Note2: to keep the scope as small as possible, I’ll create a separate
> > vote
> > > for Black formatting.
> > >
> > > Cheers,
> > > Bas
> > >
> >
> >
> > --
> >
> > Jarek Potiuk
> > Polidea <https://www.polidea.com/> | Principal Software Engineer
> >
> > M: +48 660 796 129 <+48660796129>
> > E: jarek.potiuk@polidea.com
> >
>
>
> --
> *Kaxil Naik*
> *Big Data Consultant *@ *Data Reply UK*
> *Certified *Google Cloud Data Engineer | *Certified* Apache Spark & Neo4j
> Developer
> *LinkedIn*: https://www.linkedin.com/in/kaxil
>
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by Kaxil Naik <ka...@gmail.com>.
+1 (binding)
On Thu, Apr 11, 2019 at 9:51 PM Jarek Potiuk <Ja...@polidea.com>
wrote:
> +1 (non-binding).
>
> On Thu, Apr 11, 2019 at 10:50 PM Bas Harenslak <
> basharenslak@godatadriven.com> wrote:
>
> > Hello Airflow community,
> >
> > This email calls for a vote to introduce Pylint in the Airflow project.
> > The vote will last for at least 1 week (April 18th 23:00 CET), and at
> least
> > three +1 (binding) votes have been cast.
> >
> > After feedback on AIP-6 and discussion on Slack<
> > https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400>,
> I
> > propose to vote for adding Pylint<https://pylint.org> to the Airflow
> > project for static code checking. Pylint complements Flake8 with stricter
> > rules, detects code smells and is customisable so unnecessary checks can
> be
> > ignored. This should benefit the Airflow code base with consistent,
> > documented code and less errors.
> >
> > Note that Pylint 2.0 works with Python 3 only, so if the vote is
> > successful, it should be introduced after dropping support for Python 2
> > (AIRFLOW-4196<https://issues.apache.org/jira/browse/AIRFLOW-4196>).
> > Note2: to keep the scope as small as possible, I’ll create a separate
> vote
> > for Black formatting.
> >
> > Cheers,
> > Bas
> >
>
>
> --
>
> Jarek Potiuk
> Polidea <https://www.polidea.com/> | Principal Software Engineer
>
> M: +48 660 796 129 <+48660796129>
> E: jarek.potiuk@polidea.com
>
--
*Kaxil Naik*
*Big Data Consultant *@ *Data Reply UK*
*Certified *Google Cloud Data Engineer | *Certified* Apache Spark & Neo4j
Developer
*LinkedIn*: https://www.linkedin.com/in/kaxil
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by Jarek Potiuk <Ja...@polidea.com>.
+1 (non-binding).
On Thu, Apr 11, 2019 at 10:50 PM Bas Harenslak <
basharenslak@godatadriven.com> wrote:
> Hello Airflow community,
>
> This email calls for a vote to introduce Pylint in the Airflow project.
> The vote will last for at least 1 week (April 18th 23:00 CET), and at least
> three +1 (binding) votes have been cast.
>
> After feedback on AIP-6 and discussion on Slack<
> https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400>, I
> propose to vote for adding Pylint<https://pylint.org> to the Airflow
> project for static code checking. Pylint complements Flake8 with stricter
> rules, detects code smells and is customisable so unnecessary checks can be
> ignored. This should benefit the Airflow code base with consistent,
> documented code and less errors.
>
> Note that Pylint 2.0 works with Python 3 only, so if the vote is
> successful, it should be introduced after dropping support for Python 2
> (AIRFLOW-4196<https://issues.apache.org/jira/browse/AIRFLOW-4196>).
> Note2: to keep the scope as small as possible, I’ll create a separate vote
> for Black formatting.
>
> Cheers,
> Bas
>
--
Jarek Potiuk
Polidea <https://www.polidea.com/> | Principal Software Engineer
M: +48 660 796 129 <+48660796129>
E: jarek.potiuk@polidea.com
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by .
Right - 100% agree on black or flake8. My email prior should have said "finding settings that aren't overly strict but still contribute is extremely difficult *with pylint*"
On 2019/04/15 19:21:02, Maxime Beauchemin <ma...@gmail.com> wrote:
> pylint and black are super solid, no questions there afaic
>
> Max
>
> On Mon, Apr 15, 2019 at 11:48 AM m@maximilianroos.com <m...@maximilianroos.com>
> wrote:
>
> > Hi there,
> >
> > I haven't been active in the airflow community so this should be weighed
> > appropriately.
> >
> > I'm a core dev of a couple of other libraries (xarray, pandas-gbq) and
> > have led initiatives to clean up the code in both of those.
> >
> > While I'm very enthusiastic about auto-formatting tools, my experience is
> > that finding settings that aren't overly strict but still contribute is
> > extremely difficult. Have people worked on large projects with pylint?
> >
> > I thought the recent thread around improving the contribution process was
> > insightful. Auto-enforcing coding standards can be v helpful for both new
> > contributors and reviewers, but a bad tool makes that harder, particularly
> > for new contributors who aren't used to them.
> >
> > Ofc, if someone knows of large projects that successfully use pylint, I'd
> > appreciate learning that my view of the tool is wrong!
> >
> > Thanks for everyone's hard work,
> > Max
> >
> > On 2019/04/11 20:50:01, Bas Harenslak <ba...@godatadriven.com>
> > wrote:
> > > Hello Airflow community,
> > >
> > > This email calls for a vote to introduce Pylint in the Airflow project.
> > The vote will last for at least 1 week (April 18th 23:00 CET), and at least
> > three +1 (binding) votes have been cast.
> > >
> > > After feedback on AIP-6 and discussion on Slack<
> > https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400>, I
> > propose to vote for adding Pylint<https://pylint.org> to the Airflow
> > project for static code checking. Pylint complements Flake8 with stricter
> > rules, detects code smells and is customisable so unnecessary checks can be
> > ignored. This should benefit the Airflow code base with consistent,
> > documented code and less errors.
> > >
> > > Note that Pylint 2.0 works with Python 3 only, so if the vote is
> > successful, it should be introduced after dropping support for Python 2
> > (AIRFLOW-4196<https://issues.apache.org/jira/browse/AIRFLOW-4196>).
> > > Note2: to keep the scope as small as possible, I’ll create a separate
> > vote for Black formatting.
> > >
> > > Cheers,
> > > Bas
> > >
> >
>
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by Bas Harenslak <ba...@godatadriven.com>.
Success! The vote has passed 1 week now and the numbers are:
+1: 5x binding, 7x non-binding
I’ll create JIRA issues to get started.
Bas
> On 15 Apr 2019, at 22:06, Daniel Imberman <di...@gmail.com> wrote:
>
> +1 (binding)
>
> On Mon, Apr 15, 2019 at 12:29 PM Maxime Beauchemin <
> maximebeauchemin@gmail.com> wrote:
>
>> pylint and black are super solid, no questions there afaic
>>
>> Max
>>
>> On Mon, Apr 15, 2019 at 11:48 AM m@maximilianroos.com <
>> m@maximilianroos.com>
>> wrote:
>>
>>> Hi there,
>>>
>>> I haven't been active in the airflow community so this should be weighed
>>> appropriately.
>>>
>>> I'm a core dev of a couple of other libraries (xarray, pandas-gbq) and
>>> have led initiatives to clean up the code in both of those.
>>>
>>> While I'm very enthusiastic about auto-formatting tools, my experience is
>>> that finding settings that aren't overly strict but still contribute is
>>> extremely difficult. Have people worked on large projects with pylint?
>>>
>>> I thought the recent thread around improving the contribution process was
>>> insightful. Auto-enforcing coding standards can be v helpful for both new
>>> contributors and reviewers, but a bad tool makes that harder,
>> particularly
>>> for new contributors who aren't used to them.
>>>
>>> Ofc, if someone knows of large projects that successfully use pylint, I'd
>>> appreciate learning that my view of the tool is wrong!
>>>
>>> Thanks for everyone's hard work,
>>> Max
>>>
>>> On 2019/04/11 20:50:01, Bas Harenslak <ba...@godatadriven.com>
>>> wrote:
>>>> Hello Airflow community,
>>>>
>>>> This email calls for a vote to introduce Pylint in the Airflow project.
>>> The vote will last for at least 1 week (April 18th 23:00 CET), and at
>> least
>>> three +1 (binding) votes have been cast.
>>>>
>>>> After feedback on AIP-6 and discussion on Slack<
>>> https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400>,
>> I
>>> propose to vote for adding Pylint<https://pylint.org> to the Airflow
>>> project for static code checking. Pylint complements Flake8 with stricter
>>> rules, detects code smells and is customisable so unnecessary checks can
>> be
>>> ignored. This should benefit the Airflow code base with consistent,
>>> documented code and less errors.
>>>>
>>>> Note that Pylint 2.0 works with Python 3 only, so if the vote is
>>> successful, it should be introduced after dropping support for Python 2
>>> (AIRFLOW-4196<https://issues.apache.org/jira/browse/AIRFLOW-4196>).
>>>> Note2: to keep the scope as small as possible, I’ll create a separate
>>> vote for Black formatting.
>>>>
>>>> Cheers,
>>>> Bas
>>>>
>>>
>>
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by Daniel Imberman <di...@gmail.com>.
+1 (binding)
On Mon, Apr 15, 2019 at 12:29 PM Maxime Beauchemin <
maximebeauchemin@gmail.com> wrote:
> pylint and black are super solid, no questions there afaic
>
> Max
>
> On Mon, Apr 15, 2019 at 11:48 AM m@maximilianroos.com <
> m@maximilianroos.com>
> wrote:
>
> > Hi there,
> >
> > I haven't been active in the airflow community so this should be weighed
> > appropriately.
> >
> > I'm a core dev of a couple of other libraries (xarray, pandas-gbq) and
> > have led initiatives to clean up the code in both of those.
> >
> > While I'm very enthusiastic about auto-formatting tools, my experience is
> > that finding settings that aren't overly strict but still contribute is
> > extremely difficult. Have people worked on large projects with pylint?
> >
> > I thought the recent thread around improving the contribution process was
> > insightful. Auto-enforcing coding standards can be v helpful for both new
> > contributors and reviewers, but a bad tool makes that harder,
> particularly
> > for new contributors who aren't used to them.
> >
> > Ofc, if someone knows of large projects that successfully use pylint, I'd
> > appreciate learning that my view of the tool is wrong!
> >
> > Thanks for everyone's hard work,
> > Max
> >
> > On 2019/04/11 20:50:01, Bas Harenslak <ba...@godatadriven.com>
> > wrote:
> > > Hello Airflow community,
> > >
> > > This email calls for a vote to introduce Pylint in the Airflow project.
> > The vote will last for at least 1 week (April 18th 23:00 CET), and at
> least
> > three +1 (binding) votes have been cast.
> > >
> > > After feedback on AIP-6 and discussion on Slack<
> > https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400>,
> I
> > propose to vote for adding Pylint<https://pylint.org> to the Airflow
> > project for static code checking. Pylint complements Flake8 with stricter
> > rules, detects code smells and is customisable so unnecessary checks can
> be
> > ignored. This should benefit the Airflow code base with consistent,
> > documented code and less errors.
> > >
> > > Note that Pylint 2.0 works with Python 3 only, so if the vote is
> > successful, it should be introduced after dropping support for Python 2
> > (AIRFLOW-4196<https://issues.apache.org/jira/browse/AIRFLOW-4196>).
> > > Note2: to keep the scope as small as possible, I’ll create a separate
> > vote for Black formatting.
> > >
> > > Cheers,
> > > Bas
> > >
> >
>
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by Maxime Beauchemin <ma...@gmail.com>.
pylint and black are super solid, no questions there afaic
Max
On Mon, Apr 15, 2019 at 11:48 AM m@maximilianroos.com <m...@maximilianroos.com>
wrote:
> Hi there,
>
> I haven't been active in the airflow community so this should be weighed
> appropriately.
>
> I'm a core dev of a couple of other libraries (xarray, pandas-gbq) and
> have led initiatives to clean up the code in both of those.
>
> While I'm very enthusiastic about auto-formatting tools, my experience is
> that finding settings that aren't overly strict but still contribute is
> extremely difficult. Have people worked on large projects with pylint?
>
> I thought the recent thread around improving the contribution process was
> insightful. Auto-enforcing coding standards can be v helpful for both new
> contributors and reviewers, but a bad tool makes that harder, particularly
> for new contributors who aren't used to them.
>
> Ofc, if someone knows of large projects that successfully use pylint, I'd
> appreciate learning that my view of the tool is wrong!
>
> Thanks for everyone's hard work,
> Max
>
> On 2019/04/11 20:50:01, Bas Harenslak <ba...@godatadriven.com>
> wrote:
> > Hello Airflow community,
> >
> > This email calls for a vote to introduce Pylint in the Airflow project.
> The vote will last for at least 1 week (April 18th 23:00 CET), and at least
> three +1 (binding) votes have been cast.
> >
> > After feedback on AIP-6 and discussion on Slack<
> https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400>, I
> propose to vote for adding Pylint<https://pylint.org> to the Airflow
> project for static code checking. Pylint complements Flake8 with stricter
> rules, detects code smells and is customisable so unnecessary checks can be
> ignored. This should benefit the Airflow code base with consistent,
> documented code and less errors.
> >
> > Note that Pylint 2.0 works with Python 3 only, so if the vote is
> successful, it should be introduced after dropping support for Python 2
> (AIRFLOW-4196<https://issues.apache.org/jira/browse/AIRFLOW-4196>).
> > Note2: to keep the scope as small as possible, I’ll create a separate
> vote for Black formatting.
> >
> > Cheers,
> > Bas
> >
>
Re: [VOTE] AIP-6 Apply Pylint to Airflow
Posted by .
Hi there,
I haven't been active in the airflow community so this should be weighed appropriately.
I'm a core dev of a couple of other libraries (xarray, pandas-gbq) and have led initiatives to clean up the code in both of those.
While I'm very enthusiastic about auto-formatting tools, my experience is that finding settings that aren't overly strict but still contribute is extremely difficult. Have people worked on large projects with pylint?
I thought the recent thread around improving the contribution process was insightful. Auto-enforcing coding standards can be v helpful for both new contributors and reviewers, but a bad tool makes that harder, particularly for new contributors who aren't used to them.
Ofc, if someone knows of large projects that successfully use pylint, I'd appreciate learning that my view of the tool is wrong!
Thanks for everyone's hard work,
Max
On 2019/04/11 20:50:01, Bas Harenslak <ba...@godatadriven.com> wrote:
> Hello Airflow community,
>
> This email calls for a vote to introduce Pylint in the Airflow project. The vote will last for at least 1 week (April 18th 23:00 CET), and at least three +1 (binding) votes have been cast.
>
> After feedback on AIP-6 and discussion on Slack<https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400>, I propose to vote for adding Pylint<https://pylint.org> to the Airflow project for static code checking. Pylint complements Flake8 with stricter rules, detects code smells and is customisable so unnecessary checks can be ignored. This should benefit the Airflow code base with consistent, documented code and less errors.
>
> Note that Pylint 2.0 works with Python 3 only, so if the vote is successful, it should be introduced after dropping support for Python 2 (AIRFLOW-4196<https://issues.apache.org/jira/browse/AIRFLOW-4196>).
> Note2: to keep the scope as small as possible, I’ll create a separate vote for Black formatting.
>
> Cheers,
> Bas
>