[GitHub] [incubator-openwhisk-runtime-java] upgle commented on a change in pull request #82: Support OpenJDK 11 runtime

[GitBox <gi...@apache.org>]

upgle commented on a change in pull request #82: Support OpenJDK 11 runtime
URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/82#discussion_r273399977
 
 

 ##########
 File path: core/java11/Dockerfile
 ##########
 @@ -0,0 +1,38 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+FROM adoptopenjdk/openjdk11-openj9:x86_64-ubuntu-jdk-11.28
+
+RUN rm -rf /var/lib/apt/lists/* && apt-get clean && apt-get update \
+	&& apt-get install -y --no-install-recommends locales \
+	&& rm -rf /var/lib/apt/lists/* \
+	&& locale-gen en_US.UTF-8
+
+ENV LANG="en_US.UTF-8" \
+	LANGUAGE="en_US:en" \
+	LC_ALL="en_US.UTF-8" \
+	VERSION=11
+
+ADD proxy /javaAction
+
+RUN cd /javaAction \
+	&& rm -rf .classpath .gitignore .gradle .project .settings Dockerfile build \
+	&& ./gradlew oneJar \
+	&& rm -rf /javaAction/src \
+	&& ./compileClassCache.sh
+
+CMD ["java", "--illegal-access=permit", "--add-opens=java.base/java.util=ALL-UNNAMED", "-Dfile.encoding=UTF-8", "-Xshareclasses:cacheDir=/javaSharedCache,readonly", "-Xquickstart", "-jar", "/javaAction/build/libs/javaAction-all.jar"]
 
 Review comment:
   ## Note
   From java 9 version, it outputs below warning messages when accessing encapsulated field by reflection.
   
   > WARNING: An illegal reflective access operation has occurred 
   WARNING: Please consider reporting this to the maintainers of Main
   WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
   WARNING: All illegal access operations will be denied in a future release
   
   #### Source code using reflection
   - JarLoader.java
   ```java
   if ("java.util.Collections$UnmodifiableMap".equals(cl.getName())) {
       Field field = cl.getDeclaredField("m");
       field.setAccessible(true); // <- here
   ```
   
   
   So, I added `--add-opens` and `--illegal-access`  VM options to access `java.util.Collections$UnmodifiableMap`.
   ```
   --add-opens java.base/java.util=ALL-UNNAMED 
   --illegal-access=permit
   ```
   
   https://stackoverflow.com/a/46230678
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services