You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by TimBarham <gi...@git.apache.org> on 2015/04/02 05:22:24 UTC
[GitHub] cordova-lib pull request: CB-8784 Prepare with no platforms should...
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/200
CB-8784 Prepare with no platforms should restore all platforms.
If `prepare` is called with no platforms specified, we prepare all installed platforms but don't restore any from `config.xml`. In this scenario, we should restore all platforms listed in `config.xml`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-8784
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/200.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #200
----
commit 7ab4ce0ee6e3cc9865d38b61af7d1fe57984b8ff
Author: Tim Barham <ti...@microsoft.com>
Date: 2015-04-02T03:19:14Z
CB-8784 Prepare with no platforms should restore all platforms.
If prepare is called with no platforms specified, we prepare all installed platforms but don't restore any from config.xml. In this scenario, we should restore all platforms listed in config.xml.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8784 Prepare with no platforms should...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/200
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8784 Prepare with no platforms should...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/200#issuecomment-89064360
+1 Restore platforms if none specified (like you're doing here)
+1 Restore the given platform(s) if they are not yet added but are listed in the config.xml
+1 to this pull request
The `cordova run missingPlatform` discussion is somewhat different. We don't know for certain that that is the user's intent except perhaps if they explicitly said `cordova run android@3.7.1`
I want to avoid adding android@3.8.0 to a project that is perhaps using an older version of other platforms. But this could/should be in the discuss thread ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8784 Prepare with no platforms should...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/200#issuecomment-89910673
Thanks Jesse. I had followed that previous conversation. My thinking here was that we decided to auto-restore on prepare. The gist seemed to be that we would auto-restore any platforms we were preparing. Since specifying no platforms means prepare all, it seemed consistent that in that scenario we should also auto-restore all platforms (and as far as I was aware that wasn't the sticking point of previous discussions).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org