You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/05/18 11:03:30 UTC
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6394: Log exception on keystore build for custom certificate
weizhouapache commented on code in PR #6394:
URL: https://github.com/apache/cloudstack/pull/6394#discussion_r875760831
##########
framework/security/src/main/java/org/apache/cloudstack/framework/security/keystore/KeystoreManagerImpl.java:
##########
@@ -109,15 +109,15 @@ public byte[] getKeystoreBits(String name, String aliasForCertificateInStore, St
try {
return CertificateHelper.buildAndSaveKeystore(certs, storePassword);
} catch (KeyStoreException e) {
- s_logger.warn("Unable to build keystore for " + name + " due to KeyStoreException");
+ s_logger.warn("Unable to build keystore for " + name + " due to KeyStoreException", e);
Review Comment:
@DaanHoogland
I have a question, is the check `if (s_logger.isDebugEnabled()) {` necessary ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org