You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/25 13:58:11 UTC

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #311: fix: workqueue need to retry when failed

gxthrj commented on a change in pull request #311:
URL: https://github.com/apache/apisix-ingress-controller/pull/311#discussion_r601510097



##########
File path: pkg/ingress/controller/apisix_route.go
##########
@@ -188,15 +188,11 @@ func (c *apisixRouteController) handleSyncErr(obj interface{}, err error) {
 		c.workqueue.Forget(obj)
 		return
 	}
-	if c.workqueue.NumRequeues(obj) < _maxRetries {

Review comment:
       I suggest to cancel the maximum number of times limit first, and add it when our admission and crd status are improved. Now we need real-time error reporting to quickly solve the problem.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org