You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@mynewt.apache.org by "rojer (via GitHub)" <gi...@apache.org> on 2026/03/31 21:56:04 UTC
[PR] nimble/host: Fix race in HCI ACL TX outstanding packets counter [mynewt-nimble]
rojer opened a new pull request, #2199:
URL: https://github.com/apache/mynewt-nimble/pull/2199
The outstanding packets counter (bhc_outstanding_pkts / avail_pkts) was decremented after ble_hs_tx_data() returned. However, by that point the controller may have already processed the packet and sent a Number of Completed Packets event, which increments avail_pkts. This race can cause avail_pkts to momentarily exceed the controller maximum, leading to buffer overflows.
Move the counter update before ble_hs_tx_data() and roll back on error.
Forward-port of https://github.com/espressif/esp-nimble/commit/f5136d2b35e3bafce3e276daaba8f55b8c695aab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: Fix race in HCI ACL TX outstanding packets counter [mynewt-nimble]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc merged PR #2199:
URL: https://github.com/apache/mynewt-nimble/pull/2199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: Fix race in HCI ACL TX outstanding packets counter [mynewt-nimble]
Posted by "rojer (via GitHub)" <gi...@apache.org>.
rojer commented on PR #2199:
URL: https://github.com/apache/mynewt-nimble/pull/2199#issuecomment-4183717492
> looks ok, could you just update commit message to fit 72 char limit to make compliance CI happy?
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org