You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by "ChiaPing Tsai (JIRA)" <ji...@apache.org> on 2016/10/18 01:16:58 UTC

[jira] [Created] (HBASE-16866) Avoid NPE in AsyncRequestFutureImpl#updateStats

ChiaPing Tsai created HBASE-16866:
-------------------------------------

             Summary: Avoid NPE in AsyncRequestFutureImpl#updateStats
                 Key: HBASE-16866
                 URL: https://issues.apache.org/jira/browse/HBASE-16866
             Project: HBase
          Issue Type: Bug
            Reporter: ChiaPing Tsai
            Priority: Minor


If region disables the stats, it won’t response any ClientProtos.RegionLoadStats to client. So the NEP will happen in AsyncRequestFutureImpl#updateStats.
We should use relevant log instead of NEP because the data manipulation shouldn’t be broken by statistics.
{noformat}
  protected void updateStats(ServerName server, Map<byte[], MultiResponse.RegionResult> results) {
      …
      ClientProtos.RegionLoadStats stat = regionStats.getValue().getStat();
      RegionLoadStats regionLoadstats = ProtobufUtil.createRegionLoadStats(stat);
      …
  }
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)