You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by jr...@apache.org on 2010/05/03 18:44:03 UTC

svn commit: r940508 - /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/request/target/basic/RedirectRequestTarget.java

Author: jrthomerson
Date: Mon May  3 16:44:02 2010
New Revision: 940508

URL: http://svn.apache.org/viewvc?rev=940508&view=rev
Log:
WICKET-2855 - do not accept null or empty redirect URL in RedirectRequestTarget


Modified:
    wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/request/target/basic/RedirectRequestTarget.java

Modified: wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/request/target/basic/RedirectRequestTarget.java
URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/request/target/basic/RedirectRequestTarget.java?rev=940508&r1=940507&r2=940508&view=diff
==============================================================================
--- wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/request/target/basic/RedirectRequestTarget.java (original)
+++ wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/request/target/basic/RedirectRequestTarget.java Mon May  3 16:44:02 2010
@@ -23,6 +23,7 @@ import org.apache.wicket.Response;
 import org.apache.wicket.markup.html.pages.RedirectPage;
 import org.apache.wicket.protocol.http.portlet.PortletRequestContext;
 import org.apache.wicket.request.target.component.listener.RedirectPageRequestTarget;
+import org.apache.wicket.util.string.Strings;
 
 /**
  * A RequestTarget that will send a redirect url to the browser. Use this if you want to direct the
@@ -53,6 +54,11 @@ public class RedirectRequestTarget imple
 	 */
 	public RedirectRequestTarget(String redirectUrl)
 	{
+		if (Strings.isEmpty(redirectUrl))
+		{
+			throw new IllegalArgumentException(
+				"The redirect URL passed to the RedirectRequestTarget constructor can not be null or empty.");
+		}
 		this.redirectUrl = redirectUrl;
 
 	}