[GitHub] [flink] pnowojski edited a comment on issue #8199: [FLINK-11955] Modify build to move filesystems from lib to plugins folder

[GitBox <gi...@apache.org>]

pnowojski edited a comment on issue #8199: [FLINK-11955] Modify build to move filesystems from lib to plugins folder
URL: https://github.com/apache/flink/pull/8199#issuecomment-505795217
 
 
   > I think there is a value in relocating the fs plugins done together with un-shading them (FLINK-11956). Because in that case, the jars would be not backwards compatible and should be loaded only via plugin manager. This way we can "force" Flink users to properly adjust their Flink setups. But in that case, I'd propose to consider keeping them under some opt/ subdir.
   
   This might be still problematic, since it would force all deployments to  "load" all file system plugins at the startup, regardless whether they are desired or not.
   
   On top of the problems reported by @zentol, I think (as @1u0 has already written) this ticket might be invalid. When we were creating it with @StefanRRichter, we didn't expect https://issues.apache.org/jira/browse/FLINK-12143 to basically subsume this. We thought that currently file system jars are being put into the `lib` directory by default by the build system. Since users are expected to move/copy the jars from `opt` to `lib` or `plugins` manually, it might well be that we don't need this (FLINK-11955) PR.
   
   I'm closing this PR & Jira ticket for now. We can continue discussing in the Jira ticket and we can always re-open both PR and/or Jira ticket if we decide otherwise.
   
   Sorry @yanghua for the confusion and thank you @zentol and @1u0 for the review & analysis.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services