[GitHub] [airflow] potiuk commented on issue #20741: CI: Reuse Breeze CI image building for CI

[GitBox <gi...@apache.org>]

potiuk commented on issue #20741:
URL: https://github.com/apache/airflow/issues/20741#issuecomment-1045882611


   > @potiuk I changed the file ci_build_ci_image_on_ci.sh for build_image.py, it is the unique part where we call to build the image. Please let me know if I am in the right way.
   > 
   > https://github.com/edithturn/airflow/blob/a02e8562a01b251d214f06f69bf1f15c91af536c/.github/workflows/build-images.yml#L231-L235
   
   Yeah. But we also should make it an entrypoint similar to "airflow-freespace", (`airlfow-build-image`) this way when we run it in CI, we shoudl be able to - similarly as `airflow-freespace` run it as `run: airflow-build-image`. 
   
   > Another thing I was thinking is If I finished building the image, it means that it is ready to push and It is made for ci_push_ci_images.sh, and it makes a login in docker registry to push the image. Will, it is possible to test it in my docker registry with my own credentials? How will I prove that the image is well built and ready to upload?
   
   Yeah. It should work in your repo. That should be no problem. If everything works fine with the build image and all the variables are properly used, the image should be built as:
   
   ```
   ghcr.io/edithurn/airflow/main/ci/python3.7
   ```
   
   GIHUB_REPOSITORY variable should be used to determine that.
   
   See for example here: https://github.com/potiuk/airflow/runs/5177272408?check_suite_focus=true
   
   ```
   Build CI image ghcr.io/potiuk/airflow/main/ci/python3.7
   ```
   
   Of course there might be some issues with the python build_image.py to use that variable (we did not try it before) - but then this is something that should be fixed if it will continue using "apache/airflow" :).
   
   > Note: I am testing it in my own remote since these are changes made in the build-image.yaml
   
   Yep. The only way to test it :)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org