You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Jeff Turner <je...@socialchange.net.au> on 2002/03/24 12:35:59 UTC

[PATCH] Maven build broken? encoding problems

Hi,

I'm trying to build Maven from CVS, following the instructions at
http://jakarta.apache.org/turbine/maven/bootstrap.html

When I get to the 'ant maven:jar' stage, the compile fails with this sort of error:

javac.compile:
    [mkdir] Created dir: /home/jeff/apache/jakarta/jakarta-turbine-maven/target/classes
    [javac] Compiling 220 source files to /home/jeff/apache/jakarta/jakarta-turbine-maven/target/classes
    [javac] 
    [javac] Found 9 semantic errors compiling "/home/jeff/apache/jakarta/jakarta-turbine-maven/src/java/org/apache/maven/importscrubber/Resources_fr.java":
    [javac] 
    [javac]     60.         {FILE_BROWSER_TITLE, "Note: les fichiers binaires (.class) et les fichiers sources doivent \u00/*tre dans le m\u00/*me r\u00/)pertoire"},
    [javac]                                      <------------------------------------------------------------------------------------------------->
...
    [javac]     75.         {BREAK_NONE, "Pas d'arr\u00/*ts"},
    [javac]                              <------------>
    [javac] *** Error: The value of this "String" literal is invalid. Perhaps it contains a bad escape sequence?


It looks like the 8-bit characters in Resources_fr.java need to be escaped with
Java's \uXXXX syntax. The attached patch does this.

In general, it might be better to store strings like this in properties files,
where Java's encoding rules don't cause problems.

Also, the build process assumes the user has junit.jar in their ${ant.home}/lib
directory. The second attached patch documents this.

thanks,


--Jeff

(looking to convert Avalon's build system to Maven..)



Re: [PATCH] Maven build broken? encoding problems

Posted by Jason van Zyl <jv...@zenplex.com>.
On Mon, 2002-03-25 at 14:46, Jason van Zyl wrote:
> On Mon, 2002-03-25 at 15:50, Daniel Rall wrote:
> > Jeff Turner <je...@socialchange.net.au> writes:
> > 
> 
> > FWIW, I've had problems of this type using Jikes 1.13.  Using javac
> > from JDK 1.3.1 worked.
> 
> This is exactly the kind of info we can propogate using so that the
> issue is dealt with once and everyone benefits :-)

That's "propogate using Maven". My bad.

> > --
> > To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> > For additional commands, e-mail: <ma...@jakarta.apache.org>
> -- 
> jvz.
> 
> Jason van Zyl
> jvanzyl@apache.org
> 
> http://tambora.zenplex.org
> 
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
-- 
jvz.

Jason van Zyl
jvanzyl@apache.org

http://tambora.zenplex.org


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [PATCH] Maven build broken? encoding problems

Posted by Jason van Zyl <jv...@zenplex.com>.
On Mon, 2002-03-25 at 15:50, Daniel Rall wrote:
> Jeff Turner <je...@socialchange.net.au> writes:
> 

> FWIW, I've had problems of this type using Jikes 1.13.  Using javac
> from JDK 1.3.1 worked.

This is exactly the kind of info we can propogate using so that the
issue is dealt with once and everyone benefits :-)
 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
-- 
jvz.

Jason van Zyl
jvanzyl@apache.org

http://tambora.zenplex.org


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [PATCH] Maven build broken? encoding problems

Posted by Daniel Rall <dl...@finemaltcoding.com>.
Jeff Turner <je...@socialchange.net.au> writes:

> Hi,
>
> I'm trying to build Maven from CVS, following the instructions at
> http://jakarta.apache.org/turbine/maven/bootstrap.html
>
> When I get to the 'ant maven:jar' stage, the compile fails with this sort of error:
>
> javac.compile:
>     [mkdir] Created dir: /home/jeff/apache/jakarta/jakarta-turbine-maven/target/classes
>     [javac] Compiling 220 source files to /home/jeff/apache/jakarta/jakarta-turbine-maven/target/classes
>     [javac] 
>     [javac] Found 9 semantic errors compiling "/home/jeff/apache/jakarta/jakarta-turbine-maven/src/java/org/apache/maven/importscrubber/Resources_fr.java":
>     [javac] 
>     [javac]     60.         {FILE_BROWSER_TITLE, "Note: les fichiers binaires (.class) et les fichiers sources doivent \u00/*tre dans le m\u00/*me r\u00/)pertoire"},
>     [javac]                                      <------------------------------------------------------------------------------------------------->
> ...
>     [javac]     75.         {BREAK_NONE, "Pas d'arr\u00/*ts"},
>     [javac]                              <------------>
>     [javac] *** Error: The value of this "String" literal is invalid. Perhaps it contains a bad escape sequence?
>
>
> It looks like the 8-bit characters in Resources_fr.java need to be escaped with
> Java's \uXXXX syntax. The attached patch does this.
>
> In general, it might be better to store strings like this in properties files,
> where Java's encoding rules don't cause problems.
>
> Also, the build process assumes the user has junit.jar in their ${ant.home}/lib
> directory. The second attached patch documents this.

FWIW, I've had problems of this type using Jikes 1.13.  Using javac
from JDK 1.3.1 worked.

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [PATCH] Maven build broken? encoding problems

Posted by Jason van Zyl <jv...@zenplex.com>.
On Sun, 2002-03-24 at 06:35, Jeff Turner wrote:
> Hi,
> 
> I'm trying to build Maven from CVS, following the instructions at
> http://jakarta.apache.org/turbine/maven/bootstrap.html
> 

Meant to also say the patches are applied, thanks.

-- 
jvz.

Jason van Zyl
jvanzyl@apache.org

http://tambora.zenplex.org


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [PATCH] Maven build broken? encoding problems

Posted by Jason van Zyl <jv...@zenplex.com>.
On Sun, 2002-03-24 at 06:35, Jeff Turner wrote:
> Hi,
> 
> I'm trying to build Maven from CVS, following the instructions at
> http://jakarta.apache.org/turbine/maven/bootstrap.html
> 
> 
> --Jeff
> 
> (looking to convert Avalon's build system to Maven..)

Good luck!

-- 
jvz.

Jason van Zyl
jvanzyl@apache.org

http://tambora.zenplex.org


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>