You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2019/04/01 13:23:14 UTC

[GitHub] [drill] ihuzenko commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

ihuzenko commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option
URL: https://github.com/apache/drill/pull/1714#discussion_r270863652
 
 

 ##########
 File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2489CallsAfterCloseThrowExceptionsTest.java
 ##########
 @@ -537,8 +537,6 @@ public void testclosedPreparedStmtOfOpenConnMethodsThrowRight() {
         new ClosedPreparedStatementChecker(PreparedStatement.class,
                                            closedPreparedStmtOfOpenConn);
 
-    checker.testAllMethods();
 
 Review comment:
   Does deletion of the line means that test now checks nothing ? Maybe it's accidental change and needs revert or test method may be safely removed ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services