You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/01/25 10:06:20 UTC

[GitHub] [hudi] liujinhui1994 commented on pull request #3614: [HUDI-2370] Supports data encryption

liujinhui1994 commented on pull request #3614:
URL: https://github.com/apache/hudi/pull/3614#issuecomment-1021014765


   > @liujinhui1994 some high level feedback:
   > 
   > * can you put some more info in the PR description to explain the high-level functionalities we want to add here?
   > * parquet 1.12 is only used when hudi is built with spark 3.2. the encryption feature needs to be somehow guarded by checking the intended spark version. so we need to find a way to make the functionality only available when people using spark 3.2+
   
   Point 1:  already added
   Point 2: Is it possible to add a description to the InMemoryKMS annotation? Only allow spark3.2+ to use it, or if there is any other good suggestion please let me know


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org