[GitHub] [logging-log4j2] garydgregory commented on pull request #564: LOG4J2-3122 fix Logging to Log4j2 MongoDb4 Appender get ERROR on trace, debug and info level.

[GitBox <gi...@apache.org>]

garydgregory commented on pull request #564:
URL: https://github.com/apache/logging-log4j2/pull/564#issuecomment-903173794


   > After do some debugging, i found out that there are some part of the code that is missing in MongoDb4Provider class when creating log4j-mongodb4 module, knowing that this part of the code is exists in log4j-mongodb3 module. The code that check if the database actually requires authentication. I don't know if that is intentional or not but somehow this part of the code is what making the old log4j-mongodb3 module running without error. So i just copy the old code to the new log4j-mongodb4 module, and now it is running without error to. What do you think about this log4j2 team?
   > Please respond.
   > Thanks.
   
   Hi @redapel 
   Yes, it was intentional, with the version 4 driver, anything should be configurable from the connection string, unlike with the version 3 driver IIRC.
   
   In general, you'll want to provide tests for new code. If you'd included a test with a configuration file, we could have determined if that was the code... so it still might be the case, but, no test...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org