You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2019/12/14 00:32:53 UTC

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #354: HDDS-2724. Sonar : Fix sonar issues in package 'org.apache.hadoop.ozo…

bharatviswa504 commented on a change in pull request #354: HDDS-2724. Sonar : Fix sonar issues in package 'org.apache.hadoop.ozo…
URL: https://github.com/apache/hadoop-ozone/pull/354#discussion_r357880770
 
 

 ##########
 File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/OMDBUpdateEvent.java
 ##########
 @@ -107,7 +107,7 @@ OMUpdateEventBuilder setSequenceNumber(long sequenceNumber) {
      * @return OMDBUpdateEvent
      */
     public OMDBUpdateEvent build() {
-      return new OMDBUpdateEvent<KEY, VALUE>(
+      return new OMDBUpdateEvent<K1, V1>(
 
 Review comment:
   Can we leave the Generic Types to actual KEY, VALUE instead of K1, V1. I feel it is more readable than single letters.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org