You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/06 16:09:21 UTC
[GitHub] [flink] LadyForest opened a new pull request #15101: [FLINK-21641][python] Support 'useModules' and 'listFullModules' in PyFlink
LadyForest opened a new pull request #15101:
URL: https://github.com/apache/flink/pull/15101
## What is the purpose of the change
This pull request supports `useModules` and `listFullModules` in PyFlink to keep Table API consistent.
## Brief change log
- Add implementation of interface method `useModules` and `listFullModules` in `TableEnvironment`.
- Add class `ModuleEntry` for converting result of `useModules`.
- Add class `ModuleMock` for testing.
## Verifying this change
This change added tests and can be verified as follows:
- Remove `loadModule/unloadModule/listModules/useModules/listFullModules` from `EnvironmentAPICompletenessTests`.
- Add more tests for `load_modules` and `unload_modules` in `TableEnvironmentTest` and `BatchTableEnvironmentTests`.
- Add tests for `use_modules` and `list_full_modules` in `TableEnvironmentTest` and `BatchTableEnvironmentTests`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
- Docs will be updated after FLINK-21300 finish.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15101: [FLINK-21641][python] Support 'useModules' and 'listFullModules' in PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15101:
URL: https://github.com/apache/flink/pull/15101#issuecomment-791983297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "642045406a87997c1e9e5e7ccff74017490e8b27",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14230",
"triggerID" : "642045406a87997c1e9e5e7ccff74017490e8b27",
"triggerType" : "PUSH"
}, {
"hash" : "ea6df37a831ec171cf0c235be2e49cd6d263597f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14287",
"triggerID" : "ea6df37a831ec171cf0c235be2e49cd6d263597f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 642045406a87997c1e9e5e7ccff74017490e8b27 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14230)
* ea6df37a831ec171cf0c235be2e49cd6d263597f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14287)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15101: [FLINK-21641][python] Support 'useModules' and 'listFullModules' in PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15101:
URL: https://github.com/apache/flink/pull/15101#issuecomment-791983297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "642045406a87997c1e9e5e7ccff74017490e8b27",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "642045406a87997c1e9e5e7ccff74017490e8b27",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 642045406a87997c1e9e5e7ccff74017490e8b27 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15101: [FLINK-21641][python] Support 'useModules' and 'listFullModules' in PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15101:
URL: https://github.com/apache/flink/pull/15101#issuecomment-791979758
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 642045406a87997c1e9e5e7ccff74017490e8b27 (Sat Mar 06 16:11:54 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-21641).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LadyForest commented on pull request #15101: [FLINK-21641][python] Support 'useModules' and 'listFullModules' in PyFlink
Posted by GitBox <gi...@apache.org>.
LadyForest commented on pull request #15101:
URL: https://github.com/apache/flink/pull/15101#issuecomment-792416948
> @LadyForest Thanks for the PR! LGTM overall. It would be great to also update the documentation: https://ci.apache.org/projects/flink/flink-docs-master/docs/dev/table/modules/
Hi, @dianfu thanks for the comments. There is a separate Jira task FLINK-21300 to track docs update. It's a subtask of FLINK-21045.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15101: [FLINK-21641][python] Support 'useModules' and 'listFullModules' in PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15101:
URL: https://github.com/apache/flink/pull/15101#issuecomment-791983297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "642045406a87997c1e9e5e7ccff74017490e8b27",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14230",
"triggerID" : "642045406a87997c1e9e5e7ccff74017490e8b27",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 642045406a87997c1e9e5e7ccff74017490e8b27 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14230)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15101: [FLINK-21641][python] Support 'useModules' and 'listFullModules' in PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15101:
URL: https://github.com/apache/flink/pull/15101#issuecomment-791983297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "642045406a87997c1e9e5e7ccff74017490e8b27",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14230",
"triggerID" : "642045406a87997c1e9e5e7ccff74017490e8b27",
"triggerType" : "PUSH"
}, {
"hash" : "ea6df37a831ec171cf0c235be2e49cd6d263597f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ea6df37a831ec171cf0c235be2e49cd6d263597f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 642045406a87997c1e9e5e7ccff74017490e8b27 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14230)
* ea6df37a831ec171cf0c235be2e49cd6d263597f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu merged pull request #15101: [FLINK-21641][python] Support 'useModules' and 'listFullModules' in PyFlink
Posted by GitBox <gi...@apache.org>.
dianfu merged pull request #15101:
URL: https://github.com/apache/flink/pull/15101
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LadyForest commented on a change in pull request #15101: [FLINK-21641][python] Support 'useModules' and 'listFullModules' in PyFlink
Posted by GitBox <gi...@apache.org>.
LadyForest commented on a change in pull request #15101:
URL: https://github.com/apache/flink/pull/15101#discussion_r589135787
##########
File path: flink-python/pyflink/table/module_entry.py
##########
@@ -0,0 +1,54 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+from pyflink.java_gateway import get_gateway
+
+__all__ = ['ModuleEntry']
+
+
+class ModuleEntry(object):
Review comment:
> What about moving this class to module.py?
+1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on a change in pull request #15101: [FLINK-21641][python] Support 'useModules' and 'listFullModules' in PyFlink
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #15101:
URL: https://github.com/apache/flink/pull/15101#discussion_r589136960
##########
File path: flink-python/src/main/java/org/apache/flink/python/util/ModuleMock.java
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.python.util;
+
+import org.apache.flink.table.module.Module;
+
+/** Mocking {@link Module} for Python tests. */
+public class ModuleMock implements Module {
Review comment:
Could we reuse the ModuleMock defined in flink-table-api-java module? Could use _load_specific_flink_module_jars on how to load classes defined in test jar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15101: [FLINK-21641][python] Support 'useModules' and 'listFullModules' in PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15101:
URL: https://github.com/apache/flink/pull/15101#issuecomment-791983297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "642045406a87997c1e9e5e7ccff74017490e8b27",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14230",
"triggerID" : "642045406a87997c1e9e5e7ccff74017490e8b27",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 642045406a87997c1e9e5e7ccff74017490e8b27 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14230)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15101: [FLINK-21641][python] Support 'useModules' and 'listFullModules' in PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15101:
URL: https://github.com/apache/flink/pull/15101#issuecomment-791983297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "642045406a87997c1e9e5e7ccff74017490e8b27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14230",
"triggerID" : "642045406a87997c1e9e5e7ccff74017490e8b27",
"triggerType" : "PUSH"
}, {
"hash" : "ea6df37a831ec171cf0c235be2e49cd6d263597f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14287",
"triggerID" : "ea6df37a831ec171cf0c235be2e49cd6d263597f",
"triggerType" : "PUSH"
}, {
"hash" : "b31ad0cdf5f110594628b97376ef40220bd9af17",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14324",
"triggerID" : "b31ad0cdf5f110594628b97376ef40220bd9af17",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ea6df37a831ec171cf0c235be2e49cd6d263597f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14287)
* b31ad0cdf5f110594628b97376ef40220bd9af17 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14324)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15101: [FLINK-21641][python] Support 'useModules' and 'listFullModules' in PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15101:
URL: https://github.com/apache/flink/pull/15101#issuecomment-791983297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "642045406a87997c1e9e5e7ccff74017490e8b27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14230",
"triggerID" : "642045406a87997c1e9e5e7ccff74017490e8b27",
"triggerType" : "PUSH"
}, {
"hash" : "ea6df37a831ec171cf0c235be2e49cd6d263597f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14287",
"triggerID" : "ea6df37a831ec171cf0c235be2e49cd6d263597f",
"triggerType" : "PUSH"
}, {
"hash" : "b31ad0cdf5f110594628b97376ef40220bd9af17",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b31ad0cdf5f110594628b97376ef40220bd9af17",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ea6df37a831ec171cf0c235be2e49cd6d263597f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14287)
* b31ad0cdf5f110594628b97376ef40220bd9af17 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15101: [FLINK-21641][python] Support 'useModules' and 'listFullModules' in PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15101:
URL: https://github.com/apache/flink/pull/15101#issuecomment-791983297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "642045406a87997c1e9e5e7ccff74017490e8b27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14230",
"triggerID" : "642045406a87997c1e9e5e7ccff74017490e8b27",
"triggerType" : "PUSH"
}, {
"hash" : "ea6df37a831ec171cf0c235be2e49cd6d263597f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14287",
"triggerID" : "ea6df37a831ec171cf0c235be2e49cd6d263597f",
"triggerType" : "PUSH"
}, {
"hash" : "b31ad0cdf5f110594628b97376ef40220bd9af17",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14324",
"triggerID" : "b31ad0cdf5f110594628b97376ef40220bd9af17",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b31ad0cdf5f110594628b97376ef40220bd9af17 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14324)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LadyForest commented on pull request #15101: [FLINK-21641][python] Support 'useModules' and 'listFullModules' in PyFlink
Posted by GitBox <gi...@apache.org>.
LadyForest commented on pull request #15101:
URL: https://github.com/apache/flink/pull/15101#issuecomment-792549067
Hi @dianfu, I've updated the PR, and you can take a look after CI passes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on a change in pull request #15101: [FLINK-21641][python] Support 'useModules' and 'listFullModules' in PyFlink
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #15101:
URL: https://github.com/apache/flink/pull/15101#discussion_r589129781
##########
File path: flink-python/pyflink/table/module_entry.py
##########
@@ -0,0 +1,54 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+from pyflink.java_gateway import get_gateway
+
+__all__ = ['ModuleEntry']
+
+
+class ModuleEntry(object):
Review comment:
What about moving this class to module.py?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15101: [FLINK-21641][python] Support 'useModules' and 'listFullModules' in PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15101:
URL: https://github.com/apache/flink/pull/15101#issuecomment-791983297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "642045406a87997c1e9e5e7ccff74017490e8b27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14230",
"triggerID" : "642045406a87997c1e9e5e7ccff74017490e8b27",
"triggerType" : "PUSH"
}, {
"hash" : "ea6df37a831ec171cf0c235be2e49cd6d263597f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14287",
"triggerID" : "ea6df37a831ec171cf0c235be2e49cd6d263597f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ea6df37a831ec171cf0c235be2e49cd6d263597f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14287)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org