You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Disha Singh <di...@gmail.com> on 2016/03/08 15:22:37 UTC
Re: Review Request 43920: Added a helper function to stout :
os/which.hpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43920/
-----------------------------------------------------------
(Updated March 8, 2016, 2:22 p.m.)
Review request for mesos and Joseph Wu.
Bugs: MESOS-4576
https://issues.apache.org/jira/browse/MESOS-4576
Repository: mesos
Description
-------
Added a helper function to stout : os/which.hpp.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/43920/diff/
Testing
-------
Thanks,
Disha Singh
Re: Review Request 43920: Added a helper function to stout :
os/which.hpp.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43920/#review122613
-----------------------------------------------------------
Looks good. Before I give a "Ship It!", your next steps should be:
- Add a unit test.
- Modify the following classes in src/tests/environment.cpp:
- CurlFilter
- LogrotateFilter
- NetcatFilter
- PerfCPUCyclesFilter
- PerfFilter
- Modify PortMappingIsolatorTest::SetUpTestCase in src/tests/containerizer/port_mapping_tests.cpp
- Modify the `sha512` command in src/common/command_utils.cpp
- Modify the `logrotate_path` flag validation logic in src/slave/container_loggers/lib_logrotate.hpp and logrotate.hpp
3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp (line 25)
<https://reviews.apache.org/r/43920/#comment184720>
Nit: s/os{/os {/
3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp (lines 27 - 28)
<https://reviews.apache.org/r/43920/#comment184721>
Suggestion:
Searches for an executable `command` on the environment variable `PATH`. If found, returns the absolute path to the command. Otherwise, returns `None`.
3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp (line 51)
<https://reviews.apache.org/r/43920/#comment184723>
Nit: no indent here.
3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp (line 52)
<https://reviews.apache.org/r/43920/#comment184724>
Nit: add one newline preceding this line.
- Joseph Wu
On March 8, 2016, 6:22 a.m., Disha Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43920/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 6:22 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-4576
> https://issues.apache.org/jira/browse/MESOS-4576
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a helper function to stout : os/which.hpp.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43920/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Disha Singh
>
>
Re: Review Request 43920: Added a helper function to stout :
os/which.hpp.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43920/#review122552
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43920]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 8, 2016, 2:22 p.m., Disha Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43920/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 2:22 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-4576
> https://issues.apache.org/jira/browse/MESOS-4576
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a helper function to stout : os/which.hpp.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43920/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Disha Singh
>
>