You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Dan Christian <dc...@google.com> on 2007/08/24 16:28:57 UTC
Re: No progress byte data for neon/serf
Just to follow up to myself.
It looks like this broke when I switched from a released neon to
trunk. The neon-0.27 still gives me progress values. This looks like
a neon issue.
-Dan C
On 7/9/07, Dan Christian <dc...@google.com> wrote:
> I'm setting context->progress_func and then reading the apr_off_t
> progress parameter to get an idea about data transfered.
>
> This works fine for svn protocol and used to work fine for neon and
> serf. Sometime between May 16 and June 21, it stopped working for
> neon and serf.
>
> Any ideas why 'progress' isn't being set for the DAV protocols anymore?
>
> -Dan C
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [neon] Re: No progress byte data for neon/serf
Posted by Joe Orton <jo...@manyfish.co.uk>.
On Fri, Aug 24, 2007 at 09:28:57AM -0700, Dan Christian wrote:
> Just to follow up to myself.
>
> It looks like this broke when I switched from a released neon to
> trunk. The neon-0.27 still gives me progress values. This looks like
> a neon issue.
Hi Dan, the response progress reporting was broken on the trunk for a
while, and is broken in the 0.27.0 release (a regression since previous
releases) - the patch below will be in 0.27.1, and has been on the trunk
for a couple of days.
Index: src/ne_request.c
===================================================================
--- src/ne_request.c (revision 1235)
+++ src/ne_request.c (revision 1236)
@@ -771,8 +771,7 @@
return -1;
if (readlen) {
- req->session->status.sr.progress =
- resp->mode == R_CLENGTH ? resp->body.clen.total : 0;
+ req->session->status.sr.progress += readlen;
notify_status(req->session, ne_status_recving);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: No progress byte data for neon/serf
Posted by Daniel Rall <dl...@finemaltcoding.com>.
Ahh, due to the data type conflicts highlighted by the patch you
posted subsequently...thanks for the follow-up, Dan C.
On Aug 24, 2007, at 9:28 AM, Dan Christian wrote:
> Just to follow up to myself.
>
> It looks like this broke when I switched from a released neon to
> trunk. The neon-0.27 still gives me progress values. This looks like
> a neon issue.
>
> -Dan C
>
> On 7/9/07, Dan Christian <dc...@google.com> wrote:
>> I'm setting context->progress_func and then reading the apr_off_t
>> progress parameter to get an idea about data transfered.
>>
>> This works fine for svn protocol and used to work fine for neon and
>> serf. Sometime between May 16 and June 21, it stopped working for
>> neon and serf.
>>
>> Any ideas why 'progress' isn't being set for the DAV protocols
>> anymore?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org