You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/09/19 23:46:17 UTC
[I] Remove the unused scroll-to-step request stream from AgentService [texera]
aglinxinyuan opened a new issue, #8610:
URL: https://github.com/apache/texera/issues/8610
### Task Summary
`AgentService`'s scroll-to-step request stream can never fire. The only producer, `requestScrollToStep()`, has no caller in production, so the subject never emits, the `agent-chat` subscriber never runs, and the private `scrollToStep()` it would call is unreachable.
### History
| | |
| --- | --- |
| **Introduced by** | #4495 (2026-04-27) — "feat(agent-service): add `agent-service` that manages LLM agents", which shipped the full chain: subject, observable, producer, subscriber and scroll handler |
| **Usage removed by** | **never wired up** — no file outside `agent.service.ts` has called `requestScrollToStep` at any point in the history. No UI control invokes it |
Dead since it was written. The whole chain goes: the subject and observable, the producer, the `agent-chat` subscription, and the private `scrollToStep` it dispatches to.
Pure deletion, no behaviour change: −74 lines.
### Task Type
- [x] Refactor / Cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove the unused scroll-to-step request stream from AgentService [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan closed issue #8610: Remove the unused scroll-to-step request stream from AgentService
URL: https://github.com/apache/texera/issues/8610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org