You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/08 01:51:40 UTC
[PR] fix: clean Metrics data source bindings when deleting instances [rocketmq-dashboard]
Aias00 opened a new pull request, #1265:
URL: https://github.com/apache/rocketmq-dashboard/pull/1265
Closes #1264
## Summary
- remove a deleted instance from configured Metrics data-source bindings
- retain empty bindings as globally available sources
- execute instance deletion and binding cleanup in one transaction
## Validation
- `JAVA_HOME=$( /usr/libexec/java_home -v 21 ) PATH="$JAVA_HOME/bin:$PATH" mvn -Dtest=InstanceServiceTest,SettingsServiceTest test`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: clean Metrics data source bindings when deleting instances [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed pull request #1265: fix: clean Metrics data source bindings when deleting instances
URL: https://github.com/apache/rocketmq-dashboard/pull/1265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: clean Metrics data source bindings when deleting instances [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #1265:
URL: https://github.com/apache/rocketmq-dashboard/pull/1265#issuecomment-5226784123
Superseded by #1261, which now includes this instance-deletion binding cleanup and its regression tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org